mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-04-20 00:20:47 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
745debe9ecb8dccafdd18fdd84f32ac121598508
scylladb/utils
History
Botond Dénes 33682fd14e Merge 'sstables/storage_manager: fix race between object storage config update and keyspace creation' from Dimitrios Symonidis 
Previously, config_updater used a serialized_action to trigger update_config() when object_storage_endpoints changed. Because serialized_action::trigger() always schedules the action as a new reactor task (via semaphore::wait().then()), there was a window between the config value becoming visible to the REST API and update_config() actually running. This allowed a concurrent CREATE KEYSPACE to see the new endpoint via is_known_endpoint() before storage_manager had registered it in _object_storage_endpoints.

Now config observers run synchronously in a reactor turn and must not suspend. Split the previous monolithic async update_config() coroutine  into two phases:

- Sync (in the observer, never suspends): storage_manager::_object_storage_endpoints is updated in place; for already-instantiated clients, update_config_sync swaps the new config atomically
- Async (per-client gate): background fibers finish the work that can't run in the observer — S3 refreshes credentials under _creds_sem; GCS drains and closes the replaced client.

Config reloads triggered by SIGHUP are applied on shard 0 and then broadcast to all other shards. An rwlock has been also introduced to make sure that the configuration has been propagated to all cores. This guarantees that a client requesting a config via the REST API will see a consistent snapshot

Fixes: https://scylladb.atlassian.net/browse/SCYLLADB-757
Fixes: [28141](https://github.com/scylladb/scylladb/issues/28141)

Closes scylladb/scylladb#28950

* github.com:scylladb/scylladb:
  test/object_store: verify object storage client creation and live reconfiguration
  sstables/utils/s3: split config update into sync and async parts
  test_config: improve logging for wait_for_config API
  db: introduce read-write lock to synchronize config updates with REST API
2026-04-16 10:20:43 +03:00
..
abi
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
azure/identity
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
gcp
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
gz
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
lsa
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
rest
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
s3
sstables/utils/s3: split config update into sync and async parts
2026-04-15 14:28:31 +02:00
abstract_formatter.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
alien_worker.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
alien_worker.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
allocation_strategy.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
amortized_reserve.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
anchorless_list.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
array-search.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
array-search.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
ascii.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
ascii.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
assert.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
atomic_vector.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
aws_sigv4.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
aws_sigv4.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
base64.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
base64.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
big_decimal.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
big_decimal.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
bit_cast.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
bloom_calculations.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
bloom_calculations.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
bloom_filter.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
bloom_filter.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
bounded_stats_deque.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
bptree.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
buffer_view-to-managed_bytes_view.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
build_id.cc
…
build_id.hh
…
cached_file_stats.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
cached_file.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
checked-file-impl.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
chunked_vector.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
class_registrator.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
clmul.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
CMakeLists.txt
object_storage: add retryable machinery to object storage
2026-02-22 14:00:44 +02:00
coarse_steady_clock.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
collection-concepts.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
compact-radix-tree.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
composite_abort_source.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
config_file_impl.hh
Merge 'Make inclusion of config.hh cheaper' from Nadav Har'El
2026-04-15 14:40:15 +03:00
config_file.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
config_file.hh
Merge 'Make inclusion of config.hh cheaper' from Nadav Har'El
2026-04-15 14:40:15 +03:00
contiguous_shared_buffer.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
coroutine.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
crc.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
cross-shard-barrier.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
crypt_sha512.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
crypt_sha512.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
data_input.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
date.h
…
digest_algorithm.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
digester.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
directories.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
directories.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
disk_space_monitor.cc
utils: avoid exceptions in disk_space_monitor polling loop
2026-04-15 14:40:15 +03:00
disk_space_monitor.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
disk-error-handler.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
disk-error-handler.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
div_ceil.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
double-decker.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
dynamic_bitset.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
dynamic_bitset.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
entangled.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
enum_option.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
error_injection.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
error_injection.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
estimated_histogram.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
exception_container.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
exceptions.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
exceptions.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
exponential_backoff_retry.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
extremum_tracking.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
file_lock.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
file_lock.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
flush_queue.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
fragment_range.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
fragmented_temporary_buffer.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
from_chars_exactly.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
hash.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
hashers.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
hashers.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
hashing.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
histogram_metrics_helper.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
histogram_metrics_helper.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
histogram.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
http_client_error_processing.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
http_client_error_processing.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
http.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
http.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
human_readable.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
human_readable.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
i_filter.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
i_filter.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
immutable-collection.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
input_stream.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
int_range.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
interval.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
intrusive_btree.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
intrusive-array.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
io-wrappers.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
io-wrappers.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
labels.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
labels.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
large_bitset.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
large_bitset.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
latency.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
lexicographical_compare.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
like_matcher.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
like_matcher.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
linearizing_input_stream.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
lister.cc
Update seastar submodule
2025-12-30 19:37:13 +03:00
lister.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
loading_cache.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
loading_shared_values.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
log_heap.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
log.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
logalloc.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
logalloc.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
lru_string_map.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
lru.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
managed_bytes.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
managed_bytes.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
managed_ref.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
managed_string.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
managed_vector.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
map_difference.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
maybe_yield.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
memory_data_sink.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
memory_limit_reached.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
multiprecision_int.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
multiprecision_int.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
murmur_hash.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
murmur_hash.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
mutable_view.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
neat-object-id.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
observable.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
on_internal_error.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
on_internal_error.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
only_on_shard0.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
overloaded_functor.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
phased_barrier.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
pluggable.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
preempt.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
pretty_printers.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
pretty_printers.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
rate_limiter.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
rate_limiter.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
recent_entries_map.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
refcounted.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
replicator.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
reservoir_sampling.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
result_combinators.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
result_loop.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
result_try.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
result.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
reusable_buffer.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
rjson.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
rjson.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
rolling_max_tracker.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
rpc_utils.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
runtime.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
runtime.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
scoped_item_list.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
seekable_source.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
sequenced_set.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
sequential_producer.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
serialization.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
serialized_action.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
simple_hashers.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
simple_value_with_expiry.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
small_vector.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
sorting.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
stall_free.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
streaming_histogram.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
tagged_integer.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
throttle.hh
…
to_string.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
to_string.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
top_k.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
tuple_utils.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
unconst.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
unique_view.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
updateable_value.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
updateable_value.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
upload_progress.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
user_provided_param.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
utf8.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
utf8.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
UUID_gen.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
UUID_gen.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
uuid.cc
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
UUID.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
value_or_reference.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
variant_element.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
vle.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00
xx_hasher.hh
LICENSE: Update to version 1.1
2026-04-12 19:46:33 +03:00