mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-28 12:17:02 +00:00
76227fafad
All tests in cql-pytest use a test keyspace created with the SimpleStrategy replication strategy. This was never intentional. We are recommending to users that they should use NetworkTopologyStrategy instead, and even want to deprecate SimpleStrategy (this is #8586), so tests should stop using SimpleStrategy and should start using the same strategy users would use in their applications - NetworkTopologyStrategy. Almost all tests are fixed by a single change in conftest.py which changes how "test_keyspace" is created. But additionally, tests in test_keyspace.py which explicitly create keyspaces (that's the point of that test file...) also had to be modified to use NetworkTopologyStrategy. Note that none of the tests relied on any special features or implementation details of SimpleStrategy. This patch is part of the bigger effort to remove reliance on SimpleStrategy from all tests, of all types - which we will need to do if we ever want to forbid SimpleStrategy by default. The issue of that effort: Refs #8638 Signed-off-by: Nadav Har'El <nyh@scylladb.com> Message-Id: <20210620102341.195533-1-nyh@scylladb.com>