mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-21 17:10:35 +00:00
3d38708434
To prepare a user-defined type, we need to look up its name in the keyspace. While we get the keyspace name as an argument to prepare(), it is useless without the database instance. Fix the problem by passing a database reference along with the keyspace. This precolates through the class structure, so most cql3 raw types end up receiving this treatment. Origin gets along without it by using a singleton. We can't do this due to sharding (we could use a thread-local instance, but that's ugly too). Hopefully the transition to a visitor will clean this up.
44 lines
1.6 KiB
C++
44 lines
1.6 KiB
C++
/*
|
|
* Copyright 2015 Cloudius Systems
|
|
*/
|
|
|
|
#include "cql3/column_identifier.hh"
|
|
#include "exceptions/exceptions.hh"
|
|
#include "cql3/selection/simple_selector.hh"
|
|
|
|
namespace cql3 {
|
|
|
|
::shared_ptr<column_identifier>
|
|
column_identifier::raw::prepare_column_identifier(schema_ptr schema) {
|
|
if (schema->regular_column_name_type == utf8_type) {
|
|
return ::make_shared<column_identifier>(_text, true);
|
|
}
|
|
|
|
// We have a Thrift-created table with a non-text comparator. We need to parse column names with the comparator
|
|
// to get the correct ByteBuffer representation. However, this doesn't apply to key aliases, so we need to
|
|
// make a special check for those and treat them normally. See CASSANDRA-8178.
|
|
auto text_bytes = to_bytes(_text);
|
|
auto def = schema->get_column_definition(text_bytes);
|
|
if (def) {
|
|
return ::make_shared<column_identifier>(std::move(text_bytes), _text);
|
|
}
|
|
|
|
return ::make_shared<column_identifier>(schema->regular_column_name_type->from_string(_raw_text), _text);
|
|
}
|
|
|
|
std::ostream& operator<<(std::ostream& out, const column_identifier::raw& id) {
|
|
return out << id._text;
|
|
}
|
|
|
|
::shared_ptr<selection::selector::factory>
|
|
column_identifier::new_selector_factory(database& db, schema_ptr schema, std::vector<const column_definition*>& defs) {
|
|
auto def = get_column_definition(schema, *this);
|
|
if (!def) {
|
|
throw exceptions::invalid_request_exception(sprint("Undefined name %s in selection clause", _text));
|
|
}
|
|
|
|
return selection::simple_selector::new_factory(def->name_as_text(), add_and_get_index(*def, defs), def->type);
|
|
}
|
|
|
|
}
|