mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-22 09:30:45 +00:00
aa0e7c4b23
result_set_builder's API is: new_row add add add new_row add add add new_row add add add build Since there is no end_row, it relies on an internal flag to see (in new_row and in build) whether we need to end a previous row. The problem is that we check if the row is empty(), which is true both for the first row, and for an empty row (if add() is never called, e.g. "SELECT COUNT(*) FROM tab". Fix by using optional<> to mark whether the row exists (new_row has been called). This is ugly, but matches origin. We should improve that by adding an explicit end_row().
106 lines
2.7 KiB
C++
106 lines
2.7 KiB
C++
/*
|
|
* Licensed to the Apache Software Foundation (ASF) under one
|
|
* or more contributor license agreements. See the NOTICE file
|
|
* distributed with this work for additional information
|
|
* regarding copyright ownership. The ASF licenses this file
|
|
* to you under the Apache License, Version 2.0 (the
|
|
* "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
/*
|
|
* Copyright 2015 Cloudius Systems
|
|
*
|
|
* Modified by Cloudius Systems
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "cql3/selection/selection.hh"
|
|
#include "cql3/selection/selector.hh"
|
|
|
|
namespace cql3 {
|
|
|
|
namespace selection {
|
|
|
|
class simple_selector_factory : public selector::factory {
|
|
private:
|
|
const sstring _column_name;
|
|
const uint32_t _idx;
|
|
data_type _type;
|
|
public:
|
|
simple_selector_factory(const sstring& column_name, uint32_t idx, data_type type)
|
|
: _column_name(std::move(column_name))
|
|
, _idx(idx)
|
|
, _type(type)
|
|
{ }
|
|
|
|
virtual sstring column_name() override {
|
|
return _column_name;
|
|
}
|
|
|
|
virtual data_type get_return_type() override {
|
|
return _type;
|
|
}
|
|
|
|
virtual ::shared_ptr<selector> new_instance() override;
|
|
};
|
|
|
|
class simple_selector : public selector {
|
|
private:
|
|
const sstring _column_name;
|
|
const uint32_t _idx;
|
|
data_type _type;
|
|
bytes_opt _current;
|
|
public:
|
|
static ::shared_ptr<factory> new_factory(const sstring& column_name, uint32_t idx, data_type type) {
|
|
return ::make_shared<simple_selector_factory>(column_name, idx, type);
|
|
}
|
|
|
|
simple_selector(const sstring& column_name, uint32_t idx, data_type type)
|
|
: _column_name(std::move(column_name))
|
|
, _idx(idx)
|
|
, _type(type)
|
|
{ }
|
|
|
|
virtual void add_input(serialization_format sf, result_set_builder& rs) override {
|
|
// TODO: can we steal it?
|
|
_current = (*rs.current)[_idx];
|
|
}
|
|
|
|
virtual bytes_opt get_output(serialization_format sf) override {
|
|
return std::move(_current);
|
|
}
|
|
|
|
virtual void reset() override {
|
|
_current = {};
|
|
}
|
|
|
|
virtual data_type get_type() override {
|
|
return _type;
|
|
}
|
|
|
|
virtual sstring assignment_testable_source_context() const override {
|
|
return _column_name;
|
|
}
|
|
|
|
#if 0
|
|
@Override
|
|
public String toString()
|
|
{
|
|
return columnName;
|
|
}
|
|
#endif
|
|
};
|
|
|
|
}
|
|
|
|
} |