Files
scylladb/utils/extremum_tracking.hh
Paweł Dziepak de2a447576 utils/extremum_tracking: drop default constructor
Default constructed extremum_tracker has uninitialised _default_value
which basically makes it never correct to do that. Since this class is a
mechanism and not a value it doesn't really need to be a regular type,
so let's drop the default constructor.

Message-Id: <20190207162430.7460-1-pdziepak@scylladb.com>
2019-02-07 18:31:25 +02:00

104 lines
2.4 KiB
C++

/*
* Copyright (C) 2018 ScyllaDB
*/
/*
* This file is part of Scylla.
*
* Scylla is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* Scylla is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with Scylla. If not, see <http://www.gnu.org/licenses/>.
*/
#pragma once
#include <functional>
namespace detail {
template<typename T, typename Comparator>
class extremum_tracker {
T _default_value;
bool _is_set = false;
T _value;
public:
explicit extremum_tracker(T default_value) {
_default_value = default_value;
}
void update(T value) {
if (!_is_set) {
_value = value;
_is_set = true;
} else {
if (Comparator{}(value,_value)) {
_value = value;
}
}
}
void update(const extremum_tracker& other) {
if (other._is_set) {
update(other._value);
}
}
T get() const {
if (_is_set) {
return _value;
}
return _default_value;
}
};
} // namespace detail
template <typename T>
using min_tracker = detail::extremum_tracker<T, std::less<T>>;
template <typename T>
using max_tracker = detail::extremum_tracker<T, std::greater<T>>;
template <typename T>
class min_max_tracker {
min_tracker<T> _min_tracker;
max_tracker<T> _max_tracker;
public:
min_max_tracker()
: _min_tracker(std::numeric_limits<T>::min())
, _max_tracker(std::numeric_limits<T>::max())
{}
min_max_tracker(T default_min, T default_max)
: _min_tracker(default_min)
, _max_tracker(default_max)
{}
void update(T value) {
_min_tracker.update(value);
_max_tracker.update(value);
}
void update(const min_max_tracker<T>& other) {
_min_tracker.update(other._min_tracker);
_max_tracker.update(other._max_tracker);
}
T min() const {
return _min_tracker.get();
}
T max() const {
return _max_tracker.get();
}
};