mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-05-12 19:02:12 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
76cde84540e1f74f1746adaa8bd43d0a5bce461e
scylladb/tests
History
Raphael S. Carvalho 76cde84540 sstables/compaction_manager: Fix logic for filtering out partial sstable runs 
ignore_partial_runs() brings confusion because i__p__r() equal to true
doesn't mean filter out partial runs from compaction. It actually means
not caring about compaction of a partial run.

The logic was wrong because any compaction strategy that chooses not to ignore
partial sstable run[1] would have any fragment composing it incorrectly
becoming a candidate for compaction.
This problem could make compaction include only a subset of fragments composing
the partial run or even make the same fragment be compacted twice due to
parallel compaction.

[1]: partial sstable run is a sstable that is still being generated by
compaction and as a result cannot be selected as candidate whatsoever.

Fix is about making sure partial sstable run has none of its fragments
selected for compaction. And also renaming i__p__r.

Fixes #4729.

Signed-off-by: Raphael S. Carvalho <raphaelsc@scylladb.com>
Message-Id: <20190807022814.12567-1-raphaelsc@scylladb.com>
2019-08-08 14:11:35 +03:00
..
perf
config: make noncopyable
2019-06-28 16:43:25 +03:00
snitch_property_files
…
sstables
sstables: add test of sstables_mutation_reader for missing partition_end
2019-08-06 15:11:19 +03:00
aggregate_fcts_test.cc
cql: functions: add min/max/count for boolean type
2019-06-12 10:11:08 +03:00
allocation_strategy_test.cc
…
anchorless_list_test.cc
…
auth_passwords_test.cc
…
auth_resource_test.cc
tests: convert sprint() to format()
2018-11-01 13:16:17 +00:00
auth_test.cc
config: make noncopyable
2019-06-28 16:43:25 +03:00
batchlog_manager_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
big_decimal_test.cc
tests: add more operators to big decimal tests
2019-07-04 11:32:57 +02:00
broken_sstable_test.cc
tests: Add predicates for checking exception messages
2019-05-07 07:11:07 +03:00
bytes_ostream_test.cc
…
cache_flat_mutation_reader_test.cc
Merge "Simpler fix for the memtable reader's fragment monotonicity violation" from Botond
2019-01-30 15:24:31 +00:00
caching_options_test.cc
…
canonical_mutation_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
cartesian_product_test.cc
…
castas_fcts_test.cc
tests: Add predicates for checking exception messages
2019-05-07 07:11:07 +03:00
cell_locker_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
checksum_utils_test.cc
tests: Rename libdeflate_test to checksum_utils_test
2018-12-03 14:40:35 +01:00
chunked_vector_test.cc
…
clustering_ranges_walker_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
commitlog_test.cc
tests: modernise tmpdir
2019-02-07 20:18:14 +02:00
compound_test.cc
…
compress_test.cc
…
config_test.cc
Introduce updatable_value
2019-06-28 16:43:25 +03:00
continuous_data_consumer_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
counter_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
cql_assertions.cc
tests: add query_options to cquery_nofail
2019-06-24 14:06:41 +02:00
cql_assertions.hh
tests: add query_options to cquery_nofail
2019-06-24 14:06:41 +02:00
cql_auth_query_test.cc
config: don't allow assignment to config values
2019-06-28 16:43:25 +03:00
cql_auth_syntax_test.cc
test: cql_auth_syntax_test: fix ambiguity due to parser uninitialized<T>
2019-05-07 09:58:21 +03:00
cql_query_test.cc
cql: Fix use of UDT in reversed columns
2019-07-12 19:21:26 +03:00
cql_test_env.cc
config, exceptions: Add helper for handling internal errors
2019-08-02 11:13:54 +02:00
cql_test_env.hh
config: make noncopyable
2019-06-28 16:43:25 +03:00
crc_test.cc
utils/crc: calculate crc in parallel
2018-11-01 10:19:32 +02:00
data_listeners_test.cc
tests: fix pessimizing moves
2019-05-07 10:00:58 +03:00
data_model.cc
data_model: extend ttl and expiry support
2019-07-15 17:38:00 +03:00
data_model.hh
data_model: extend ttl and expiry support
2019-07-15 17:38:00 +03:00
database_test.cc
tests: add tests for snapshots.
2019-07-16 13:35:53 -04:00
duration_test.cc
tests: Add predicates for checking exception messages
2019-05-07 07:11:07 +03:00
dynamic_bitset_test.cc
…
ec2_snitch_test.cc
treewide: use std::filesystem
2019-03-28 14:21:10 +02:00
enum_set_test.cc
tests: add enum_set adding case
2019-07-29 17:15:51 +02:00
eventually.hh
test: de-template eventually() and eventually_true()
2019-01-20 15:55:20 +02:00
exception_utils.cc
tests: Add predicates for checking exception messages
2019-05-07 07:11:07 +03:00
exception_utils.hh
tests: Add predicates for checking exception messages
2019-05-07 07:11:07 +03:00
extensions_test.cc
config: make noncopyable
2019-06-28 16:43:25 +03:00
failure_injecting_allocation_strategy.hh
…
filtering_test.cc
tests: add a test case for filtering clustering key
2019-06-13 10:38:56 +03:00
flat_mutation_reader_assertions.hh
tests: flat_reader_assertions::produces_compacted(): add query_time param
2019-07-28 10:59:50 +03:00
flat_mutation_reader_test.cc
flat_mutation_reader: add make_flat_mutation_reader_from_fragments() overload with range and slice
2019-04-29 10:24:14 +03:00
flush_queue_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
fragmented_temporary_buffer_test.cc
utils/fragmented_temporary_buffer_view: add remove suffix
2019-03-04 10:23:45 +00:00
frozen_mutation_test.cc
frozen_mutation: Guard against unfreezing using wrong schema
2019-06-17 15:23:24 +03:00
gce_snitch_test.cc
treewide: use std::filesystem
2019-03-28 14:21:10 +02:00
gossip_test.cc
gossip_test: pass configuration to database object
2019-06-28 15:20:39 +03:00
gossip.cc
storage_service: Pass gossiper object to storage_service
2019-03-22 09:11:26 +08:00
gossiping_property_file_snitch_test.cc
treewide: use std::filesystem
2019-03-28 14:21:10 +02:00
hash_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
hint_test.cc
tests: modernise tmpdir
2019-02-07 20:18:14 +02:00
idl_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
imr_test.cc
tests: random-utils: use seastar::testing::local_random_engine
2019-06-13 14:45:48 +03:00
index_reader_assertions.hh
tests: convert sprint() to format()
2018-11-01 13:16:17 +00:00
input_stream_test.cc
…
json_cql_query_test.cc
tests: add test for unpacking decimals
2019-03-26 11:52:44 +01:00
json_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
keys_test.cc
…
like_matcher_test.cc
utils: Add like_matcher
2019-06-12 13:14:53 +03:00
limiting_data_source_test.cc
tests: fix pessimizing moves
2019-05-07 10:00:58 +03:00
loading_cache_test.cc
tests: modernise tmpdir
2019-02-07 20:18:14 +02:00
log_heap_test.cc
…
logalloc_test.cc
tests: logalloc_test: scale down test_region_groups
2019-07-10 12:06:10 +02:00
lsa_async_eviction_test.cc
Update seastar submodule
2018-11-21 00:01:44 +02:00
lsa_sync_eviction_test.cc
Update seastar submodule
2018-11-21 00:01:44 +02:00
make_random_string.hh
…
managed_vector_test.cc
…
map_difference_test.cc
…
memory_footprint.cc
tests: introduce sstables::test_env
2019-02-14 22:37:41 +02:00
memtable_snapshot_source.hh
…
memtable_test.cc
data_model: extend ttl and expiry support
2019-07-15 17:38:00 +03:00
message.cc
Update seastar submodule
2018-11-21 00:01:44 +02:00
meta_test.cc
…
multishard_mutation_query_test.cc
config: make noncopyable
2019-06-28 16:43:25 +03:00
murmur_hash_test.cc
tests: fix the compilation with fmt v5.3.0
2019-07-21 16:42:54 +03:00
mutation_assertions.hh
Replace std::experimental types with C++17 std version.
2019-01-08 13:16:36 +02:00
mutation_diff
tests/mutation_diff: remove false-positive diff of the partition header
2019-04-10 18:05:36 +02:00
mutation_fragment_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
mutation_query_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
mutation_reader_test.cc
tests/mutation_reader_tests: move away from variadic futures
2019-07-27 13:21:24 +03:00
mutation_source_test.cc
Revert "tests/mutation_source_tests: generate_mutation_sets() use larger ttl"
2019-08-01 13:05:46 +03:00
mutation_source_test.hh
tests/mutation_source_test: add populate_fn overload with query_time
2019-08-01 13:03:03 +03:00
mutation_test.cc
tests: add unit tests for the data stream split in compaction
2019-07-15 17:38:00 +03:00
mutation_writer_test.cc
tests: random_schema: futurize generate_random_mutations()
2019-07-15 17:38:00 +03:00
mvcc_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
network_topology_strategy_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
nonwrapping_range_test.cc
…
normalizing_reader.cc
Update seastar submodule
2018-11-21 00:01:44 +02:00
normalizing_reader.hh
Update seastar submodule
2018-11-21 00:01:44 +02:00
observable_test.cc
Introduce updatable_value
2019-06-28 16:43:25 +03:00
partition_data_test.cc
…
partitioner_test.cc
dht: Introduce ring_position_ext
2019-05-13 19:30:50 +02:00
perf_row_cache_update.cc
tests: perf_row_cache_update: Rename 'stall' to 'preemption' to avoid confusion
2019-05-13 19:18:20 +02:00
querier_cache.cc
config: make noncopyable
2019-06-28 16:43:25 +03:00
query_processor_test.cc
query_processor: Add query-count metrics
2019-04-02 19:08:25 +03:00
random_schema.cc
random_schema: generate_random_mutations(): ensure partitions are unique
2019-07-15 17:38:00 +03:00
random_schema.hh
random_schema: add ttl and expiry support
2019-07-15 17:38:00 +03:00
random-utils.hh
tests/random: add get_bool() overload with random engine param
2019-07-15 17:38:00 +03:00
range_assert.hh
…
range_test.cc
Replace std::experimental types with C++17 std version.
2019-01-08 13:16:36 +02:00
range_tombstone_list_assertions.hh
tests: convert sprint() to format()
2018-11-01 13:16:17 +00:00
range_tombstone_list_test.cc
tests: Fix use-after-free errors in static vars
2019-01-22 18:24:52 -05:00
result_set_assertions.cc
query-result-set: merge handling of null and missing values
2019-04-29 19:56:20 -07:00
result_set_assertions.hh
…
reusable_buffer_test.cc
…
role_manager_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
row_cache_alloc_stress.cc
Update seastar submodule
2018-11-21 00:01:44 +02:00
row_cache_stress_test.cc
Replace std::experimental types with C++17 std version.
2019-01-08 13:16:36 +02:00
row_cache_test.cc
tests: flat_reader_assertions::produces_compacted(): add query_time param
2019-07-28 10:59:50 +03:00
row_locker_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
schema_change_test.cc
tests: generate new test case for schema change + computed cols
2019-07-19 11:58:42 +02:00
schema_registry_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
secondary_index_test.cc
tests: add checking computed columns in SI
2019-07-19 11:58:42 +02:00
serialized_action_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
simple_schema.hh
tests/mutation_reader_test stabilize test_multishard_combining_reader_non_strictly_monotonic_positions
2019-07-15 23:24:16 +02:00
small_vector_test.cc
utils/small_vector: fix leak in copy assignment slow path
2019-01-18 17:49:46 +02:00
snitch_reset_test.cc
treewide: use std::filesystem
2019-03-28 14:21:10 +02:00
sstable_3_x_test.cc
Add unit tests for Zstd compression
2019-08-05 14:55:56 +02:00
sstable_datafile_test.cc
sstables/compaction_manager: Fix logic for filtering out partial sstable runs
2019-08-08 14:11:35 +03:00
sstable_mutation_test.cc
sstables: add test of sstables_mutation_reader for missing partition_end
2019-08-06 15:11:19 +03:00
sstable_resharding_test.cc
sstables: introduce sstables_manager
2019-03-26 16:05:08 +02:00
sstable_run_based_compaction_strategy_for_tests.hh
tests: add example compaction strategy for sstable run based approach
2018-11-24 20:16:54 -02:00
sstable_test_env.hh
tests: sstable_test_env::do_with_async: wait_for_background_jobs
2019-04-11 18:50:42 +03:00
sstable_test.cc
sstables: introduce sstables_manager
2019-03-26 16:05:08 +02:00
sstable_test.hh
treewide: use std::filesystem
2019-03-28 14:21:10 +02:00
sstable_utils.cc
build: Remove unnecessary inclusion
2019-01-22 18:25:01 -05:00
sstable_utils.hh
sstables: provide large_data_handler to constructor
2019-03-26 16:24:19 +02:00
storage_proxy_test.cc
tests: convert storage_proxy test to new query_ranges_to_vnodes_generator interface
2019-02-11 14:45:43 +02:00
streaming_histogram_test.cc
…
test_services.cc
tests: storage_service_for_tests: broadcast config to all shards
2019-07-16 10:37:17 +03:00
test_services.hh
sstables: introduce sstables_manager
2019-03-26 16:05:08 +02:00
test_table.cc
tests/test_table: add advanced create_test_table() overload
2019-02-11 17:14:47 +02:00
test_table.hh
tests/test_table: add advanced create_test_table() overload
2019-02-11 17:14:47 +02:00
test-serialization.cc
test-serialization: Add small roundtrip test for inet address (v4 + v6)
2019-07-08 15:28:21 +00:00
tmpdir.hh
treewide: use std::filesystem
2019-03-28 14:21:10 +02:00
top_k_test.cc
tests: fix pessimizing moves
2019-05-07 10:00:58 +03:00
total_order_check.hh
Replace std::experimental types with C++17 std version.
2019-01-08 13:16:36 +02:00
transport_test.cc
Switch to the the CMake-ified Seastar
2019-01-30 11:17:38 +02:00
truncation_migration_test.cc
truncation_migration_test: Add rudimentary test
2019-02-13 09:08:12 +00:00
types_test.cc
Fix timestamp_type_impl::timestamp_from_string.
2019-07-16 19:16:56 +03:00
utf8_test.cc
utils: optimize UTF-8 validation
2018-12-05 21:51:01 +02:00
UUID_test.cc
…
view_build_test.cc
sstables: provide large_data_handler to constructor
2019-03-26 16:24:19 +02:00
view_complex_test.cc
config: make noncopyable
2019-06-28 16:43:25 +03:00
view_schema_test.cc
config: make noncopyable
2019-06-28 16:43:25 +03:00
vint_serialization_test.cc
vint: drop deserialize_type structure
2019-03-14 13:37:06 +00:00
virtual_reader_test.cc
Fix infinite looping when performing a range query on system.size_estimates.
2019-07-12 18:09:15 +02:00