mirrors/scylladb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
78eccd8763aaab201b8628958d70ee98121e7dad
scylladb/test/boost
History
Nadav Har'El 0040e9e7f4 Merge 'cql: Add proper validation for null and unset inside collections send as bound values' from Jan Ciołek 
Let's say we have a query like:
```cql
INSERT INTO ks.t (list_column) VALUES (?);
```
And the driver sends a list with null inside as the bound value, something like `[1, 2, null, 4]`.

In such case we should throw `invalid_request_exception` because `nulls` are not allowed inside collections.

Currently when a query like this gets executed Scylla throws an ugly marshalling error.
This is because the validation code reads size of the next element, interprets it as an unsigned integer and tries to read this much.
In case of `null` element the size is `-1`, which when converted to unsigned `size_t` gives 18446744073709551615 and it fails to read this much.

This PR adds proper validation checks to make the error message better.

I also added some tests.
I originally tried to write them in python, but python driver really doesn't like sending invalid values.
Trying to send `[1, None, 2]` results in a list with empty value instead of null.
Trying to send `[1, UNSET_VALUE, 2]` Fails before query even leaves the driver.

Fixes #10580

Closes #10599

* github.com:scylladb/scylla:
  cql3: Add tests for null and unset inside collections
  cql3: Add null and unset checks in collection validation
2022-05-19 11:25:24 +03:00
..
aggregate_fcts_test.cc
treewide: clean up stray license blurbs
2022-02-13 14:16:16 +02:00
allocation_strategy_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
alternator_unit_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
anchorless_list_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
auth_passwords_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
auth_resource_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
auth_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
batchlog_manager_test.cc
query_processor: remove default internal query caching behavior
2022-05-01 08:33:55 +03:00
big_decimal_test.cc
treewide: clean up stray license blurbs
2022-02-13 14:16:16 +02:00
bptree_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
broken_sstable_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
btree_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
bytes_ostream_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
cache_flat_mutation_reader_test.cc
row_cache: return v2 readers from make_reader*()
2022-04-20 10:59:09 +03:00
cached_file_test.cc
tests: utils: cached_file: Validate occupancy after eviction
2022-02-25 01:42:15 +01:00
caching_options_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
canonical_mutation_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
cartesian_product_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
castas_fcts_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
cdc_generation_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
cdc_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
cell_locker_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
checksum_utils_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
chunked_managed_vector_test.cc
utils/chunked_managed_vector: Fix sigsegv during reserve()
2022-04-12 16:37:11 +03:00
chunked_vector_test.cc
utils/chunked_vector: Fix sigsegv during reserve()
2022-04-12 16:35:17 +03:00
clustering_ranges_walker_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
column_mapping_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
commitlog_test.cc
replica: database: move shard_of implementation to mutation layer
2022-04-27 14:40:24 +03:00
compound_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
compress_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
config_test.cc
db: add keyspace-storage-options experimental feature
2022-04-08 09:17:01 +02:00
continuous_data_consumer_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
counter_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
cql_auth_query_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
cql_auth_syntax_test.cc
cql3: add a cql3::util::quote() function
2022-02-07 11:33:57 +02:00
cql_functions_test.cc
result_message: add result_message::exception
2022-02-08 11:08:42 +01:00
cql_query_group_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
cql_query_large_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
cql_query_like_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
cql_query_test.cc
cql3: Add tests for null and unset inside collections
2022-05-19 00:15:17 +02:00
crc_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
data_listeners_test.cc
mutation_reader: move filtering reader into readers/
2022-03-30 15:42:51 +03:00
database_test.cc
database: add snapshot_on_all
2022-05-10 10:45:14 +03:00
double_decker_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
duration_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
dynamic_bitset_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
enum_option_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
enum_set_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
error_injection_test.cc
Merge 'utils::is_timeout_exception: Ensure we handle nested exception types' from Calle Wilund
2022-01-18 23:49:41 +02:00
estimated_histogram_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
exception_container_test.cc
exception_container: do not throw in accept
2022-02-16 10:06:10 +02:00
expr_test.cc
cql3: expr: Remove shape_type from bind_variable
2022-05-16 18:17:58 +02:00
extensions_test.cc
database: add flush_on_all variants
2022-05-10 09:56:44 +03:00
filtering_test.cc
treewide: use system-#include (angle brackets) for seastar
2022-04-26 14:46:42 +03:00
flat_mutation_reader_test.cc
readers: remove v1 forwardable reader
2022-04-28 14:12:24 +03:00
flush_queue_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
fragmented_temporary_buffer_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
frozen_mutation_test.cc
frozen_mutation: add unfreeze_gently
2022-05-05 13:32:25 +03:00
gossiping_property_file_snitch_test.cc
snitch: Keep gossiper reference
2022-05-03 10:57:40 +03:00
group0_test.cc
test: unit test for group 0 concurrent change protection and CQL DDL retries
2022-01-27 11:26:15 +01:00
hash_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
hashers_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
hint_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
idl_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
index_with_paging_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
input_stream_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
intrusive_array_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
json_cql_query_test.cc
type_json: support integers in scientific format
2022-02-22 12:55:38 +01:00
json_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
keys_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
large_paging_state_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
like_matcher_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
limiting_data_source_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
linearizing_input_stream_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
lister_test.cc
treewide: fix compilation issues with fmtlib 8.1.0+
2022-03-16 12:31:50 +03:00
loading_cache_test.cc
loading_cache_test: test prepared stmts cache
2022-04-29 19:22:55 +02:00
log_heap_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
logalloc_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
managed_bytes_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
managed_vector_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
map_difference_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
memtable_test.cc
tests: trivial flat_reader_assertions{,_v2} conversions
2022-05-10 22:10:40 +03:00
multishard_combining_reader_as_mutation_source_test.cc
test/lib/mutation_source_test: remove upgrade_to_v2 tests
2022-04-28 14:12:24 +03:00
multishard_mutation_query_test.cc
test/lib/test_utils: return OK from check() variants
2022-02-21 12:29:25 +02:00
murmur_hash_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
mutation_fragment_test.cc
Merge "Remove reader from mutations v1" from Botond
2022-03-31 13:29:11 +03:00
mutation_query_test.cc
query: coroutinize to_data_query_result
2022-05-05 13:32:25 +03:00
mutation_reader_test.cc
tests: trivial flat_reader_assertions{,_v2} conversions
2022-05-10 22:10:40 +03:00
mutation_test.cc
Merge 'Reapply: "disable_auto_compaction: stop ongoing compactions"' from Eliran Sinvani
2022-05-18 18:33:12 +03:00
mutation_writer_test.cc
readers: move combined reader into readers/
2022-03-30 15:42:51 +03:00
mvcc_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
network_topology_strategy_test.cc
snitch: Keep gossiper reference
2022-05-03 10:57:40 +03:00
nonwrapping_range_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
observable_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
partitioner_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
querier_cache_test.cc
test: move away from v1 reader from mutations
2022-03-31 10:36:23 +03:00
query_processor_test.cc
query_processor: remove default internal query caching behavior
2022-05-01 08:33:55 +03:00
radix_tree_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
range_assert.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
range_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
range_tombstone_list_assertions.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
range_tombstone_list_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
reader_concurrency_semaphore_test.cc
skeleton_reader: inherit from flat_mutation_reader_v2::impl
2022-04-06 16:55:54 +03:00
repair_test.cc
repair: Make mutation_fragment_queue internally upgrade fragments to v2
2022-04-20 17:55:58 +02:00
restrictions_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
result_utils_test.cc
utils/result_try: prevent exceptions from being caught multiple times
2022-03-15 11:42:42 +02:00
reusable_buffer_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
role_manager_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
row_cache_test.cc
tests: trivial flat_reader_assertions{,_v2} conversions
2022-05-10 22:10:40 +03:00
rust_test.cc
tests: add rust example
2022-05-11 16:49:31 +02:00
schema_change_test.cc
test: regenerate schema_change_test for storage options case
2022-04-08 09:17:01 +02:00
schema_changes_test.cc
tests: trivial flat_reader_assertions{,_v2} conversions
2022-05-10 22:10:40 +03:00
schema_loader_test.cc
tools/schema_loader: auto-create the keyspace for all statements
2022-02-17 15:24:24 +02:00
schema_registry_test.cc
user_types: Carry storage on database and schema_ctxt
2022-05-05 13:06:04 +03:00
secondary_index_test.cc
secondary index: avoid special characters in default index names
2022-03-20 18:33:48 +02:00
serialization_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
serialized_action_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
service_level_controller_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
small_vector_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
snitch_reset_test.cc
snitch: Keep gossiper reference
2022-05-03 10:57:40 +03:00
sstable_3_x_test.cc
compaction_manager: Make invoking the empty constructor more explicit
2022-05-18 14:57:10 +03:00
sstable_compaction_test.cc
compaction_manager: Make invoking the empty constructor more explicit
2022-05-18 14:57:10 +03:00
sstable_conforms_to_mutation_source_test.cc
tests: trivial flat_reader_assertions{,_v2} conversions
2022-05-10 22:10:40 +03:00
sstable_datafile_test.cc
tests: remove obsolete utility functions
2022-05-10 22:10:40 +03:00
sstable_directory_test.cc
lister: move to utils
2022-02-28 12:36:03 +02:00
sstable_move_test.cc
lister: move to utils
2022-02-28 12:36:03 +02:00
sstable_mutation_test.cc
tests: trivial flat_reader_assertions{,_v2} conversions
2022-05-10 22:10:40 +03:00
sstable_partition_index_cache_test.cc
test: sstable_partition_index_cache_test: Fix alloc-dealloc mismatch
2022-02-25 01:42:15 +01:00
sstable_resharding_test.cc
compaction_manager: Make invoking the empty constructor more explicit
2022-05-18 14:57:10 +03:00
sstable_set_test.cc
flat_mutation_reader: Split readers by file and remove unnecessary includes.
2022-03-14 13:20:25 +02:00
sstable_test.cc
compound_compat.hh: fix bug iterating on empty singular key
2022-03-08 14:14:18 +02:00
sstable_test.hh
memtable: move to replica module and namespace
2022-02-23 09:05:16 +02:00
stall_free_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
statement_restrictions_test.cc
cql3: Make parser output expression for relations
2022-05-16 18:17:58 +02:00
storage_proxy_test.cc
storage_proxy: extract query_ranges_to_vnodes_generator to a separate file
2022-02-01 21:14:41 +01:00
suite.yaml
tests: Move compaction-related tests into its own unit
2021-08-02 22:26:26 +03:00
test_table.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
top_k_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
total_order_check.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
tracing.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
transport_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
types_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
user_function_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
user_types_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
utf8_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
UUID_test.cc
test: uuid: cement the assumption that default and null uuid are equal
2022-02-16 10:19:47 +02:00
view_build_test.cc
readers: move multishard reader & friends to reader/multishard.cc
2022-03-30 15:42:51 +03:00
view_complex_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
view_schema_ckey_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
view_schema_pkey_test.cc
materialized views: allow empty strings in views and indexes
2022-03-08 15:34:26 +02:00
view_schema_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
vint_serialization_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
virtual_reader_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
virtual_table_mutation_source_test.cc
readers: Make result_collector use queue reader handle v2.
2022-03-15 17:02:28 +02:00
virtual_table_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00