mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-19 16:15:07 +00:00
c13b6c91d3
For the limited voters feature to work properly we need to make sure that we are only managing the voter status through the topology coordinator. This means that we should not change the node votership from the storage_service module for the raft topology directly. We can drop the voter status changes from the storage_service module because the topology coordinator will handle the votership changes eventually. The calls in the storage_service module were not essential and were only used for optimization (improving the HA under certain conditions). Furthermore, the other bundled commit improves the reaction again by reacting to the node `on_up()` and `on_down()` events, which again shortens the reaction time and improves the HA. The change has effect on the timing in the tablets migration test though, as it previously relied on the node being made non-voter from the service_storage `raft_removenode()` function. The fix is to add another server to the topology to make sure we will keep the quorum. Previously the test worked because the test waits for an injection to be reached and it was ensured that the injection (log line) has only been triggered after the node has been made non-voter from the `raft_removenode()`. This is not the case anymore. An alternative fix would be to wait for the first node to be made non-voter before stopping the second server, but this would make the test more complex (and it is not strictly required to only use 4 servers in the test, it has been only done for optimization purposes). Fixes: scylladb/scylladb#22860 Refs: scylladb/scylladb#18793 Refs: scylladb/scylladb#21969 No backport: Part of the limited voters new feature, so this shouldn't to be backported. Closes scylladb/scylladb#22847 * https://github.com/scylladb/scylladb: raft: use direct return of future for `run_op_with_retry` raft: adjust the voters interface to allow atomic changes raft topology: drop removing the node from raft config via storage_service raft topology: drop changing the raft voters config via storage_service