mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-04-21 00:50:35 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
7a67db594a7cdaba25ad62fd4683dff8db720ee6
scylladb/cql3/statements
History
Avi Kivity 1100a0b176 Merge 'cql3: mutation_fragments_select_statement: keep erm alive for duration of the query' from Botond Dénes 
Said statement keeps a reference to erm indirectly, via a topology node pointer, but doesn't keep erm alive. This can result in use-after-free. Furthermore, it allows for vnodes being pulled from under the query's feet, as it is running.
To prevent this, keep the erm alive for the duration of the query.
Also, use `host_id` instead of `node`, the node pointer is not needed really, as the statement only uses the host id from it.

Fixes: #15802

Closes scylladb/scylladb#15808

* github.com:scylladb/scylladb:
  cql3: mutation_fragments_select_statement: use host_id instead of node
  cql3: mutation_fragments_select_statement: pin erm reference

(cherry picked from commit 782c6a208a)
2023-10-30 10:17:19 +02:00
..
raw
cql3/statements: wire-in mutation_fragments_select_statement
2023-07-19 01:28:28 -04:00
alter_keyspace_statement.cc
guardrails: restrict replication factor (RF)
2023-09-04 19:22:17 +03:00
alter_keyspace_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
alter_role_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
alter_service_level_statement.cc
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
alter_service_level_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
alter_table_statement.cc
cql3: statements: call check_restricted_table_properties in prepare
2023-09-21 13:21:51 +02:00
alter_table_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
alter_type_statement.cc
cql3: schema_altering_statement::prepare_schema_mutations: remove an unused parameter
2023-08-01 10:07:31 +02:00
alter_type_statement.hh
cql3: schema_altering_statement::prepare_schema_mutations: remove an unused parameter
2023-08-01 10:07:31 +02:00
alter_view_statement.cc
cql3: schema_altering_statement::prepare_schema_mutations: remove an unused parameter
2023-08-01 10:07:31 +02:00
alter_view_statement.hh
cql3: schema_altering_statement::prepare_schema_mutations: remove an unused parameter
2023-08-01 10:07:31 +02:00
attach_service_level_statement.cc
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
attach_service_level_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
authentication_statement.cc
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
authentication_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
authorization_statement.cc
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
authorization_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
batch_statement.cc
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
batch_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
bound.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
cas_request.cc
statements/cas_request: fix crash on empty clustering range in LWT
2023-06-28 10:18:06 +02:00
cas_request.hh
cql3: update_parameters: use evaluation_inputs compatible row prefetch
2023-02-12 17:25:41 +02:00
cf_prop_defs.cc
cql: validate bloom_filter_fp_chance up-front
2022-09-20 06:18:51 +03:00
cf_prop_defs.hh
Introduce schema/ module
2023-02-15 11:01:50 +02:00
cf_properties.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
cf_statement.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
create_aggregate_statement.cc
cql3: schema_altering_statement::prepare_schema_mutations: remove an unused parameter
2023-08-01 10:07:31 +02:00
create_aggregate_statement.hh
cql3: schema_altering_statement::prepare_schema_mutations: remove an unused parameter
2023-08-01 10:07:31 +02:00
create_function_statement.cc
wasm: Shuffle context::context()
2023-08-04 19:47:50 +03:00
create_function_statement.hh
cql3: schema_altering_statement::prepare_schema_mutations: remove an unused parameter
2023-08-01 10:07:31 +02:00
create_index_statement.cc
cql3: schema_altering_statement::prepare_schema_mutations: remove an unused parameter
2023-08-01 10:07:31 +02:00
create_index_statement.hh
cql3: schema_altering_statement::prepare_schema_mutations: remove an unused parameter
2023-08-01 10:07:31 +02:00
create_keyspace_statement.cc
guardrails: restrict replication factor (RF)
2023-09-04 19:22:17 +03:00
create_keyspace_statement.hh
guardrails: restrict replication factor (RF)
2023-09-04 19:22:17 +03:00
create_role_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
create_service_level_statement.cc
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
create_service_level_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
create_table_statement.cc
cql3: statements: delete execute override
2023-09-21 13:24:26 +02:00
create_table_statement.hh
cql3: statements: delete execute override
2023-09-21 13:24:26 +02:00
create_type_statement.cc
cql3: schema_altering_statement::prepare_schema_mutations: remove an unused parameter
2023-08-01 10:07:31 +02:00
create_type_statement.hh
cql3: schema_altering_statement::prepare_schema_mutations: remove an unused parameter
2023-08-01 10:07:31 +02:00
create_view_statement.cc
cql3: schema_altering_statement::prepare_schema_mutations: remove an unused parameter
2023-08-01 10:07:31 +02:00
create_view_statement.hh
cql3: schema_altering_statement::prepare_schema_mutations: remove an unused parameter
2023-08-01 10:07:31 +02:00
delete_statement.cc
cql3: expr: break up expression.hh header
2023-06-22 14:21:03 +03:00
delete_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
describe_statement.cc
Merge 'cql3:statements:describe_statement: include UDT/UDF/UDA in generic describe' from Michał Jadwiszczak
2023-09-24 13:03:04 +03:00
describe_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
detach_service_level_statement.cc
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
detach_service_level_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
drop_aggregate_statement.cc
cql3: schema_altering_statement::prepare_schema_mutations: remove an unused parameter
2023-08-01 10:07:31 +02:00
drop_aggregate_statement.hh
cql3: schema_altering_statement::prepare_schema_mutations: remove an unused parameter
2023-08-01 10:07:31 +02:00
drop_function_statement.cc
cql3: schema_altering_statement::prepare_schema_mutations: remove an unused parameter
2023-08-01 10:07:31 +02:00
drop_function_statement.hh
cql3: schema_altering_statement::prepare_schema_mutations: remove an unused parameter
2023-08-01 10:07:31 +02:00
drop_index_statement.cc
cql3: schema_altering_statement::prepare_schema_mutations: remove an unused parameter
2023-08-01 10:07:31 +02:00
drop_index_statement.hh
cql3: schema_altering_statement::prepare_schema_mutations: remove an unused parameter
2023-08-01 10:07:31 +02:00
drop_keyspace_statement.cc
cql3: schema_altering_statement::prepare_schema_mutations: remove an unused parameter
2023-08-01 10:07:31 +02:00
drop_keyspace_statement.hh
cql3: schema_altering_statement::prepare_schema_mutations: remove an unused parameter
2023-08-01 10:07:31 +02:00
drop_role_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
drop_service_level_statement.cc
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
drop_service_level_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
drop_table_statement.cc
cql3: schema_altering_statement::prepare_schema_mutations: remove an unused parameter
2023-08-01 10:07:31 +02:00
drop_table_statement.hh
cql3: schema_altering_statement::prepare_schema_mutations: remove an unused parameter
2023-08-01 10:07:31 +02:00
drop_type_statement.cc
cql3: schema_altering_statement::prepare_schema_mutations: remove an unused parameter
2023-08-01 10:07:31 +02:00
drop_type_statement.hh
cql3: schema_altering_statement::prepare_schema_mutations: remove an unused parameter
2023-08-01 10:07:31 +02:00
drop_view_statement.cc
cql3: schema_altering_statement::prepare_schema_mutations: remove an unused parameter
2023-08-01 10:07:31 +02:00
drop_view_statement.hh
cql3: schema_altering_statement::prepare_schema_mutations: remove an unused parameter
2023-08-01 10:07:31 +02:00
function_statement.cc
client_state: drop unneeded argument from has.*access functions
2023-06-22 13:57:36 +03:00
function_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
grant_role_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
grant_statement.cc
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
grant_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
index_prop_defs.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
index_prop_defs.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
index_target.cc
cql3: s/std::regex/boost::regex/
2023-04-06 09:50:32 -04:00
index_target.hh
cql3: s/std::regex/boost::regex/
2023-04-06 09:50:32 -04:00
ks_prop_defs.cc
ks_prop_defs: disallow empty replication factor string in NTS
2023-05-22 17:56:16 +02:00
ks_prop_defs.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
list_permissions_statement.cc
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
list_permissions_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
list_roles_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
list_service_level_attachments_statement.cc
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
list_service_level_attachments_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
list_service_level_statement.cc
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
list_service_level_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
list_users_statement.cc
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
list_users_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
modification_statement.cc
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
modification_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
permission_altering_statement.cc
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
permission_altering_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
prepared_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
property_definitions.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
property_definitions.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
prune_materialized_view_statement.cc
treewide: drop cql_serialization_format
2023-01-03 19:54:13 +02:00
prune_materialized_view_statement.hh
cql3: add a statement for deleting ghost rows
2022-05-19 10:11:50 +02:00
request_validations.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
revoke_role_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
revoke_statement.cc
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
revoke_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
role-management-statements.cc
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
schema_altering_statement.cc
Merge "auth: do not grant permissions to creator without actually creating" from Wojciech Mitros
2023-09-18 21:47:28 +03:00
schema_altering_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
select_statement.cc
Merge 'cql3: mutation_fragments_select_statement: keep erm alive for duration of the query' from Botond Dénes
2023-10-30 10:17:19 +02:00
select_statement.hh
Merge 'cql3: mutation_fragments_select_statement: keep erm alive for duration of the query' from Botond Dénes
2023-10-30 10:17:19 +02:00
service_level_statement.cc
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
service_level_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
sl_prop_defs.cc
…
sl_prop_defs.hh
…
statement_type.hh
treewide: use defaulted operator!=() and operator==()
2023-04-27 10:24:46 +03:00
strongly_consistent_modification_statement.cc
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
strongly_consistent_modification_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
strongly_consistent_select_statement.cc
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
strongly_consistent_select_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
truncate_statement.cc
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
truncate_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
update_statement.cc
cql3: broadcast_tables: prepare new_value without relying on expression default constructor
2023-07-14 15:42:58 +03:00
update_statement.hh
raft: broadcast_tables: add compilation of cql to intermediate language
2022-09-08 15:25:36 +02:00
use_statement.cc
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
use_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00