mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-04-25 11:00:35 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
7bbfa48bc5b86240ad6dced809f11cdc8afc16d7
scylladb/cql3/statements
History
Jan Ciolek f76a1cd4bf cql3: Reorganize orderings code 
Reorganized the code that handles column ordering (ASC or DESC).
I feel that it's now clearer and easier to understand.

Added an enum that describes column ordering.
It has two possible values: ascending or descending.
It used to be a bool that was sometimes called 'reversed',
which could mean multiple things.

Instead of column.type->is_reversed() != <ordering bool>
there is now a function called are_column_select_results_reversed.

Split checking if ordering is reversed and verifying whether it's correct into two functions.
Before all of this was done by is_reversed()

This is a preparation to later allow skipping ORDER BY restrictions on some columns.
Adding this to the existing code caused it to get quite complex,
but this new version is better suited for the task.

The diff is a bit messy because I moved all ordering functions to one place,
it's better to read select_statement.cc lines 1495-1651 directly.

Signed-off-by: Jan Ciolek <jan.ciolek@scylladb.com>
2021-12-09 12:06:42 +01:00
..
raw
cql3: Reorganize orderings code
2021-12-09 12:06:42 +01:00
alter_keyspace_statement.cc
client_state: Add database argument to has_keyspace_access()
2021-08-27 14:07:18 +03:00
alter_keyspace_statement.hh
cql: allow restricting SimpleStrategy in ALTER KEYSPACE
2021-06-13 14:45:40 +03:00
alter_role_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
alter_service_level_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
alter_service_level_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
alter_table_statement.cc
cql3: replace seastar::sprint() with fmt::format()
2021-10-27 17:02:00 +03:00
alter_table_statement.hh
cql: add configurable restriction of DateTieredCompactionStrategy
2021-06-24 20:59:27 +03:00
alter_type_statement.cc
cql3: co-routinize alter_type_statement::announce_migration
2021-11-17 15:20:37 +02:00
alter_type_statement.hh
cql3: co-routinize alter_type_statement::announce_migration
2021-11-17 15:20:37 +02:00
alter_view_statement.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
alter_view_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
attach_service_level_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
attach_service_level_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
authentication_statement.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
authentication_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
authorization_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
authorization_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
batch_statement.cc
cql3: cache function calls evaluation for non-deterministic functions
2021-07-30 01:22:39 +03:00
batch_statement.hh
cql3: Remove term
2021-11-04 15:56:45 +01:00
bound.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
cas_request.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
cas_request.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
cf_prop_defs.cc
sstables: give a more descriptive name to compaction_options
2021-09-12 11:21:33 +03:00
cf_prop_defs.hh
sstables: give a more descriptive name to compaction_options
2021-09-12 11:21:33 +03:00
cf_properties.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
cf_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
create_aggregate_statement.cc
cql3: Rename prepare_term to prepare_expression
2021-11-04 15:56:45 +01:00
create_aggregate_statement.hh
cql3: create_aggregate_statement: convert term::raw to expression
2021-08-26 15:53:27 +03:00
create_function_statement.cc
treewide: add initial WebAssembly support to UDF
2021-09-13 19:03:58 +02:00
create_function_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
create_index_statement.cc
test/cql-pytest: CREATE INDEX IF NOT EXISTS vs. Cassandra
2021-08-11 13:41:58 +02:00
create_index_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
create_keyspace_statement.cc
abstract_replication_strategy: add to_qualified_class_name
2021-10-18 12:13:25 +03:00
create_keyspace_statement.hh
cql3: statements/create_keyspace: add get_keyspace_metadata()
2021-09-07 10:37:25 +03:00
create_role_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
create_service_level_statement.cc
cql3: statements: create_service_level_statement: don't ignore replace_defaults()
2021-10-10 18:16:50 +03:00
create_service_level_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
create_table_statement.cc
client_state: Add database argument to has_keyspace_access()
2021-08-27 14:07:18 +03:00
create_table_statement.hh
cql: add configurable restriction of DateTieredCompactionStrategy
2021-06-24 20:59:27 +03:00
create_type_statement.cc
cql3: deinline non-trivial methods in selection.hh
2021-10-05 12:58:55 +02:00
create_type_statement.hh
cql3: statements/create_type: expose create_type()
2021-09-07 10:37:25 +03:00
create_view_statement.cc
cql3: Make it impossible to create MV on CDC log
2021-11-19 17:33:10 +01:00
create_view_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
delete_statement.cc
cql3: Remove term
2021-11-04 15:56:45 +01:00
delete_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
detach_service_level_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
detach_service_level_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
drop_aggregate_statement.cc
cql3: add statements for user-defined aggregates
2021-08-13 11:16:52 +02:00
drop_aggregate_statement.hh
cql3: add statements for user-defined aggregates
2021-08-13 11:16:52 +02:00
drop_function_statement.cc
cql3,functions: add checking if a function is used in UDA
2021-08-13 11:16:47 +02:00
drop_function_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
drop_index_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
drop_index_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
drop_keyspace_statement.cc
client_state: Add database argument to has_keyspace_access()
2021-08-27 14:07:18 +03:00
drop_keyspace_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
drop_role_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
drop_service_level_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
drop_service_level_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
drop_table_statement.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
drop_table_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
drop_type_statement.cc
client_state: Add database argument to has_keyspace_access()
2021-08-27 14:07:18 +03:00
drop_type_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
drop_view_statement.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
drop_view_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
function_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
function_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
grant_role_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
grant_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
grant_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
index_prop_defs.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
index_prop_defs.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
index_target.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
index_target.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
ks_prop_defs.cc
cql3: keyspace prepare_options: expand replication_factor also for fully qualified NetworkTopologyStrategy
2021-10-18 12:18:07 +03:00
ks_prop_defs.hh
abstract_replication_strategy: add to_qualified_class_name
2021-10-18 12:13:25 +03:00
list_permissions_statement.cc
cql3: deinline non-trivial methods in selection.hh
2021-10-05 12:58:55 +02:00
list_permissions_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
list_roles_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
list_service_level_attachments_statement.cc
cql3: deinline non-trivial methods in selection.hh
2021-10-05 12:58:55 +02:00
list_service_level_attachments_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
list_service_level_statement.cc
cql3: deinline non-trivial methods in selection.hh
2021-10-05 12:58:55 +02:00
list_service_level_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
list_users_statement.cc
cql3: deinline non-trivial methods in selection.hh
2021-10-05 12:58:55 +02:00
list_users_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
modification_statement.cc
Merge 'cql3: Remove term, replace with expression' from Jan Ciołek
2021-11-30 16:39:39 +02:00
modification_statement.hh
cql3: rename variable_specifications to prepare_context
2021-07-24 14:33:33 +03:00
permission_altering_statement.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
permission_altering_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
prepared_statement.hh
cql3: Demand ALLOW FILTERING for unlimited, sliced partitions
2021-08-31 10:45:41 -04:00
property_definitions.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
property_definitions.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
request_validations.hh
treewide: wrap runtime formats with fmt::runtime for fmt 8
2021-11-17 15:21:36 +02:00
revoke_role_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
revoke_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
revoke_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
role-management-statements.cc
cql3: deinline non-trivial methods in selection.hh
2021-10-05 12:58:55 +02:00
schema_altering_statement.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
schema_altering_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
select_statement.cc
cql3: Reorganize orderings code
2021-12-09 12:06:42 +01:00
select_statement.hh
cql3: Remove term in select_statement
2021-10-28 20:55:09 +02:00
service_level_statement.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
service_level_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
sl_prop_defs.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
sl_prop_defs.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
statement_type.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
truncate_statement.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
truncate_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
update_statement.cc
cql3: Rename prepare_term to prepare_expression
2021-11-04 15:56:45 +01:00
update_statement.hh
cql3: Remove term
2021-11-04 15:56:45 +01:00
use_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
use_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00