mirrors/scylladb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
7f620cfa29ef2d69d961494ced8defb5c03471de
scylladb/db
History
Benny Halevy 81fa1ce9a1 Revert 'Compact staging sstables' 
This patch reverts the following patches merged in
78750c2e1a "Merge 'Compact staging sstables' from Benny Halevy"

> 597e415c38 "table: clone staging sstables into table dir"
> ce5bd505dc "view_update_generator: discover_staging_sstables: reindent"
> 59874b2837 "table: add get_staging_sstables"
> 7536dd7f00 "distributed_loader: populate table directory first"

The feature causes regressions seen with e.g.
https://jenkins.scylladb.com/view/master/job/scylla-master/job/dtest-daily-release/41/testReport/materialized_views_test/TestMaterializedViews/Run_Dtest_Parallel_Cloud_Machines___FullDtest___full_split011___test_base_replica_repair/
```
AssertionError: Expected [[0, 0, 'a', 3.0]] from SELECT * FROM t_by_v WHERE v = 0, but got []
```

Where views aren't updated properly.
Apparently since `table::stream_view_replica_updates`
doesn't exclude the staging sstables anymore and
since they are cloned to the base table as new sstables
it seems to the view builder that no view updates are
required since there's no changes comparing to the base table.

Reopens #9559

Signed-off-by: Benny Halevy <bhalevy@scylladb.com>

Closes #10890
2022-06-27 12:18:48 +03:00
..
commitlog
treewide: replace parallel_for_each with coroutine::parallel_for_each in coroutines
2022-05-31 09:06:24 +03:00
hints
hints: Remove snitch dependency
2022-06-22 11:47:26 +03:00
marshal
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
view
Revert 'Compact staging sstables'
2022-06-27 12:18:48 +03:00
batchlog_manager.cc
storage_proxy: add allow rate limit flag to mutate/mutate_result
2022-06-22 20:16:49 +02:00
batchlog_manager.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
cache_tracker.hh
memtable: Add counters for tombstone compaction
2022-06-15 11:30:25 +02:00
chained_delegating_reader.hh
flat_mutation_reader: Split readers by file and remove unnecessary includes.
2022-03-14 13:20:25 +02:00
config.cc
config: add add_per_partition_rate_limit_extension function for testing
2022-06-22 20:16:49 +02:00
config.hh
Merge 'Per-partition rate limiting' from Piotr Dulikowski
2022-06-24 01:32:13 +03:00
consistency_level_type.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
consistency_level_validations.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
consistency_level.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
consistency_level.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
cql_type_parser.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
cql_type_parser.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
data_listeners.cc
mutation_reader: move filtering reader into readers/
2022-03-30 15:42:51 +03:00
data_listeners.hh
tree: remove mutation_reader.hh include
2022-03-30 15:42:51 +03:00
extensions.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
extensions.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
heat_load_balance.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
heat_load_balance.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
large_data_handler.cc
large_data_handler: use only basename to identify the sstable
2022-02-14 17:57:49 +02:00
large_data_handler.hh
large_data_handler: use only basename to identify the sstable
2022-02-14 17:57:49 +02:00
legacy_schema_migrator.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
legacy_schema_migrator.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
operation_type.hh
transport: add rate_limit_error
2022-06-22 20:07:58 +02:00
paxos_grace_seconds_extension.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
per_partition_rate_limit_extension.hh
schema: add per_partition_rate_limit schema extension
2022-06-22 20:16:48 +02:00
per_partition_rate_limit_info.hh
db: add rate_limiter
2022-06-22 20:16:48 +02:00
per_partition_rate_limit_options.cc
schema: add per_partition_rate_limit schema extension
2022-06-22 20:16:48 +02:00
per_partition_rate_limit_options.hh
schema: add per_partition_rate_limit schema extension
2022-06-22 20:16:48 +02:00
query_context.hh
query_processor: remove default internal query caching behavior
2022-05-01 08:33:55 +03:00
rate_limiter.cc
db: add rate_limiter
2022-06-22 20:16:48 +02:00
rate_limiter.hh
db: add rate_limiter
2022-06-22 20:16:48 +02:00
read_repair_decision.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
schema_features.hh
db,gms: add SCYLLA_KEYSPACE schema feature
2022-04-08 09:17:00 +02:00
schema_tables.cc
treewide: replace parallel_for_each with coroutine::parallel_for_each in coroutines
2022-05-31 09:06:24 +03:00
schema_tables.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
size_estimates_virtual_reader.cc
everywhere: use make_flat_mutation_reader_from_mutations_v2
2022-03-15 11:41:10 +02:00
size_estimates_virtual_reader.hh
flat_mutation_reader ist tot
2022-05-31 23:42:34 +03:00
snapshot-ctl.cc
allow pre-scrub snapshots of materialized views and secondary indices
2022-06-15 11:30:58 +03:00
snapshot-ctl.hh
allow pre-scrub snapshots of materialized views and secondary indices
2022-06-15 11:30:58 +03:00
sstables-format-selector.cc
format-selector: Remove .sync() point
2022-05-16 14:14:14 +03:00
sstables-format-selector.hh
format-selector: Remove .sync() point
2022-05-16 14:14:14 +03:00
system_distributed_keyspace.cc
storage_proxy: add allow rate limit flag to mutate/mutate_result
2022-06-22 20:16:49 +02:00
system_distributed_keyspace.hh
db/system_distributed_keyspace: add all tables methods
2022-04-01 10:10:31 +03:00
system_keyspace_view_types.hh
compile: Fix headers so that *-headers targets compile cleanly.
2022-03-25 16:19:26 +02:00
system_keyspace.cc
system_keyspace: Save coroutine's captured variable on stack
2022-05-30 17:46:32 +03:00
system_keyspace.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
timeout_clock.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
virtual_table.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
virtual_table.hh
mutation_reader: move filtering reader into readers/
2022-03-30 15:42:51 +03:00
write_type.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00