810ce1c67a
In this PR, we're adjusting most of the cluster tests so that they pass with the `rf_rack_valid_keyspaces` configuration option enabled. In most cases, the changes are straightforward and require little to no additional insight into what the tests are doing or verifying. In some, however, doing that does require a deeper understanding of the tests we're modifying. The justification for those changes and their correctness is included in the commit messages corresponding to them. Note that this PR does not cover all of the cluster tests. There are few remaining ones, but they require a bit more effort, so we delegate that work to a separate PR. I tested all of the modified tests locally with `rf_rack_valid_keyspaces` set to true, and they all passed. Fixes scylladb/scylladb#23959 Backport: we want to backport these changes to 2025.1 since that's the version where we introduced RF-rack-valid keyspaces in. Although the tests are not, by default, run with `rf_rack_valid_keyspaces` enabled yet, that will most likely change in the near future and we'll also want to backport those changes too. The reason for this is that we want to verify that Scylla works correctly even with that constraint. - (cherry picked from commitdbb8835fdf) - (cherry picked from commit9281bff0e3) - (cherry picked from commit5b83304b38) - (cherry picked from commit73b22d4f6b) - (cherry picked from commit2882b7e48a) - (cherry picked from commit4c46551c6b) - (cherry picked from commit92f7d5bf10) - (cherry picked from commit5d1bb8ebc5) - (cherry picked from commitd3c0cd6d9d) - (cherry picked from commit04567c28a3) - (cherry picked from commitc8c28dae92) - (cherry picked from commitc4b32c38a3) - (cherry picked from commitee96f8dcfc) Parent PR: #23661 Closes scylladb/scylladb#24120 * github.com:scylladb/scylladb: test/{topology,topology_custom,object_store}/suite.yaml: Enable rf_rack_valid_keyspaces in suites test/topology, test/topology_custom: Disable rf_rack_valid_keyspaces in problematic tests test/topology_custom/test_tablets: Divide rack into two to adjust tests to RF-rack-validity test/topology_custom/test_tablets: Adjust test_tablet_rf_change to RF-rack-validity test/topology_custom/test_tablet_repair_scheduler.py: Adjust to RF-rack-validity test/pylib/repair.py: Assign nodes to multiple racks in create_table_insert_data_for_repair test/topology_custom/test_zero_token_nodes_topology_ops: Adjust to RF-rack-validity test/topology_custom/test_zero_token_nodes_no_replication.py: Adjust to RF-rack-validity test/topology_custom/test_zero_token_nodes_multidc.py: Adjust to RF-rack-validity test/topology_custom/test_not_enough_token_owners.py: Adjust to RF-rack-validity test/topology_custom/test_multidc.py: Adjust to RF-rack-validity test/object_store/test_backup.py: Adjust to RF-rack-validity test/topology, test/topology_custom: Adjust simple tests to RF-rack-validity
Scylla in-source tests.
For details on how to run the tests, see docs/dev/testing.md
Shared C++ utils, libraries are in lib/, for Python - pylib/
alternator - Python tests which connect to a single server and use the DynamoDB API unit, boost, raft - unit tests in C++ cqlpy - Python tests which connect to a single server and use CQL topology* - tests that set up clusters and add/remove nodes cql - approval tests that use CQL and pre-recorded output rest_api - tests for Scylla REST API Port 9000 scylla-gdb - tests for scylla-gdb.py helper script nodetool - tests for C++ implementation of nodetool
If you can use an existing folder, consider adding your test to it. New folders should be used for new large categories/subsystems, or when the test environment is significantly different from some existing suite, e.g. you plan to start scylladb with different configuration, and you intend to add many tests and would like them to reuse an existing Scylla cluster (clusters can be reused for tests within the same folder).
To add a new folder, create a new directory, and then
copy & edit its suite.ini.