mirror of
https://github.com/scylladb/scylladb.git
synced 2026-05-28 18:50:53 +00:00
aa1270a00c
assert() is traditionally disabled in release builds, but not in
scylladb. This hasn't caused problems so far, but the latest abseil
release includes a commit [1] that causes a 1000 insn/op regression when
NDEBUG is not defined.
Clearly, we must move towards a build system where NDEBUG is defined in
release builds. But we can't just define it blindly without vetting
all the assert() calls, as some were written with the expectation that
they are enabled in release mode.
To solve the conundrum, change all assert() calls to a new SCYLLA_ASSERT()
macro in utils/assert.hh. This macro is always defined and is not conditional
on NDEBUG, so we can later (after vetting Seastar) enable NDEBUG in release
mode.
[1] 66ef711d68
Closes scylladb/scylladb#20006
111 lines
3.3 KiB
C++
111 lines
3.3 KiB
C++
/*
|
|
* Copyright (C) 2021-present ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: AGPL-3.0-or-later
|
|
*/
|
|
|
|
#include <seastar/core/app-template.hh>
|
|
#include <seastar/core/thread.hh>
|
|
#include <string>
|
|
#include <fmt/core.h>
|
|
|
|
#include "utils/assert.hh"
|
|
#include "utils/compact-radix-tree.hh"
|
|
#include "radix_tree_printer.hh"
|
|
#include "collection_stress.hh"
|
|
|
|
using namespace compact_radix_tree;
|
|
using namespace seastar;
|
|
|
|
class test_data {
|
|
unsigned long *_data;
|
|
unsigned long _val;
|
|
public:
|
|
test_data(unsigned long val) : _data(new unsigned long(val)), _val(val) {}
|
|
test_data(const test_data&) = delete;
|
|
test_data(test_data&& o) noexcept : _data(std::exchange(o._data, nullptr)), _val(o._val) {}
|
|
~test_data() {
|
|
if (_data != nullptr) {
|
|
delete _data;
|
|
}
|
|
}
|
|
|
|
unsigned long value() const {
|
|
return _data == nullptr ? _val + 0x80000000 : *_data;
|
|
}
|
|
};
|
|
|
|
template <> struct fmt::formatter<test_data> : fmt::formatter<string_view> {
|
|
auto format(const test_data& d, fmt::format_context& ctx) const {
|
|
return fmt::format_to(ctx.out(), "{}", d.value());
|
|
}
|
|
};
|
|
|
|
using test_tree = tree<test_data>;
|
|
|
|
int main(int argc, char **argv) {
|
|
namespace bpo = boost::program_options;
|
|
app_template app;
|
|
app.add_options()
|
|
("count", bpo::value<int>()->default_value(132564), "number of indices to fill the tree with")
|
|
("iters", bpo::value<int>()->default_value(32), "number of iterations")
|
|
("verb", bpo::value<bool>()->default_value(false), "be verbose");
|
|
|
|
return app.run(argc, argv, [&app] {
|
|
auto count = app.configuration()["count"].as<int>();
|
|
auto iter = app.configuration()["iters"].as<int>();
|
|
auto verb = app.configuration()["verb"].as<bool>();
|
|
|
|
return seastar::async([count, iter, verb] {
|
|
tree_pointer<test_tree> t;
|
|
|
|
stress_config cfg;
|
|
cfg.count = count;
|
|
cfg.iters = 1;
|
|
cfg.keys = "rand";
|
|
cfg.verb = verb;
|
|
|
|
unsigned col_size = 0;
|
|
|
|
for (int i = 0; i < iter; i++) {
|
|
stress_compact_collection(cfg,
|
|
/* insert */ [&] (int key) {
|
|
t->emplace(key, key);
|
|
col_size++;
|
|
},
|
|
/* erase */ [&] (int key) {
|
|
t->erase(key);
|
|
col_size--;
|
|
},
|
|
/* validate */ [&] {
|
|
if (verb) {
|
|
compact_radix_tree::printer<test_data, unsigned>::show(*t);
|
|
}
|
|
|
|
unsigned nr = 0;
|
|
auto ti = t->begin();
|
|
while (ti != t->end()) {
|
|
SCYLLA_ASSERT(ti->value() == ti.key());
|
|
nr++;
|
|
ti++;
|
|
}
|
|
SCYLLA_ASSERT(nr == col_size);
|
|
},
|
|
/* clear */ [&] {
|
|
t->clear();
|
|
col_size = 0;
|
|
}
|
|
);
|
|
|
|
if (cfg.count < 4) {
|
|
cfg.count = count / 3;
|
|
} else {
|
|
cfg.count /= 2;
|
|
}
|
|
}
|
|
});
|
|
});
|
|
}
|