c42a91ec72
Currently we hold group0_guard only during DDL statement's execute() function, but unfortunately some statements access underlying schema state also during check_access() and validate() calls which are called by the query_processor before it calls execute. We need to cover those calls with group0_guard as well and also move retry loop up. This patch does it by introducing new function to cql_statement class take_guard(). Schema altering statements return group0 guard while others do not return any guard. Query processor takes this guard at the beginning of a statement execution and retries if service::group0_concurrent_modification is thrown. The guard is passed to the execute in query_state structure. Fixes: #13942 Message-Id: <ZJ2aeNIBQCtnTaE2@scylladb.com>
146 lines
4.2 KiB
C++
146 lines
4.2 KiB
C++
/*
|
|
* Copyright (C) 2014-present ScyllaDB
|
|
*
|
|
* Modified by ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: (AGPL-3.0-or-later and Apache-2.0)
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "timeout_config.hh"
|
|
|
|
namespace service {
|
|
|
|
class storage_proxy;
|
|
class query_state;
|
|
class client_state;
|
|
|
|
}
|
|
|
|
namespace cql_transport {
|
|
|
|
namespace messages {
|
|
|
|
class result_message;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
namespace cql3 {
|
|
|
|
class query_processor;
|
|
|
|
class metadata;
|
|
seastar::shared_ptr<const metadata> make_empty_metadata();
|
|
|
|
class query_options;
|
|
|
|
// A vector of CQL warnings generated during execution of a statement.
|
|
using cql_warnings_vec = std::vector<sstring>;
|
|
|
|
struct statement_guard {
|
|
size_t retry_count;
|
|
statement_guard(size_t rc) : retry_count(rc) {}
|
|
virtual ~statement_guard() {}
|
|
};
|
|
|
|
class cql_statement {
|
|
timeout_config_selector _timeout_config_selector;
|
|
public:
|
|
// CQL statement text
|
|
seastar::sstring raw_cql_statement;
|
|
|
|
explicit cql_statement(timeout_config_selector timeout_selector) : _timeout_config_selector(timeout_selector) {}
|
|
|
|
virtual ~cql_statement()
|
|
{ }
|
|
|
|
timeout_config_selector get_timeout_config_selector() const { return _timeout_config_selector; }
|
|
|
|
virtual uint32_t get_bound_terms() const = 0;
|
|
|
|
/**
|
|
* Perform any access verification necessary for the statement.
|
|
*
|
|
* @param state the current client state
|
|
*/
|
|
virtual seastar::future<> check_access(query_processor& qp, const service::client_state& state) const = 0;
|
|
|
|
/**
|
|
* Perform additional validation required by the statment.
|
|
* To be overriden by subclasses if needed.
|
|
*
|
|
* @param state the current client state
|
|
*/
|
|
virtual void validate(query_processor& qp, const service::client_state& state) const {}
|
|
|
|
/**
|
|
* Execute the statement and return the resulting result or null if there is no result.
|
|
*
|
|
* In case of a failure, it must return an exceptional future. It must not use
|
|
* the result_message::exception to indicate failure.
|
|
*
|
|
* @param state the current query state
|
|
* @param options options for this query (consistency, variables, pageSize, ...)
|
|
*/
|
|
virtual seastar::future<seastar::shared_ptr<cql_transport::messages::result_message>>
|
|
execute(query_processor& qp, service::query_state& state, const query_options& options) const = 0;
|
|
|
|
/**
|
|
* Execute the statement and return the resulting result or null if there is no result.
|
|
*
|
|
* Unlike execute(), it is allowed to return a result_message::exception which contains
|
|
* an exception that needs to be explicitly handled.
|
|
*
|
|
* @param state the current query state
|
|
* @param options options for this query (consistency, variables, pageSize, ...)
|
|
*/
|
|
virtual seastar::future<seastar::shared_ptr<cql_transport::messages::result_message>>
|
|
execute_without_checking_exception_message(query_processor& qp, service::query_state& state, const query_options& options) const {
|
|
return execute(qp, state, options);
|
|
}
|
|
|
|
virtual future<std::unique_ptr<statement_guard>> take_guard(query_processor& qp) const {
|
|
return make_ready_future<std::unique_ptr<statement_guard>>(nullptr);
|
|
}
|
|
|
|
virtual bool depends_on(std::string_view ks_name, std::optional<std::string_view> cf_name) const = 0;
|
|
|
|
virtual seastar::shared_ptr<const metadata> get_result_metadata() const = 0;
|
|
|
|
virtual bool is_conditional() const {
|
|
return false;
|
|
}
|
|
};
|
|
|
|
class cql_statement_no_metadata : public cql_statement {
|
|
public:
|
|
using cql_statement::cql_statement;
|
|
virtual seastar::shared_ptr<const metadata> get_result_metadata() const override {
|
|
return make_empty_metadata();
|
|
}
|
|
};
|
|
|
|
// Conditional modification statements and batches
|
|
// return a result set and have metadata, while same
|
|
// statements without conditions do not.
|
|
class cql_statement_opt_metadata : public cql_statement {
|
|
protected:
|
|
// Result set metadata, may be empty for simple updates and batches
|
|
seastar::shared_ptr<metadata> _metadata;
|
|
public:
|
|
using cql_statement::cql_statement;
|
|
virtual seastar::shared_ptr<const metadata> get_result_metadata() const override {
|
|
if (_metadata) {
|
|
return _metadata;
|
|
}
|
|
return make_empty_metadata();
|
|
}
|
|
};
|
|
|
|
}
|