mirrors/scylladb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
88e62ec5736df655cee298564de2e5da1d3ce0fe
scylladb/cql3/statements
History
Gleb Natapov c42a91ec72 cql3: Extend the scope of group0_guard during DDL statement execution 
Currently we hold group0_guard only during DDL statement's execute()
function, but unfortunately some statements access underlying schema
state also during check_access() and validate() calls which are called
by the query_processor before it calls execute. We need to cover those
calls with group0_guard as well and also move retry loop up. This patch
does it by introducing new function to cql_statement class take_guard().
Schema altering statements return group0 guard while others do not
return any guard. Query processor takes this guard at the beginning of a
statement execution and retries if service::group0_concurrent_modification
is thrown. The guard is passed to the execute in query_state structure.

Fixes: #13942
Message-Id: <ZJ2aeNIBQCtnTaE2@scylladb.com>
2023-07-05 14:38:34 +02:00
..
raw
cql3: select_statement: use prepared selectors
2023-07-03 19:45:17 +03:00
alter_keyspace_statement.cc
client_state: drop unneeded argument from has.*access functions
2023-06-22 13:57:36 +03:00
alter_keyspace_statement.hh
cql3: statements: pass migration_manager& explicitly to prepare_schema_mutations
2023-06-15 09:48:54 +02:00
alter_role_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
alter_service_level_statement.cc
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
alter_service_level_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
alter_table_statement.cc
cql3: move validation::validate_column_family from client_state::has_column_family_access
2023-06-22 13:57:36 +03:00
alter_table_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
alter_type_statement.cc
client_state: drop unneeded argument from has.*access functions
2023-06-22 13:57:36 +03:00
alter_type_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
alter_view_statement.cc
cql3: move validation::validate_column_family from client_state::has_column_family_access
2023-06-22 13:57:36 +03:00
alter_view_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
attach_service_level_statement.cc
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
attach_service_level_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
authentication_statement.cc
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
authentication_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
authorization_statement.cc
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
authorization_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
batch_statement.cc
treewide: use fmt::join() when appropriate
2023-03-16 20:34:18 +08:00
batch_statement.hh
…
bound.hh
…
cas_request.cc
statements/cas_request: fix crash on empty clustering range in LWT
2023-06-28 10:18:06 +02:00
cas_request.hh
cql3: update_parameters: use evaluation_inputs compatible row prefetch
2023-02-12 17:25:41 +02:00
cf_prop_defs.cc
…
cf_prop_defs.hh
Introduce schema/ module
2023-02-15 11:01:50 +02:00
cf_properties.hh
…
cf_statement.cc
…
create_aggregate_statement.cc
cql3: Specify arguments types in UDA creation errors
2023-06-28 15:27:49 +03:00
create_aggregate_statement.hh
cql3: statements: pass migration_manager& explicitly to prepare_schema_mutations
2023-06-15 09:48:54 +02:00
create_function_statement.cc
cql3: statements: pass migration_manager& explicitly to prepare_schema_mutations
2023-06-15 09:48:54 +02:00
create_function_statement.hh
cql3: statements: pass migration_manager& explicitly to prepare_schema_mutations
2023-06-15 09:48:54 +02:00
create_index_statement.cc
cql3: move validation::validate_column_family from client_state::has_column_family_access
2023-06-22 13:57:36 +03:00
create_index_statement.hh
cql3: statements: pass migration_manager& explicitly to prepare_schema_mutations
2023-06-15 09:48:54 +02:00
create_keyspace_statement.cc
cql3: statements: pass migration_manager& explicitly to prepare_schema_mutations
2023-06-15 09:48:54 +02:00
create_keyspace_statement.hh
cql3: statements: pass migration_manager& explicitly to prepare_schema_mutations
2023-06-15 09:48:54 +02:00
create_role_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
create_service_level_statement.cc
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
create_service_level_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
create_table_statement.cc
client_state: drop unneeded argument from has.*access functions
2023-06-22 13:57:36 +03:00
create_table_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
create_type_statement.cc
client_state: drop unneeded argument from has.*access functions
2023-06-22 13:57:36 +03:00
create_type_statement.hh
cql3: statements: pass migration_manager& explicitly to prepare_schema_mutations
2023-06-15 09:48:54 +02:00
create_view_statement.cc
cql3: selection: drop selector_factories, selectables, and selectors
2023-07-03 19:45:17 +03:00
create_view_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
delete_statement.cc
cql3: expr: break up expression.hh header
2023-06-22 14:21:03 +03:00
delete_statement.hh
…
describe_statement.cc
Merge 'query processor code cleanup' from Gleb
2023-06-23 10:32:57 +02:00
describe_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
detach_service_level_statement.cc
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
detach_service_level_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
drop_aggregate_statement.cc
cql3: statements: pass migration_manager& explicitly to prepare_schema_mutations
2023-06-15 09:48:54 +02:00
drop_aggregate_statement.hh
cql3: statements: pass migration_manager& explicitly to prepare_schema_mutations
2023-06-15 09:48:54 +02:00
drop_function_statement.cc
cql3: statements: pass migration_manager& explicitly to prepare_schema_mutations
2023-06-15 09:48:54 +02:00
drop_function_statement.hh
cql3: statements: pass migration_manager& explicitly to prepare_schema_mutations
2023-06-15 09:48:54 +02:00
drop_index_statement.cc
cql3: move validation::validate_column_family from client_state::has_column_family_access
2023-06-22 13:57:36 +03:00
drop_index_statement.hh
cql3: statements: pass migration_manager& explicitly to prepare_schema_mutations
2023-06-15 09:48:54 +02:00
drop_keyspace_statement.cc
client_state: drop unneeded argument from has.*access functions
2023-06-22 13:57:36 +03:00
drop_keyspace_statement.hh
cql3: statements: pass migration_manager& explicitly to prepare_schema_mutations
2023-06-15 09:48:54 +02:00
drop_role_statement.hh
…
drop_service_level_statement.cc
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
drop_service_level_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
drop_table_statement.cc
cql3: move validation::validate_column_family from client_state::has_column_family_access
2023-06-22 13:57:36 +03:00
drop_table_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
drop_type_statement.cc
client_state: drop unneeded argument from has.*access functions
2023-06-22 13:57:36 +03:00
drop_type_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
drop_view_statement.cc
cql3: move validation::validate_column_family from client_state::has_column_family_access
2023-06-22 13:57:36 +03:00
drop_view_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
function_statement.cc
client_state: drop unneeded argument from has.*access functions
2023-06-22 13:57:36 +03:00
function_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
grant_role_statement.hh
…
grant_statement.cc
…
grant_statement.hh
…
index_prop_defs.cc
…
index_prop_defs.hh
…
index_target.cc
cql3: s/std::regex/boost::regex/
2023-04-06 09:50:32 -04:00
index_target.hh
cql3: s/std::regex/boost::regex/
2023-04-06 09:50:32 -04:00
ks_prop_defs.cc
ks_prop_defs: disallow empty replication factor string in NTS
2023-05-22 17:56:16 +02:00
ks_prop_defs.hh
…
list_permissions_statement.cc
Merge 'Allow setting permissions for user-defined functions' from Wojciech Mitros
2023-03-12 14:04:34 +02:00
list_permissions_statement.hh
…
list_roles_statement.hh
…
list_service_level_attachments_statement.cc
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
list_service_level_attachments_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
list_service_level_statement.cc
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
list_service_level_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
list_users_statement.cc
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
list_users_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
modification_statement.cc
modification_statement: reject conditional statements with empty clustering key
2023-06-28 10:30:52 +02:00
modification_statement.hh
cql: USING TTL 0 means unlimited, not default TTL
2023-03-08 16:18:23 +02:00
permission_altering_statement.cc
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
permission_altering_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
prepared_statement.hh
…
property_definitions.cc
…
property_definitions.hh
…
prune_materialized_view_statement.cc
…
prune_materialized_view_statement.hh
…
request_validations.hh
…
revoke_role_statement.hh
…
revoke_statement.cc
…
revoke_statement.hh
…
role-management-statements.cc
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
schema_altering_statement.cc
cql3: Extend the scope of group0_guard during DDL statement execution
2023-07-05 14:38:34 +02:00
schema_altering_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-07-05 14:38:34 +02:00
select_statement.cc
cql3: select_statement: don't copy metadata object needlessly
2023-07-04 16:41:51 +03:00
select_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
service_level_statement.cc
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
service_level_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
sl_prop_defs.cc
…
sl_prop_defs.hh
…
statement_type.hh
treewide: use defaulted operator!=() and operator==()
2023-04-27 10:24:46 +03:00
strongly_consistent_modification_statement.cc
Merge 'query processor code cleanup' from Gleb
2023-06-23 10:32:57 +02:00
strongly_consistent_modification_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
strongly_consistent_select_statement.cc
Merge 'query processor code cleanup' from Gleb
2023-06-23 10:32:57 +02:00
strongly_consistent_select_statement.hh
…
truncate_statement.cc
cql3: move validation::validate_column_family from client_state::has_column_family_access
2023-06-22 13:57:36 +03:00
truncate_statement.hh
cql3/statements/truncate_statement: remove defaulted move ctor
2023-02-19 12:57:40 +08:00
update_statement.cc
cql3: expr: break up expression.hh header
2023-06-22 14:21:03 +03:00
update_statement.hh
…
use_statement.cc
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
use_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00