d2ef55b12c
As described in https://github.com/scylladb/scylladb/issues/8638, we're moving away from `SimpleStrategy`, in the future it will become deprecated. We should remove all uses of it and replace them with `NetworkTopologyStrategy`. This change replaces `SimpleStrategy` with `NetworkTopologyStrategy` in all unit tests, or at least in the ones where it was reasonable to do so. Some of the tests were written explicitly to test the `SimpleStrategy` strategy, or changing the keyspace from `SimpleStrategy` to `NetworkTopologyStrategy`. These tests were left intact. It's still a feature that is supported, even if it's slowly getting deprecated. The typical way to use `NetworkTopologyStrategy` is to specify a replication factor for each datacenter. This could be a bit cumbersome, we would have to fetch the list of datacenters, set the repfactors, etc. Luckily there is another way - we can just specify a replication factor to use for or each existing datacenter, like this: ```cql CREATE KEYSPACE {} WITH REPLICATION = {'class' : 'NetworkTopologyStrategy', 'replication_factor' : 1}; ``` This makes the change rather straightforward - just replace all instances of `'SimpleStrategy'', with `'NetworkTopologyStrategy'`. Refs: https://github.com/scylladb/scylladb/issues/8638 Signed-off-by: Jan Ciolek <jan.ciolek@scylladb.com> Closes #13990
108 lines
6.5 KiB
C++
108 lines
6.5 KiB
C++
/*
|
|
* Copyright (C) 2021-present ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: AGPL-3.0-or-later
|
|
*/
|
|
|
|
#include "test/lib/scylla_test_case.hh"
|
|
|
|
#include "tools/schema_loader.hh"
|
|
|
|
SEASTAR_THREAD_TEST_CASE(test_empty) {
|
|
BOOST_REQUIRE_THROW(tools::load_schemas("").get(), std::exception);
|
|
BOOST_REQUIRE_THROW(tools::load_schemas(";").get(), std::exception);
|
|
}
|
|
|
|
SEASTAR_THREAD_TEST_CASE(test_keyspace_only) {
|
|
BOOST_REQUIRE_EQUAL(tools::load_schemas("CREATE KEYSPACE ks WITH replication = {'class': 'NetworkTopologyStrategy', 'replication_factor': 1};").get().size(), 0);
|
|
}
|
|
|
|
SEASTAR_THREAD_TEST_CASE(test_single_table) {
|
|
BOOST_REQUIRE_EQUAL(tools::load_schemas("CREATE TABLE ks.cf (pk int PRIMARY KEY, v int)").get().size(), 1);
|
|
BOOST_REQUIRE_EQUAL(tools::load_schemas("CREATE TABLE ks.cf (pk int PRIMARY KEY, v map<int, int>)").get().size(), 1);
|
|
BOOST_REQUIRE_EQUAL(tools::load_schemas("CREATE KEYSPACE ks WITH replication = {'class': 'NetworkTopologyStrategy', 'replication_factor': 1}; CREATE TABLE ks.cf (pk int PRIMARY KEY, v int);").get().size(), 1);
|
|
}
|
|
|
|
SEASTAR_THREAD_TEST_CASE(test_keyspace_replication_strategy) {
|
|
BOOST_REQUIRE_EQUAL(tools::load_schemas("CREATE KEYSPACE ks WITH replication = {'class': 'NetworkTopologyStrategy', 'replication_factor': 1}; CREATE TABLE ks.cf (pk int PRIMARY KEY, v int);").get().size(), 1);
|
|
BOOST_REQUIRE_EQUAL(tools::load_schemas("CREATE KEYSPACE ks WITH replication = {'class': 'NetworkTopologyStrategy', 'replication_factor': 3}; CREATE TABLE ks.cf (pk int PRIMARY KEY, v int);").get().size(), 1);
|
|
BOOST_REQUIRE_EQUAL(tools::load_schemas("CREATE KEYSPACE ks WITH replication = {'class': 'NetworkTopologyStrategy', 'mydc1': 1, 'mydc2': 4}; CREATE TABLE ks.cf (pk int PRIMARY KEY, v int);").get().size(), 1);
|
|
}
|
|
|
|
SEASTAR_THREAD_TEST_CASE(test_multiple_tables) {
|
|
BOOST_REQUIRE_EQUAL(tools::load_schemas("CREATE TABLE ks.cf1 (pk int PRIMARY KEY, v int); CREATE TABLE ks.cf2 (pk int PRIMARY KEY, v int)").get().size(), 2);
|
|
BOOST_REQUIRE_EQUAL(tools::load_schemas("CREATE TABLE ks.cf1 (pk int PRIMARY KEY, v int); CREATE TABLE ks.cf2 (pk int PRIMARY KEY, v int);").get().size(), 2);
|
|
BOOST_REQUIRE_EQUAL(tools::load_schemas(
|
|
"CREATE KEYSPACE ks WITH replication = {'class': 'NetworkTopologyStrategy', 'replication_factor': 1}; "
|
|
"CREATE TABLE ks.cf1 (pk int PRIMARY KEY, v int); "
|
|
"CREATE TABLE ks.cf2 (pk int PRIMARY KEY, v int); "
|
|
"CREATE TABLE ks.cf3 (pk int PRIMARY KEY, v int); "
|
|
).get().size(), 3);
|
|
BOOST_REQUIRE_EQUAL(tools::load_schemas(
|
|
"CREATE KEYSPACE ks1 WITH replication = {'class': 'NetworkTopologyStrategy', 'replication_factor': 1}; "
|
|
"CREATE TABLE ks1.cf (pk int PRIMARY KEY, v int); "
|
|
"CREATE KEYSPACE ks2 WITH replication = {'class': 'NetworkTopologyStrategy', 'replication_factor': 1}; "
|
|
"CREATE TABLE ks2.cf (pk int PRIMARY KEY, v int); "
|
|
).get().size(), 2);
|
|
}
|
|
|
|
SEASTAR_THREAD_TEST_CASE(test_udts) {
|
|
BOOST_REQUIRE_EQUAL(tools::load_schemas(
|
|
"CREATE KEYSPACE ks WITH replication = {'class': 'NetworkTopologyStrategy', 'replication_factor': 1}; "
|
|
"CREATE TYPE ks.type1 (f1 int, f2 text); "
|
|
"CREATE TABLE ks.cf (pk int PRIMARY KEY, v frozen<type1>); "
|
|
).get().size(), 1);
|
|
BOOST_REQUIRE_EQUAL(tools::load_schemas(
|
|
"CREATE KEYSPACE ks WITH replication = {'class': 'NetworkTopologyStrategy', 'replication_factor': 1}; "
|
|
"CREATE TYPE ks.type1 (f1 int, f2 text); "
|
|
"CREATE TABLE ks.cf (pk int PRIMARY KEY, v type1); "
|
|
).get().size(), 1);
|
|
BOOST_REQUIRE_EQUAL(tools::load_schemas(
|
|
"CREATE KEYSPACE ks1 WITH replication = {'class': 'NetworkTopologyStrategy', 'replication_factor': 1}; "
|
|
"CREATE TYPE ks1.type1 (f1 int, f2 text); "
|
|
"CREATE TABLE ks1.cf (pk int PRIMARY KEY, v frozen<type1>); "
|
|
"CREATE KEYSPACE ks2 WITH replication = {'class': 'NetworkTopologyStrategy', 'replication_factor': 1}; "
|
|
"CREATE TYPE ks2.type1 (f1 int, f2 text); "
|
|
"CREATE TABLE ks2.cf (pk int PRIMARY KEY, v frozen<type1>); "
|
|
).get().size(), 2);
|
|
BOOST_REQUIRE_EQUAL(tools::load_schemas(
|
|
"CREATE TYPE ks.type1 (f1 int, f2 text); "
|
|
"CREATE TABLE ks.cf (pk int PRIMARY KEY, v frozen<type1>); "
|
|
).get().size(), 1);
|
|
BOOST_REQUIRE_EQUAL(tools::load_schemas(
|
|
"CREATE TYPE ks1.type1 (f1 int, f2 text); "
|
|
"CREATE TABLE ks1.cf (pk int PRIMARY KEY, v frozen<type1>); "
|
|
"CREATE TYPE ks2.type1 (f1 int, f2 text); "
|
|
"CREATE TABLE ks2.cf (pk int PRIMARY KEY, v frozen<type1>); "
|
|
).get().size(), 2);
|
|
}
|
|
|
|
SEASTAR_THREAD_TEST_CASE(test_dropped_columns) {
|
|
BOOST_REQUIRE_EQUAL(tools::load_schemas(
|
|
"CREATE TABLE ks.cf (pk int PRIMARY KEY, v1 int); "
|
|
"INSERT INTO system_schema.dropped_columns (keyspace_name, table_name, column_name, dropped_time, type) VALUES ('ks', 'cf', 'v2', 1631011979170675, 'int'); "
|
|
).get().size(), 1);
|
|
BOOST_REQUIRE_THROW(tools::load_schemas(
|
|
"CREATE TABLE ks.cf (pk int PRIMARY KEY, v1 int); "
|
|
"INSERT INTO ks.cf (pk, v1) VALUES (0, 0); "
|
|
).get(), std::exception);
|
|
BOOST_REQUIRE_THROW(tools::load_schemas(
|
|
"INSERT INTO system_schema.dropped_columns (keyspace_name, table_name, column_name, dropped_time, type) VALUES ('ks', 'cf', 'v2', 1631011979170675, 'int'); "
|
|
"CREATE TABLE ks.cf (pk int PRIMARY KEY, v1 int); "
|
|
).get(), std::exception);
|
|
BOOST_REQUIRE_THROW(tools::load_schemas(
|
|
"CREATE TABLE ks.cf (pk int PRIMARY KEY, v1 int); "
|
|
"INSERT INTO system_schema.dropped_columns (keyspace_name, table_name, column_name, dropped_time, type) VALUES ('unknown_ks', 'unknown_cf', 'v2', 1631011979170675, 'int'); "
|
|
).get(), std::exception);
|
|
BOOST_REQUIRE_THROW(tools::load_schemas(
|
|
"CREATE TABLE ks.cf (pk int PRIMARY KEY, v1 int); "
|
|
"INSERT INTO system_schema.dropped_columns (keyspace_name, table_name, column_name, dropped_time, type) VALUES ('unknown_ks', 'cf', 'v2', 1631011979170675, 'int'); "
|
|
).get(), std::exception);
|
|
BOOST_REQUIRE_THROW(tools::load_schemas(
|
|
"CREATE TABLE ks.cf (pk int PRIMARY KEY, v1 int); "
|
|
"INSERT INTO system_schema.dropped_columns (keyspace_name, table_name, column_name, dropped_time, type) VALUES ('ks', 'unknown_cf', 'v2', 1631011979170675, 'int'); "
|
|
).get(), std::exception);
|
|
}
|