82cac8e7cf
CWG 2631 (https://cplusplus.github.io/CWG/issues/2631.html) reports
an issue on how the default argument is evaluated. this problem is
more obvious when it comes to how `std::source_location::current()`
is evaluated as a default argument. but not all compilers have the
same behavior, see https://godbolt.org/z/PK865KdG4.
notebaly, clang-15 evaluates the default argument at the callee
site. so we need to check the capability of compiler and fall back
to the one defined by util/source_location-compat.hh if the compiler
suffers from CWG 2631. and clang-16 implemented CWG2631 in
https://reviews.llvm.org/D136554. But unfortunately, this change
was not backported to clang-15.
before switching over to clang-16, for using std::source_location::current()
as the default parameter and expect the behavior defined by CWG2631,
we have to use the compatible layer provided by Seastar. otherwise
we always end up having the source_location at the callee side, which
is not interesting under most circumstances.
so in this change, all places using the idiom of passing
std::source_location::current() as the default parameter are changed
to use seastar::compat::source_location::current(). despite that
we have `#include "seastarx.h"` for opening the seastar namespace,
to disambiguate the "namespace compat" defined somewhere in scylladb,
the fully qualified name of
`seastar::compat::source_location::current()` is used.
see also 09a3c63345, where we used
std::source_location as an alias of std::experimental::source_location
if it was available. but this does not apply to the settings of our
current toolchain, where we have GCC-12 and Clang-15.
Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>
Closes #14086
97 lines
3.4 KiB
C++
97 lines
3.4 KiB
C++
|
|
/*
|
|
* Copyright (C) 2015-present ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: AGPL-3.0-or-later
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "test/lib/cql_test_env.hh"
|
|
#include "transport/messages/result_message_base.hh"
|
|
#include "bytes.hh"
|
|
#include <source_location>
|
|
#include <seastar/core/shared_ptr.hh>
|
|
#include <seastar/core/future.hh>
|
|
|
|
class rows_assertions {
|
|
shared_ptr<cql_transport::messages::result_message::rows> _rows;
|
|
public:
|
|
rows_assertions(shared_ptr<cql_transport::messages::result_message::rows> rows);
|
|
rows_assertions with_size(size_t size);
|
|
rows_assertions is_empty();
|
|
rows_assertions is_not_empty();
|
|
rows_assertions with_column_types(std::initializer_list<data_type> column_types);
|
|
rows_assertions with_row(std::initializer_list<bytes_opt> values);
|
|
|
|
// Verifies that the result has the following rows and only that rows, in that order.
|
|
rows_assertions with_rows(std::vector<std::vector<bytes_opt>> rows);
|
|
// Verifies that the result has the following rows and only those rows.
|
|
rows_assertions with_rows_ignore_order(std::vector<std::vector<bytes_opt>> rows);
|
|
rows_assertions with_serialized_columns_count(size_t columns_count);
|
|
|
|
rows_assertions is_null();
|
|
rows_assertions is_not_null();
|
|
};
|
|
|
|
class result_msg_assertions {
|
|
shared_ptr<cql_transport::messages::result_message> _msg;
|
|
public:
|
|
result_msg_assertions(shared_ptr<cql_transport::messages::result_message> msg);
|
|
rows_assertions is_rows();
|
|
};
|
|
|
|
result_msg_assertions assert_that(shared_ptr<cql_transport::messages::result_message> msg);
|
|
|
|
template<typename... T>
|
|
void assert_that_failed(future<T...>& f)
|
|
{
|
|
try {
|
|
f.get();
|
|
assert(f.failed());
|
|
}
|
|
catch (...) {
|
|
}
|
|
}
|
|
|
|
template<typename... T>
|
|
void assert_that_failed(future<T...>&& f)
|
|
{
|
|
try {
|
|
f.get();
|
|
assert(f.failed());
|
|
}
|
|
catch (...) {
|
|
}
|
|
}
|
|
|
|
/// Invokes env.execute_cql(query), awaits its result, and returns it. If an exception is thrown,
|
|
/// invokes BOOST_FAIL with useful diagnostics.
|
|
///
|
|
/// \note Should be called from a seastar::thread context, as it awaits the CQL result.
|
|
shared_ptr<cql_transport::messages::result_message> cquery_nofail(
|
|
cql_test_env& env,
|
|
sstring_view query,
|
|
std::unique_ptr<cql3::query_options>&& qo = nullptr,
|
|
const seastar::compat::source_location& loc = seastar::compat::source_location::current());
|
|
|
|
/// Asserts that cquery_nofail(e, qstr) contains expected rows, in any order.
|
|
void require_rows(cql_test_env& e,
|
|
sstring_view qstr,
|
|
const std::vector<std::vector<bytes_opt>>& expected,
|
|
const seastar::compat::source_location& loc = seastar::compat::source_location::current());
|
|
|
|
/// Like require_rows, but wraps assertions in \c eventually.
|
|
void eventually_require_rows(
|
|
cql_test_env& e, sstring_view qstr, const std::vector<std::vector<bytes_opt>>& expected,
|
|
const seastar::compat::source_location& loc = seastar::compat::source_location::current());
|
|
|
|
/// Asserts that e.execute_prepared(id, values) contains expected rows, in any order.
|
|
void require_rows(cql_test_env& e,
|
|
cql3::prepared_cache_key_type id,
|
|
const std::vector<cql3::raw_value>& values,
|
|
const std::vector<std::vector<bytes_opt>>& expected,
|
|
const seastar::compat::source_location& loc = seastar::compat::source_location::current());
|