mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-06-03 05:26:58 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
8b76f2a835b27ecbbfd0fc86baf05db477b931ba
scylladb/cql3
History
Avi Kivity 782c6a208a Merge 'cql3: mutation_fragments_select_statement: keep erm alive for duration of the query' from Botond Dénes 
Said statement keeps a reference to erm indirectly, via a topology node pointer, but doesn't keep erm alive. This can result in use-after-free. Furthermore, it allows for vnodes being pulled from under the query's feet, as it is running.
To prevent this, keep the erm alive for the duration of the query.
Also, use `host_id` instead of `node`, the node pointer is not needed really, as the statement only uses the host id from it.

Fixes: #15802

Closes scylladb/scylladb#15808

* github.com:scylladb/scylladb:
  cql3: mutation_fragments_select_statement: use host_id instead of node
  cql3: mutation_fragments_select_statement: pin erm reference
2023-10-25 15:03:07 +03:00
..
expr
cql3/expr: add more comments in expression.hh
2023-10-19 10:56:38 +03:00
functions
cql3: fix bad optional access when executing fromJson function
2023-09-21 20:18:49 +03:00
restrictions
Merge 'cql3: expr: remove the default constructor' from Avi Kivity
2023-07-19 21:46:03 +03:00
selection
cql3: selection: drop selector_factories, selectables, and selectors
2023-07-03 19:45:17 +03:00
statements
cql3: mutation_fragments_select_statement: use host_id instead of node
2023-10-24 03:12:58 -04:00
assignment_testable.hh
cql3: SELECT CAST column names should match Cassandra's
2023-09-26 17:26:14 +03:00
attributes.cc
cql3: expr: break up expression.hh header
2023-06-22 14:21:03 +03:00
attributes.hh
cql: USING TTL 0 means unlimited, not default TTL
2023-03-08 16:18:23 +02:00
authorized_prepared_statements_cache.hh
treewide: use defaulted operator!=() and operator==()
2023-04-27 10:24:46 +03:00
cf_name.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
cf_name.hh
cql3: mark cf_name final
2023-02-28 22:26:43 +02:00
CMakeLists.txt
build: cmake: avoid using large amount stack of when compiling parser
2023-10-24 12:40:20 +08:00
column_identifier.cc
cql3: selection: convert processes_selection to work on prepared expressions
2023-07-03 19:45:17 +03:00
column_identifier.hh
cql3: selection: convert processes_selection to work on prepared expressions
2023-07-03 19:45:17 +03:00
column_specification.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
column_specification.hh
types: move types.{cc,hh} into types
2023-02-19 21:05:45 +02:00
constants.cc
cql3: broadcast_tables: prepare new_value without relying on expression default constructor
2023-07-14 15:42:58 +03:00
constants.hh
cql3: broadcast_tables: prepare new_value without relying on expression default constructor
2023-07-14 15:42:58 +03:00
cql3_type.cc
Merge 'cql: enable setting permissions on resources with quoted UDT names' from Wojciech Mitros
2023-05-10 19:10:29 +03:00
cql3_type.hh
Merge 'Allow setting permissions for user-defined functions' from Wojciech Mitros
2023-03-12 14:04:34 +02:00
cql_config.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
cql_statement.hh
cql3: Extend the scope of group0_guard during DDL statement execution
2023-08-17 15:52:48 +03:00
Cql.g
cql3: improve readability of prepare_context
2023-09-25 17:18:53 +02:00
error_collector.hh
cql3: fix spurious token names in syntax error messages
2023-05-02 11:23:58 +03:00
error_listener.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
index_name.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
index_name.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
keyspace_element_name.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
keyspace_element_name.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
lists.cc
cql3: expr: break up expression.hh header
2023-06-22 14:21:03 +03:00
lists.hh
cql3: remove abstract_marker vestiges
2023-06-12 10:41:04 +03:00
maps.cc
cql3: expr: break up expression.hh header
2023-06-22 14:21:03 +03:00
maps.hh
cql3: remove abstract_marker vestiges
2023-06-12 10:41:04 +03:00
operation_impl.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
operation.cc
cql3: broadcast_tables: prepare new_value without relying on expression default constructor
2023-07-14 15:42:58 +03:00
operation.hh
cql3: broadcast_tables: prepare new_value without relying on expression default constructor
2023-07-14 15:42:58 +03:00
prepare_context.cc
cql3/prepare_context: fix generating pk_indexes for duplicate named bind variables
2023-09-25 17:18:53 +02:00
prepare_context.hh
cql3/prepare_context: fix generating pk_indexes for duplicate named bind variables
2023-09-25 17:18:53 +02:00
prepared_statements_cache.hh
treewide: use defaulted operator!=() and operator==()
2023-04-27 10:24:46 +03:00
query_options_fwd.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
query_options.cc
cql/query_options: add a check for missing bind marker name
2023-02-04 02:13:34 +02:00
query_options.hh
cql3, transport, tests: remove "unset" from value type system
2023-01-16 21:10:56 +02:00
query_processor.cc
Merge 'Mark counters with skip when empty' from Amnon Heiman
2023-09-19 15:02:39 +03:00
query_processor.hh
treewide: reduce include of cql_statement.hh
2023-09-08 13:23:50 +03:00
result_generator.hh
cql3: result_set: switch cell data type from bytes_opt to managed_bytes_opt
2023-05-07 17:17:36 +03:00
result_set.cc
cql3: result_set: switch cell data type from bytes_opt to managed_bytes_opt
2023-05-07 17:17:36 +03:00
result_set.hh
cql3: result_set: switch cell data type from bytes_opt to managed_bytes_opt
2023-05-07 17:17:36 +03:00
role_name.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
role_name.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
role_options.hh
…
sets.cc
cql3: expr: break up expression.hh header
2023-06-22 14:21:03 +03:00
sets.hh
cql3: remove abstract_marker vestiges
2023-06-12 10:41:04 +03:00
stats.hh
guardrails: restrict replication factor (RF)
2023-09-04 19:22:17 +03:00
type_json.cc
cql3: Fix invalid JSON parsing for JSON objects with ASCII keys
2023-10-05 22:26:08 +03:00
type_json.hh
types: move types.{cc,hh} into types
2023-02-19 21:05:45 +02:00
untyped_result_set.cc
untyped_result_set: add missing_column_exception
2023-08-04 07:37:12 +02:00
untyped_result_set.hh
cql3: untyped_result_set: document performance characteristics
2023-05-10 15:03:12 +03:00
update_parameters.cc
cql3: expr: break up expression.hh header
2023-06-22 14:21:03 +03:00
update_parameters.hh
cql: USING TTL 0 means unlimited, not default TTL
2023-03-08 16:18:23 +02:00
user_types.cc
cql3: expr: break up expression.hh header
2023-06-22 14:21:03 +03:00
user_types.hh
cql3: remove abstract_marker vestiges
2023-06-12 10:41:04 +03:00
ut_name.cc
cql: maybe quote user type name in ut_name::to_string()
2023-03-23 01:41:58 +01:00
ut_name.hh
cql: maybe quote user type name in ut_name::to_string()
2023-03-23 01:41:58 +01:00
util.cc
cql3: expr: break up expression.hh header
2023-06-22 14:21:03 +03:00
util.hh
cql3: grammar: don't default-construct expressions
2023-07-14 18:33:06 +03:00
values.cc
cql3, transport, tests: remove "unset" from value type system
2023-01-16 21:10:56 +02:00
values.hh
types: move types.{cc,hh} into types
2023-02-19 21:05:45 +02:00