mirror of
https://github.com/scylladb/scylladb.git
synced 2026-05-01 21:55:50 +00:00
assert() is traditionally disabled in release builds, but not in
scylladb. This hasn't caused problems so far, but the latest abseil
release includes a commit [1] that causes a 1000 insn/op regression when
NDEBUG is not defined.
Clearly, we must move towards a build system where NDEBUG is defined in
release builds. But we can't just define it blindly without vetting
all the assert() calls, as some were written with the expectation that
they are enabled in release mode.
To solve the conundrum, change all assert() calls to a new SCYLLA_ASSERT()
macro in utils/assert.hh. This macro is always defined and is not conditional
on NDEBUG, so we can later (after vetting Seastar) enable NDEBUG in release
mode.
[1] 66ef711d68
Closes scylladb/scylladb#20006
150 lines
4.5 KiB
C++
150 lines
4.5 KiB
C++
/*
|
|
* Copyright (C) 2021-present ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: AGPL-3.0-or-later
|
|
*/
|
|
#include "utils/assert.hh"
|
|
#include "service/raft/discovery.hh"
|
|
|
|
namespace service {
|
|
|
|
void check_peer(const discovery_peer& peer) {
|
|
if (peer.ip_addr == gms::inet_address{}) {
|
|
throw std::logic_error("Discovery requires peer internet address to be set");
|
|
}
|
|
}
|
|
|
|
discovery::discovery(discovery_peer self, const peer_list& seeds)
|
|
: _self(std::move(self)) {
|
|
|
|
// self must have a non-empty Internet address
|
|
check_peer(_self);
|
|
for (const auto& addr : seeds) {
|
|
check_peer(addr);
|
|
}
|
|
_peer_list.push_back(_self);
|
|
|
|
step(seeds);
|
|
}
|
|
|
|
void discovery::step(const peer_list& peers) {
|
|
if (_is_leader) {
|
|
return;
|
|
}
|
|
|
|
peer_set new_peers;
|
|
// Set to true if we learned about a new peer or
|
|
// received Raft server ID for one of the seeds.
|
|
bool refresh_peer_list = false;
|
|
|
|
for (const auto& addr : peers) {
|
|
// peer must have a non-empty Internet address
|
|
if (addr.ip_addr == _self.ip_addr) {
|
|
// do not include _self into _peers
|
|
continue;
|
|
}
|
|
auto it = _peers.find(addr);
|
|
// Update peer information if it's a new peer or provides
|
|
// a Raft ID for an existing peer.
|
|
if (it == _peers.end() || it->id == raft::server_id{}) {
|
|
refresh_peer_list = true;
|
|
if (it == _peers.end()) {
|
|
_peers.emplace(addr);
|
|
new_peers.emplace(addr);
|
|
} else {
|
|
// Update Raft ID
|
|
_peers.erase(it);
|
|
_peers.emplace(addr);
|
|
}
|
|
} else {
|
|
// If we have this peer, its ID must be the
|
|
// same as we know (with the exceptions of seeds,
|
|
// for which servers might not know ids at first).
|
|
SCYLLA_ASSERT(it == _peers.end() || it->id == addr.id || addr.id == raft::server_id{});
|
|
}
|
|
}
|
|
if (refresh_peer_list) {
|
|
_peer_list = {_peers.begin(), _peers.end()};
|
|
_peer_list.push_back(_self);
|
|
}
|
|
maybe_become_leader();
|
|
if (_is_leader) {
|
|
return;
|
|
}
|
|
for (const auto& peer : new_peers) {
|
|
_requests.push_back(std::make_pair(peer, _peer_list));
|
|
}
|
|
}
|
|
|
|
void discovery::maybe_become_leader() {
|
|
/*
|
|
* _responded is a subset of _peers.
|
|
* When all contacted peers have responded, we're ready
|
|
* to choose a node with the smallest id for the leader.
|
|
*/
|
|
if (_responded.size() < _peers.size()) {
|
|
return;
|
|
}
|
|
|
|
// Note: when we perform this check some peers may still have their Raft IDs
|
|
// undiscovered (we only know their server_infos: IP addresses etc.).
|
|
// Then their Raft IDs are set to raft::server_id{}, which contains UUID 0,
|
|
// which is the smallest UUID.
|
|
// That's fine - it means this check will not pass this time.
|
|
// The check can only pass when the Raft IDs of all peers are discovered.
|
|
//
|
|
// Note: it may happen we finish the algorithm before we discover all Raft IDs,
|
|
// if we obtain information about already existing group 0 from some peer.
|
|
// That's fine as well.
|
|
auto min_id = std::min_element(_peer_list.begin(), _peer_list.end(),
|
|
[](const auto& lhs, const auto& rhs) { return lhs.id < rhs.id; });
|
|
|
|
if (min_id != _peer_list.end() && min_id->id == _self.id) {
|
|
_is_leader = true;
|
|
}
|
|
}
|
|
|
|
std::optional<discovery::peer_list> discovery::request(const peer_list& peers) {
|
|
step(peers);
|
|
if (_is_leader) {
|
|
return std::nullopt;
|
|
}
|
|
return _peer_list;
|
|
}
|
|
|
|
void discovery::response(discovery_peer from, const peer_list& peers) {
|
|
SCYLLA_ASSERT(_peers.contains(from));
|
|
_responded.emplace(from);
|
|
step(peers);
|
|
}
|
|
|
|
discovery::tick_output discovery::tick() {
|
|
if (_is_leader) {
|
|
return i_am_leader{};
|
|
} else if (!_requests.empty()) {
|
|
return std::move(_requests);
|
|
} else {
|
|
if (_responded.size() == _peers.size()) {
|
|
// All have responded, but we're not a leader.
|
|
// Try to find out who it is. Don't waste traffic on
|
|
// the peer list.
|
|
for (const auto& peer : _peers) {
|
|
_requests.push_back(std::make_pair(peer, peer_list{}));
|
|
}
|
|
} else {
|
|
// Contact new peers
|
|
for (const auto& peer : _peers) {
|
|
if (_responded.contains(peer)) {
|
|
continue;
|
|
}
|
|
_requests.push_back(std::make_pair(peer, _peer_list));
|
|
}
|
|
}
|
|
return pause{};
|
|
}
|
|
}
|
|
|
|
} // end of namespace raft
|