mirror of
https://github.com/scylladb/scylladb.git
synced 2026-05-02 06:05:53 +00:00
e082fef32c
The stop assertion check in the group0 state id handler was triggering under some circumstances (stopping server during restart). In that case it might be that the stop is initiated before the server is fully initialized, and then the handler destructor is being called without calling to the `stop()` method first. This is a valid scenario. The whole `stop()` in the group0 state id handler is not necessary, as the only operation being done is cancelling the timer which is done by the timer destructor automatically anyway. There is the concern of a currently running timer callback, but it doesn't preempt (not async) so the timer shouldn't be destroyed before the callback finishes. Fixes: scylladb/scylladb#21074 Closes scylladb/scylladb#21127
73 lines
1.4 KiB
C++
73 lines
1.4 KiB
C++
/*
|
|
* Copyright (C) 2024-present ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: AGPL-3.0-or-later
|
|
*/
|
|
#pragma once
|
|
|
|
#include "raft/raft.hh"
|
|
#include "service/raft/group0_fwd.hh"
|
|
#include "utils/UUID.hh"
|
|
#include <seastar/core/future.hh>
|
|
#include <seastar/core/timer.hh>
|
|
|
|
namespace gms {
|
|
class gossiper;
|
|
}
|
|
|
|
namespace replica {
|
|
class database;
|
|
}
|
|
|
|
namespace raft {
|
|
class server;
|
|
}
|
|
|
|
|
|
namespace service {
|
|
|
|
class raft_group_registry;
|
|
|
|
|
|
class group0_server_accessor {
|
|
raft_group_registry& _raft_gr;
|
|
raft::group_id _group0_id;
|
|
|
|
public:
|
|
group0_server_accessor(raft_group_registry& raft_gr, raft::group_id group0_id)
|
|
: _raft_gr(raft_gr)
|
|
, _group0_id(group0_id) {
|
|
}
|
|
|
|
[[nodiscard]] raft::server* get_server() const;
|
|
};
|
|
|
|
class group0_state_id_handler {
|
|
|
|
replica::database& _local_db;
|
|
gms::gossiper& _gossiper;
|
|
const raft_address_map& _address_map;
|
|
group0_server_accessor _server_accessor;
|
|
lowres_clock::duration _refresh_interval;
|
|
|
|
timer<> _timer;
|
|
|
|
utils::UUID _state_id_last_advertised;
|
|
utils::UUID _state_id_last_reconcile;
|
|
|
|
static lowres_clock::duration get_refresh_interval(const replica::database& db);
|
|
|
|
void refresh();
|
|
|
|
public:
|
|
group0_state_id_handler(replica::database& local_db, gms::gossiper& gossiper, const raft_address_map& address_map, group0_server_accessor server_accessor);
|
|
|
|
void run();
|
|
|
|
future<> advertise_state_id(utils::UUID state_id);
|
|
};
|
|
|
|
} // namespace service
|