mirror of
https://github.com/scylladb/scylladb.git
synced 2026-05-02 22:25:48 +00:00
aa1270a00c
assert() is traditionally disabled in release builds, but not in
scylladb. This hasn't caused problems so far, but the latest abseil
release includes a commit [1] that causes a 1000 insn/op regression when
NDEBUG is not defined.
Clearly, we must move towards a build system where NDEBUG is defined in
release builds. But we can't just define it blindly without vetting
all the assert() calls, as some were written with the expectation that
they are enabled in release mode.
To solve the conundrum, change all assert() calls to a new SCYLLA_ASSERT()
macro in utils/assert.hh. This macro is always defined and is not conditional
on NDEBUG, so we can later (after vetting Seastar) enable NDEBUG in release
mode.
[1] 66ef711d68
Closes scylladb/scylladb#20006
65 lines
1.6 KiB
C++
65 lines
1.6 KiB
C++
/*
|
|
* Copyright (C) 2021 ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: AGPL-3.0-or-later
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "utils/assert.hh"
|
|
#include <seastar/core/reactor.hh>
|
|
#include <seastar/core/coroutine.hh>
|
|
#include <seastar/core/future-util.hh>
|
|
|
|
using namespace seastar;
|
|
|
|
// Calls the given function as fast as the Seastar reactor allows and waits on each call.
|
|
// The function is passed an incrementing integer (incremented by one for each call, starting at 0).
|
|
// The number of ticks can be limited. We crash if the ticker reaches the limit before it's `abort()`ed.
|
|
// Call `start()` to start the ticking.
|
|
class ticker {
|
|
bool _stop = false;
|
|
std::optional<future<>> _ticker;
|
|
seastar::logger& _logger;
|
|
|
|
public:
|
|
ticker(seastar::logger& l) : _logger(l) {}
|
|
ticker(const ticker&) = delete;
|
|
ticker(ticker&&) = delete;
|
|
|
|
~ticker() {
|
|
SCYLLA_ASSERT(!_ticker);
|
|
}
|
|
|
|
using on_tick_t = noncopyable_function<future<>(uint64_t)>;
|
|
|
|
void start(on_tick_t fun, uint64_t limit = std::numeric_limits<uint64_t>::max()) {
|
|
SCYLLA_ASSERT(!_ticker);
|
|
_ticker = tick(std::move(fun), limit);
|
|
}
|
|
|
|
future<> abort() {
|
|
if (_ticker) {
|
|
_stop = true;
|
|
co_await *std::exchange(_ticker, std::nullopt);
|
|
}
|
|
}
|
|
|
|
private:
|
|
future<> tick(on_tick_t fun, uint64_t limit) {
|
|
for (uint64_t tick = 0; tick < limit; ++tick) {
|
|
if (_stop) {
|
|
_logger.info("ticker: finishing after {} ticks", tick);
|
|
co_return;
|
|
}
|
|
|
|
co_await fun(tick);
|
|
}
|
|
|
|
_logger.error("ticker: limit reached");
|
|
SCYLLA_ASSERT(false);
|
|
}
|
|
};
|