8de81f8f91
This series adds facilities to gently convert canonical mutations back to mutations and to gently make canonical mutations or freeze mutations in a seastar thread. Those are used in storage_service::merge_topology_snapshot to prevent reactor stalls due to large mutation, as seed in the test_add_many_nodes_under_load dtest. Also, migration_manager migration_request was converted to use a seastar thread to use the above facilities to prevent reactor stalls with large schema mutations, e,g, with a large number of tables, and/or when reading tablets mutations with a large number of tablets in a table. perf-simple-query --write results: Before: ``` median 79151.53 tps ( 59.3 allocs/op, 16.0 logallocs/op, 14.3 tasks/op, 53289 insns/op, 0 errors) ``` After: ``` median 79716.73 tps ( 59.3 allocs/op, 16.0 logallocs/op, 14.3 tasks/op, 53314 insns/op, 0 errors) ``` Closes scylladb/scylladb#18290 * github.com:scylladb/scylladb: storage_proxy: add mutate_locally(vector<frozen_mutation_and_schema>) method raft: group0_state_machine: write_mutations_to_database: freeze mutations gently database: apply_in_memory: unfreeze_gently large mutations storage_service: get_system_mutations: make_canonical_mutation_gently tablets: read_tablet_mutations: make_canonical_mutation_gently schema_tables: convert_schema_to_mutations: make_canonical_mutation_gently schema_tables: redact_columns_for_missing_features: get input mutation using rvalue reference storage_service: merge_topology_snapshot: freeze_gently canonical_mutation: add make_canonical_mutation_gently frozen_mutation: move unfreeze_gently to async_utils mutation: add freeze_gently idl-compiler: generate async serialization functions for stub members raft: group0_state_machine: write_mutations_to_database: use to_mutation_gently storage_service: merge_topology_snapshot: co_await to_mutation_gently canonical_mutation: add to_mutation_gently idl-compiler: emit include directive in generated impl header file mutation_partition: add apply_gently collection_mutation: improve collection_mutation_view formatting mutation_partition: apply_monotonically: do not support schema upgrade test/perf: report also log_allocations/op
Scylla in-source tests.
For details on how to run the tests, see docs/dev/testing.md
Shared C++ utils, libraries are in lib/, for Python - pylib/
alternator - Python tests which connect to a single server and use the DynamoDB API unit, boost, raft - unit tests in C++ cql-pytest - Python tests which connect to a single server and use CQL topology* - tests that set up clusters and add/remove nodes cql - approval tests that use CQL and pre-recorded output rest_api - tests for Scylla REST API Port 9000 scylla-gdb - tests for scylla-gdb.py helper script nodetool - tests for C++ implementation of nodetool
If you can use an existing folder, consider adding your test to it. New folders should be used for new large categories/subsystems, or when the test environment is significantly different from some existing suite, e.g. you plan to start scylladb with different configuration, and you intend to add many tests and would like them to reuse an existing Scylla cluster (clusters can be reused for tests within the same folder).
To add a new folder, create a new directory, and then
copy & edit its suite.ini.