mirror of
https://github.com/scylladb/scylladb.git
synced 2026-05-30 11:36:54 +00:00
f165b396fd
A recent Seastar update deprecated smp::count and introduced this_smp_shard_count() as a replacement. One difference is that this_smp_shard_count() wants to run on a reactor thread. This poses a problem for non-reactor tests (BOOST_AUTO_TEST_CASE) that nevertheless use a schema, as the schema_builder constructor references smp::count. If we replace it with this_smp_shard_count() then it will crash when running without a reactor. To fix, remove the implicit this_smp_shard_count() call from raw_schema's constructor and require callers to pass shard_count explicitly to schema_builder. This allows tests that don't run on a reactor thread to construct schemas without crashing. Production code and reactor-based tests pass this_smp_shard_count(). Non-reactor test files (expr_test, keys_test, nonwrapping_interval_test, wrapping_interval_test, bti_key_translation_test, range_tombstone_list_test) pass a fixed shard count of 1. Note: sstable_test.cc is a Seastar test file (SEASTAR_THREAD_TEST_CASE) but also contains one plain BOOST_AUTO_TEST_CASE (test_empty_key_view_comparison) that constructs a schema_builder without a reactor context. This test also receives a fixed shard count of 1.
55 lines
1.8 KiB
C++
55 lines
1.8 KiB
C++
|
|
/*
|
|
* Copyright (C) 2015-present ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: LicenseRef-ScyllaDB-Source-Available-1.1
|
|
*/
|
|
|
|
#include "replica/database.hh"
|
|
#include "schema/schema_builder.hh"
|
|
#include "test/perf/perf.hh"
|
|
#include <seastar/core/app-template.hh>
|
|
#include <seastar/core/reactor.hh>
|
|
|
|
static atomic_cell make_atomic_cell(data_type dt, bytes value) {
|
|
return atomic_cell::make_live(*dt, 0, value);
|
|
};
|
|
|
|
int main(int argc, char* argv[]) {
|
|
namespace bpo = boost::program_options;
|
|
app_template app;
|
|
app.add_options()
|
|
("column-count", bpo::value<size_t>()->default_value(1), "column count");
|
|
return app.run_deprecated(argc, argv, [&] {
|
|
size_t column_count = app.configuration()["column-count"].as<size_t>();
|
|
auto builder = schema_builder(this_smp_shard_count(), "ks", "cf")
|
|
.with_column("p1", utf8_type, column_kind::partition_key)
|
|
.with_column("c1", int32_type, column_kind::clustering_key);
|
|
|
|
std::vector<sstring> cnames;
|
|
for (size_t i = 0; i < column_count; i++) {
|
|
cnames.push_back(fmt::format("r{}", i + 1));
|
|
builder.with_column(to_bytes(cnames.back()), int32_type);
|
|
}
|
|
|
|
auto s = builder.build();
|
|
replica::memtable mt(s);
|
|
|
|
std::cout << "Timing mutation of single column within one row...\n";
|
|
|
|
auto key = partition_key::from_exploded(*s, {to_bytes("key1")});
|
|
auto c_key = clustering_key::from_exploded(*s, {int32_type->decompose(2)});
|
|
bytes value = int32_type->decompose(3);
|
|
|
|
time_it([&] {
|
|
mutation m(s, key);
|
|
const column_definition& col = *s->get_column_definition(to_bytes(cnames[std::rand() % column_count]));
|
|
m.set_clustered_cell(c_key, col, make_atomic_cell(col.type, value));
|
|
mt.apply(std::move(m));
|
|
});
|
|
engine().exit(0);
|
|
});
|
|
}
|