mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-06-07 07:23:15 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
8e6fbb99c72bc85d285361375cd1f31f4c8e2df9
scylladb/cql3/statements
History
Nadav Har'El 7cdee303cf Merge 'ks_prop_defs: disallow empty replication factor string in NTS' from Jan Ciołek 
A CREATE KEYSPACE query which specifies an empty string ('') as the replication factor value is currently allowed:
```cql
CREATE KEYSPACE bad_ks WITH replication = {'class': 'NetworkTopologyStrategy', 'replication_factor': ''};
```

This is wrong, it's invalid to have an empty replication factor string.
It creates a keyspace without any replication, so the tables inside of it aren't writable.

Trying to create a `SimpleStrategy` keyspace with such replication factor throws an error, `NetworkTopolgyStrategy` should do the same.

The problem was in `prepare_options`, it treated an empty replication factor string as no replication factor.
Changing it to `std::optional` fixes the problem,
Now `std::nullopt` means no replication factor, and `make_optional("")` means that there is a replication factor, but it's described by an empty string.

Fixes: https://github.com/scylladb/scylladb/issues/13986

Closes #13988

* github.com:scylladb/scylladb:
  test/network_topology_strategy_test: Test NTS with replication_factor option in test_invalid_dcs
  ks_prop_defs: disallow empty replication factor string in NTS
2023-05-24 21:39:31 +03:00
..
raw
cql3: result_set: switch cell data type from bytes_opt to managed_bytes_opt
2023-05-07 17:17:36 +03:00
alter_keyspace_statement.cc
treewide: do not define/capture unused variables
2023-02-15 22:57:18 +02:00
alter_keyspace_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
alter_role_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
alter_service_level_statement.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
alter_service_level_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
alter_table_statement.cc
treewide: use fmt::join() when appropriate
2023-03-16 20:34:18 +08:00
alter_table_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
alter_type_statement.cc
cql: maybe quote user type name in ut_name::to_string()
2023-03-23 01:41:58 +01:00
alter_type_statement.hh
Introduce schema/ module
2023-02-15 11:01:50 +02:00
alter_view_statement.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
alter_view_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
attach_service_level_statement.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
attach_service_level_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
authentication_statement.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
authentication_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
authorization_statement.cc
cql3: capture reference to temporary value by value
2023-05-01 22:41:41 +03:00
authorization_statement.hh
cql3: allow UDTs in permissions on UDFs
2023-03-10 11:02:33 +01:00
batch_statement.cc
treewide: use fmt::join() when appropriate
2023-03-16 20:34:18 +08:00
batch_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
bound.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
cas_request.cc
Introduce mutation/ module
2023-02-14 11:19:03 +02:00
cas_request.hh
cql3: update_parameters: use evaluation_inputs compatible row prefetch
2023-02-12 17:25:41 +02:00
cf_prop_defs.cc
cql: validate bloom_filter_fp_chance up-front
2022-09-20 06:18:51 +03:00
cf_prop_defs.hh
Introduce schema/ module
2023-02-15 11:01:50 +02:00
cf_properties.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
cf_statement.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
create_aggregate_statement.cc
cql: check permissions for used functions when creating a UDA
2023-05-10 18:06:04 +03:00
create_aggregate_statement.hh
cql: check permissions for used functions when creating a UDA
2023-05-10 18:06:04 +03:00
create_function_statement.cc
wasm: return wasm instance cache as a reference instead of a pointer
2023-03-28 18:18:48 +02:00
create_function_statement.hh
wasm: convert compilation to a future
2023-03-07 14:27:38 +01:00
create_index_statement.cc
Introduce schema/ module
2023-02-15 11:01:50 +02:00
create_index_statement.hh
Introduce schema/ module
2023-02-15 11:01:50 +02:00
create_keyspace_statement.cc
cql: grant permissions on functions when creating a keyspace/function
2023-05-12 10:56:29 +02:00
create_keyspace_statement.hh
cql: pass a reference to query processor in grant_permissions_to_creator
2023-05-12 10:56:29 +02:00
create_role_statement.hh
cql: pass a reference to query processor in grant_permissions_to_creator
2023-05-12 10:56:29 +02:00
create_service_level_statement.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
create_service_level_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
create_table_statement.cc
cql: pass a reference to query processor in grant_permissions_to_creator
2023-05-12 10:56:29 +02:00
create_table_statement.hh
cql: pass a reference to query processor in grant_permissions_to_creator
2023-05-12 10:56:29 +02:00
create_type_statement.cc
cql: maybe quote user type name in ut_name::to_string()
2023-03-23 01:41:58 +01:00
create_type_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
create_view_statement.cc
treewide: use fmt::join() when appropriate
2023-03-16 20:34:18 +08:00
create_view_statement.hh
cql3: grammar: make where clause return an expression
2022-07-22 20:14:48 +03:00
delete_statement.cc
cql3: grammar: communicate LWT IF conditions to AST as a simple expression
2023-02-15 14:21:26 +02:00
delete_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
describe_statement.cc
code: Remove some headers from query_processor.hh
2023-03-31 07:08:41 +03:00
describe_statement.hh
cql3: mark several private fields as maybe_unused
2022-12-19 20:53:07 +02:00
detach_service_level_statement.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
detach_service_level_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
drop_aggregate_statement.cc
wasm: convert compilation to a future
2023-03-07 14:27:38 +01:00
drop_aggregate_statement.hh
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
drop_function_statement.cc
wasm: convert compilation to a future
2023-03-07 14:27:38 +01:00
drop_function_statement.hh
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
drop_index_statement.cc
Introduce schema/ module
2023-02-15 11:01:50 +02:00
drop_index_statement.hh
Introduce schema/ module
2023-02-15 11:01:50 +02:00
drop_keyspace_statement.cc
migration_manager: Make prepare_keyspace_drop_announcement() return a future<>
2023-04-24 10:49:37 +02:00
drop_keyspace_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
drop_role_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
drop_service_level_statement.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
drop_service_level_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
drop_table_statement.cc
Introduce mutation/ module
2023-02-14 11:19:03 +02:00
drop_table_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
drop_type_statement.cc
cql: maybe quote user type name in ut_name::to_string()
2023-03-23 01:41:58 +01:00
drop_type_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
drop_view_statement.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
drop_view_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
function_statement.cc
cql: fix authorization when altering a function
2023-05-12 10:56:29 +02:00
function_statement.hh
cql: fix authorization when altering a function
2023-05-12 10:56:29 +02:00
grant_role_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
grant_statement.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
grant_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
index_prop_defs.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
index_prop_defs.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
index_target.cc
cql3: s/std::regex/boost::regex/
2023-04-06 09:50:32 -04:00
index_target.hh
cql3: s/std::regex/boost::regex/
2023-04-06 09:50:32 -04:00
ks_prop_defs.cc
ks_prop_defs: disallow empty replication factor string in NTS
2023-05-22 17:56:16 +02:00
ks_prop_defs.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
list_permissions_statement.cc
Merge 'Allow setting permissions for user-defined functions' from Wojciech Mitros
2023-03-12 14:04:34 +02:00
list_permissions_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
list_roles_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
list_service_level_attachments_statement.cc
treewide: do not define/capture unused variables
2023-02-15 22:57:18 +02:00
list_service_level_attachments_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
list_service_level_statement.cc
treewide: do not define/capture unused variables
2023-02-15 22:57:18 +02:00
list_service_level_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
list_users_statement.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
list_users_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
modification_statement.cc
cql3: use statement_restrictions::has_token_restrictions() wherever possible
2023-04-29 13:04:52 +02:00
modification_statement.hh
cql: USING TTL 0 means unlimited, not default TTL
2023-03-08 16:18:23 +02:00
permission_altering_statement.cc
cql: check if the keyspace is system when altering permissions
2023-05-02 10:13:59 +03:00
permission_altering_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
prepared_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
property_definitions.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
property_definitions.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
prune_materialized_view_statement.cc
treewide: drop cql_serialization_format
2023-01-03 19:54:13 +02:00
prune_materialized_view_statement.hh
cql3: add a statement for deleting ghost rows
2022-05-19 10:11:50 +02:00
request_validations.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
revoke_role_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
revoke_statement.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
revoke_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
role-management-statements.cc
cql: pass a reference to query processor in grant_permissions_to_creator
2023-05-12 10:56:29 +02:00
schema_altering_statement.cc
cql: pass a reference to query processor in grant_permissions_to_creator
2023-05-12 10:56:29 +02:00
schema_altering_statement.hh
cql: pass a reference to query processor in grant_permissions_to_creator
2023-05-12 10:56:29 +02:00
select_statement.cc
exceptions: remove relation field from unrecognized_entity_exception
2023-05-24 19:35:26 +03:00
select_statement.hh
cql3, transport, tests: remove "unset" from value type system
2023-01-16 21:10:56 +02:00
service_level_statement.cc
cql3 statements: Change dependency test API to express better it's
2022-02-27 11:48:03 +02:00
service_level_statement.hh
cql3 statements: Change dependency test API to express better it's
2022-02-27 11:48:03 +02:00
sl_prop_defs.cc
cql3: fix misleading error message for service level timeouts
2022-03-31 07:04:00 +03:00
sl_prop_defs.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
statement_type.hh
treewide: use defaulted operator!=() and operator==()
2023-04-27 10:24:46 +03:00
strongly_consistent_modification_statement.cc
code: Remove some headers from query_processor.hh
2023-03-31 07:08:41 +03:00
strongly_consistent_modification_statement.hh
raft: broadcast_tables: add support for bind variables
2022-09-28 09:54:59 +03:00
strongly_consistent_select_statement.cc
cql3: result_set: switch cell data type from bytes_opt to managed_bytes_opt
2023-05-07 17:17:36 +03:00
strongly_consistent_select_statement.hh
raft: broadcast_tables: add support for bind variables
2022-09-28 09:54:59 +03:00
truncate_statement.cc
cql3, storage_proxy: add support for TRUNCATE USING TIMEOUT
2022-09-26 18:30:39 +03:00
truncate_statement.hh
cql3/statements/truncate_statement: remove defaulted move ctor
2023-02-19 12:57:40 +08:00
update_statement.cc
cql3: modification_statement: use single expression for conditions
2023-02-15 14:21:26 +02:00
update_statement.hh
raft: broadcast_tables: add compilation of cql to intermediate language
2022-09-08 15:25:36 +02:00
use_statement.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
use_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00