mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-27 11:55:15 +00:00
4ffc39d885
Currently we hold group0_guard only during DDL statement's execute() function, but unfortunately some statements access underlying schema state also during check_access() and validate() calls which are called by the query_processor before it calls execute. We need to cover those calls with group0_guard as well and also move retry loop up. This patch does it by introducing new function to cql_statement class take_guard(). Schema altering statements return group0 guard while others do not return any guard. Query processor takes this guard at the beginning of a statement execution and retries if service::group0_concurrent_modification is thrown. The guard is passed to the execute in query_state structure. Fixes: #13942 Message-ID: <ZNsynXayKim2XAFr@scylladb.com>
53 lines
1.3 KiB
C++
53 lines
1.3 KiB
C++
/*
|
|
* Copyright 2017-present ScyllaDB
|
|
*
|
|
* Modified by ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: (AGPL-3.0-or-later and Apache-2.0)
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <seastar/core/sstring.hh>
|
|
|
|
#include "cql3/statements/authentication_statement.hh"
|
|
#include "cql3/role_name.hh"
|
|
#include "cql3/role_options.hh"
|
|
|
|
namespace cql3 {
|
|
|
|
class query_processor;
|
|
|
|
namespace statements {
|
|
|
|
class create_role_statement final : public authentication_statement {
|
|
sstring _role;
|
|
|
|
role_options _options;
|
|
|
|
bool _if_not_exists;
|
|
|
|
public:
|
|
create_role_statement(
|
|
const cql3::role_name& name, const role_options& options, bool if_not_exists)
|
|
: _role(name.to_string())
|
|
, _options(std::move(options))
|
|
, _if_not_exists(if_not_exists) {
|
|
}
|
|
|
|
std::unique_ptr<prepared_statement> prepare(data_dictionary::database db, cql_stats& stats) override;
|
|
|
|
future<> grant_permissions_to_creator(const service::client_state&) const;
|
|
|
|
virtual future<> check_access(query_processor& qp, const service::client_state&) const override;
|
|
|
|
virtual future<::shared_ptr<cql_transport::messages::result_message>>
|
|
execute(query_processor&, service::query_state&, const query_options&, std::optional<service::group0_guard> guard) const override;
|
|
};
|
|
|
|
}
|
|
|
|
}
|