mirrors/scylladb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
8fa2e3ad2ac00a3eeb30c60ab598fe36652630ea
scylladb/test/boost
History
Avi Kivity 8fa2e3ad2a Merge 'Remove sstables::remove_by_toc_name()' from Pavel Emelyanov 
The helper in question complicates the logic of sstable_directory::process() by making garbage collection differently for sstables deleted "atomically" and deleted "one-by-one". Also, the code that deletes sstables one-by-one and uses remove_by_toc_name() renders excessive TOC file reading, because there's sstable object at hand and it had all_components() ready for use.

Surprisingly, there was no test for the deletion-log functionality. This PR adds one. The test passes before the g.c. and regular unlink fix, and (of course) continues passing after it.

Closes scylladb/scylladb#16240

* github.com:scylladb/scylladb:
  sstables: Drop remove_by_name()
  sstables/fs_storage: Wipe by recognized+unrecognized components
  sstable_directory: Enlight deletion log replay
  sstables: Split remove_by_toc_name()
  test: Add test case to validate deletion log work
  sstable_directory: Close dir on exception
  sstable_directory: Fix indentation after previous patch
  sstable_directory: Coroutinize delete_with_pending_deletion_log()
  test: Sstable on_delete() is not necessarily in a thread
  sstable_directory: Split delete_with_pending_deletion_log()
2023-12-03 17:29:34 +02:00
..
aggregate_fcts_test.cc
test: do not initialize a time_t with braces
2023-03-07 17:54:53 +08:00
allocation_strategy_test.cc
…
alternator_unit_test.cc
alternator: unit test for number magnitude and precision function
2023-05-02 11:04:05 +03:00
anchorless_list_test.cc
…
auth_passwords_test.cc
…
auth_resource_test.cc
auth: remove unused operator<<(.., resource_kind)
2023-04-07 20:32:28 +08:00
auth_test.cc
treewide: do not define/capture unused variables
2023-02-28 21:56:53 +08:00
batchlog_manager_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
big_decimal_test.cc
…
bptree_test.cc
…
broken_sstable_test.cc
test: sstables: use generation_type::int_t
2023-03-22 13:48:50 +02:00
btree_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
bytes_ostream_test.cc
…
cache_algorithm_test.cc
test: boost/cache_algorithm_test: add cache_algorithm_test
2023-09-01 22:34:41 +02:00
cache_flat_mutation_reader_test.cc
partition_version: remove the schema argument from partition_entry::read()
2023-05-04 02:37:29 +02:00
cached_file_test.cc
utils: cached_file: deglobalize cached_file metrics
2023-09-01 22:34:41 +02:00
caching_options_test.cc
Introduce schema/ module
2023-02-15 11:01:50 +02:00
canonical_mutation_test.cc
Introduce mutation/ module
2023-02-14 11:19:03 +02:00
cartesian_product_test.cc
…
castas_fcts_test.cc
make timestamp string format cassandra compatible
2023-07-27 12:01:09 +03:00
cdc_generation_test.cc
cdc: use chunked_vector for topology_description entries
2023-09-18 23:17:01 +03:00
cdc_test.cc
test: Open-code ks.cf name parse into cdc_test
2023-08-12 11:46:36 +03:00
cell_locker_test.cc
Introduce schema/ module
2023-02-15 11:01:50 +02:00
checksum_utils_test.cc
…
chunked_managed_vector_test.cc
treewide: use unsigned variable to compare with unsigned
2023-07-18 10:27:18 +08:00
chunked_vector_test.cc
test/boost/chunked_vector_test: remove defaulted exception_safe_class's move ctor
2023-02-19 12:58:22 +08:00
clustering_ranges_walker_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
CMakeLists.txt
test: boost/cache_algorithm_test: add cache_algorithm_test
2023-09-01 22:34:41 +02:00
column_mapping_test.cc
schema_tables: Add system_keyspace& argument to ..._column_mapping() calls
2023-07-28 15:55:13 +03:00
commitlog_test.cc
Typos: fix typos in comments
2023-12-02 22:37:22 +02:00
compound_test.cc
Introduce schema/ module
2023-02-15 11:01:50 +02:00
compress_test.cc
…
config_test.cc
Typos: fix typos in comments
2023-12-02 22:37:22 +02:00
continuous_data_consumer_test.cc
build: disable implicit fallthrough
2023-07-10 19:36:06 +02:00
counter_test.cc
Merge ' mvcc: make schema upgrades gentle' from Michał Chojnowski
2023-05-24 22:58:43 +02:00
cql_auth_query_test.cc
test: use NetworkTopologyStrategy in all unit tests
2023-05-23 08:52:56 +03:00
cql_auth_syntax_test.cc
…
cql_functions_test.cc
test/boost/cql_functions_test: split long running tests
2023-06-26 11:29:36 +03:00
cql_query_group_test.cc
Introduce schema/ module
2023-02-15 11:01:50 +02:00
cql_query_large_test.cc
Typos: fix typos in comments
2023-12-02 22:37:22 +02:00
cql_query_like_test.cc
Introduce schema/ module
2023-02-15 11:01:50 +02:00
cql_query_test.cc
Typos: fix typos in comments
2023-12-02 22:37:22 +02:00
crc_test.cc
…
data_listeners_test.cc
treewide: stop using 'using namespace std' in namespace scope
2023-04-17 14:08:37 +03:00
database_test.cc
querier: add more information about the read on semaphore mismatch
2023-10-05 10:27:53 +03:00
dirty_memory_manager_test.cc
Typos: fix typos in comments
2023-12-02 22:37:22 +02:00
double_decker_test.cc
Typos: fix typos in comments
2023-12-02 22:37:22 +02:00
duration_test.cc
Typos: fix typos in comments
2023-12-02 22:37:22 +02:00
dynamic_bitset_test.cc
…
enum_option_test.cc
…
enum_set_test.cc
move to_string.hh to utils/
2023-02-15 11:09:04 +02:00
error_injection_test.cc
tests: utils: error injection: add test for injection's parameters
2023-07-13 10:10:52 +02:00
estimated_histogram_test.cc
…
exception_container_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
exceptions_fallback_test.cc
…
exceptions_optimized_test.cc
…
exceptions_test.inc.cc
…
expr_test.cc
Typos: fix typos in comments
2023-12-02 22:37:22 +02:00
extensions_test.cc
test: Optionally initialize proxy remote for cql_test_env
2023-07-19 19:32:10 +03:00
filtering_test.cc
Typos: fix typos in comments
2023-12-02 22:37:22 +02:00
flat_mutation_reader_test.cc
code: Switch to seastar API level 7
2023-06-06 13:29:16 +03:00
flush_queue_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
fragmented_temporary_buffer_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
frozen_mutation_test.cc
Introduce schema/ module
2023-02-15 11:01:50 +02:00
gossiping_property_file_snitch_test.cc
treewide: do not define/capture unused variables
2023-02-28 21:56:53 +08:00
group0_cmd_merge_test.cc
Typos: fix typos in comments
2023-12-02 22:37:22 +02:00
group0_test.cc
test: use correct timestamp resolution in test_group0_history_clearing_old_entries
2023-07-13 10:33:52 +03:00
hash_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
hashers_test.cc
utils: hashing: add simple_xx_hasher
2023-04-24 14:06:43 +03:00
hint_test.cc
hints: move formatter of db::hints::sync_point to test
2023-11-23 11:22:31 +02:00
idl_test.cc
…
index_with_paging_test.cc
test/boost/index_with_paging_test: parallel insert
2023-06-28 16:11:58 +02:00
input_stream_test.cc
…
intrusive_array_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
json_cql_query_test.cc
cql: fix SELECT toJson() or SELECT JSON of time column
2023-11-27 10:03:04 +02:00
json_test.cc
…
keys_test.cc
types: move types.{cc,hh} into types
2023-02-19 21:05:45 +02:00
large_paging_state_test.cc
types: move types.{cc,hh} into types
2023-02-19 21:05:45 +02:00
like_matcher_test.cc
…
limiting_data_source_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
linearizing_input_stream_test.cc
…
lister_test.cc
test: Generalize touch_file() into test_utils.*
2023-05-23 10:40:55 +03:00
loading_cache_test.cc
Typos: fix typos in comments
2023-12-02 22:37:22 +02:00
locator_topology_test.cc
Typos: fix typos in comments
2023-12-02 22:37:22 +02:00
log_heap_test.cc
…
logalloc_standard_allocator_segment_pool_backend_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
logalloc_test.cc
Typos: fix typos in comments
2023-12-02 22:37:22 +02:00
managed_bytes_test.cc
…
managed_vector_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
map_difference_test.cc
treewide: stop using 'using namespace std' in namespace scope
2023-04-17 14:08:37 +03:00
memtable_test.cc
Typos: fix typos in comments
2023-12-02 22:37:22 +02:00
multishard_combining_reader_as_mutation_source_test.cc
code: Switch to seastar API level 7
2023-06-06 13:29:16 +03:00
multishard_mutation_query_test.cc
test/boost/multishard_mutation_query_test: fix querier cache misses expectations
2023-10-23 08:07:14 -04:00
murmur_hash_test.cc
…
mutation_fragment_test.cc
code: Switch to seastar API level 7
2023-06-06 13:29:16 +03:00
mutation_query_test.cc
mutation_query_test: test that range tombstones are sent in reverse queries
2023-11-08 14:54:48 +01:00
mutation_reader_test.cc
Typos: fix typos in comments
2023-12-02 22:37:22 +02:00
mutation_test.cc
Typos: fix typos in comments
2023-12-02 22:37:22 +02:00
mutation_writer_test.cc
stream_transfer_task, multishard_writer: Work with table sharder
2023-07-25 21:08:51 +02:00
mvcc_test.cc
test: mvcc_test: add a test for gentle schema upgrades
2023-05-04 03:35:15 +02:00
network_topology_strategy_test.cc
locator: topology: node::state: make fine grained
2023-07-31 10:33:48 +03:00
nonwrapping_range_test.cc
Introduce schema/ module
2023-02-15 11:01:50 +02:00
observable_test.cc
…
partitioner_test.cc
treewide: use unsigned variable to compare with unsigned
2023-07-18 10:27:18 +08:00
per_partition_rate_limit_test.cc
treewide: Replace dht::shard_of() uses with table::shard_of() / erm::shard_of()
2023-06-21 00:58:24 +02:00
pretty_printers_test.cc
utils: drop operator<< for pretty printers
2023-07-17 14:02:13 +08:00
querier_cache_test.cc
querier: add more information about the read on semaphore mismatch
2023-10-05 10:27:53 +03:00
query_processor_test.cc
test: Optionally initialize proxy remote for cql_test_env
2023-07-19 19:32:10 +03:00
radix_tree_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
range_assert.hh
…
range_test.cc
Introduce schema/ module
2023-02-15 11:01:50 +02:00
range_tombstone_list_assertions.hh
Introduce mutation/ module
2023-02-14 11:19:03 +02:00
range_tombstone_list_test.cc
mutation: specialize fmt::formatter<range_tombstone_{entry,list}>
2023-04-26 09:00:25 +03:00
rate_limiter_test.cc
treewide: do not define/capture unused variables
2023-02-28 21:56:53 +08:00
reader_concurrency_semaphore_test.cc
test: Use BOOST_REQUIRE(db.has_schema())
2023-08-12 11:46:32 +03:00
recent_entries_map_test.cc
Fix test.py with compaction groups
2023-07-18 16:57:11 +03:00
repair_test.cc
tests: Make use of make_memtable() helper
2023-11-02 19:28:35 +03:00
restrictions_test.cc
Merge 'mv: forbid IS NOT NULL on columns outside the primary key' from Jan Ciołek
2023-06-07 12:12:19 +03:00
result_utils_test.cc
treewide: do not define/capture unused variables
2023-02-28 21:56:53 +08:00
reusable_buffer_test.cc
utils: redesign reusable_buffer
2023-04-26 22:09:17 +02:00
role_manager_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
row_cache_test.cc
tests: Make use of make_memtable() helper
2023-11-02 19:28:35 +03:00
rust_test.cc
…
s3_test.cc
s3/client: Don't GET object contents on out-of-bound reads
2023-11-29 12:09:52 +03:00
schema_change_test.cc
config: Make object storage config updateable_value_source
2023-11-21 16:47:50 +03:00
schema_changes_test.cc
test/boost/schema_changes_test: split long-running test
2023-06-26 11:24:07 +03:00
schema_loader_test.cc
test: use NetworkTopologyStrategy in all unit tests
2023-05-23 08:52:56 +03:00
schema_registry_test.cc
Revert "Merge 'Don't calculate hashes for schema versions in Raft mode' from Kamil Braun"
2023-10-11 00:32:05 +03:00
secondary_index_test.cc
Typos: fix typos in comments
2023-12-02 22:37:22 +02:00
serialization_test.cc
treewide: s/boost::lexical_cast<std::string>/fmt::to_string()/
2023-04-21 09:43:53 +03:00
serialized_action_test.cc
serialized_action: make serialized_action abortable
2023-05-11 16:31:23 +03:00
service_level_controller_test.cc
treewide: use defaulted operator!=() and operator==()
2023-04-27 10:24:46 +03:00
small_vector_test.cc
treewide: use defaulted operator!=() and operator==()
2023-04-27 10:24:46 +03:00
snitch_reset_test.cc
treewide: do not define/capture unused variables
2023-02-28 21:56:53 +08:00
sstable_3_x_test.cc
Typos: fix typos in comments
2023-12-02 22:37:22 +02:00
sstable_compaction_test.cc
Merge 'Remove sstables::remove_by_toc_name()' from Pavel Emelyanov
2023-12-03 17:29:34 +02:00
sstable_conforms_to_mutation_source_test.cc
sstable_conforms_to_mutation_source_test: Open-code the make_sstable()
2023-11-02 19:30:54 +03:00
sstable_datafile_test.cc
Merge 'Sanitize usage of make_sstable_easy+make_memtable in tests' from Pavel Emelyanov
2023-11-07 09:29:30 +02:00
sstable_directory_test.cc
test: Add test case to validate deletion log work
2023-12-01 18:20:20 +03:00
sstable_generation_test.cc
Typos: fix typos in comments
2023-12-02 22:37:22 +02:00
sstable_move_test.cc
sstable: Make .change_state() accept state, not directory string
2023-08-14 15:40:44 +03:00
sstable_mutation_test.cc
Typos: fix typos in comments
2023-12-02 22:37:22 +02:00
sstable_partition_index_cache_test.cc
sstables: partition_index_cache: deglobalize stats
2023-09-01 22:34:41 +02:00
sstable_resharding_test.cc
Merge 'sstable: switch to uuid identifier for naming S3 sstable objects' from Kefu Chai
2023-10-23 21:05:13 +03:00
sstable_set_test.cc
sstable_set: Remove unused _schema field
2023-10-04 18:50:23 +02:00
sstable_test.cc
Merge 'test: set use_uuid to true by default in sstables::test_env ' from Kefu Chai
2023-10-19 09:09:38 +03:00
sstable_test.hh
tests: Drop as_mutation_source helper
2023-11-02 19:27:59 +03:00
stall_free_test.cc
utils: clear_gently: add variants for optional values
2023-04-23 21:34:02 +03:00
statement_restrictions_test.cc
test: silence the deprecation warning.
2023-07-12 13:10:33 +03:00
storage_proxy_test.cc
Typos: fix typos in comments
2023-12-02 22:37:22 +02:00
string_format_test.cc
Revert "test: string_format_test: don't compare std::string with sstring"
2023-05-29 23:03:24 +03:00
suite.yaml
test: boost/cache_algorithm_test: add cache_algorithm_test
2023-09-01 22:34:41 +02:00
summary_test.cc
…
tablets_test.cc
tests: tablets: do not compare signed integer with unsigned integer
2023-09-18 13:17:16 +02:00
tagged_integer_test.cc
utils: tagged_integer: implement std::numeric_limits::{min,max}
2023-05-15 10:19:39 +03:00
token_metadata_test.cc
locator: erm: Make get_endpoints_for_reading() always return read replicas
2023-07-25 21:08:01 +02:00
top_k_test.cc
treewide: stop using 'using namespace std' in namespace scope
2023-04-17 14:08:37 +03:00
total_order_check.hh
move to_string.hh to utils/
2023-02-15 11:09:04 +02:00
tracing_test.cc
tracing: Pack testing code
2023-10-03 10:46:47 +03:00
transport_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
types_test.cc
Typos: fix typos in comments
2023-12-02 22:37:22 +02:00
user_function_test.cc
test: handle fast execution of test_user_function_filtering
2023-10-12 17:04:43 +03:00
user_types_test.cc
When add duration field to UDT check whether this UDT is used in some clustering key
2023-11-14 11:23:05 +02:00
utf8_test.cc
…
UUID_test.cc
treewide: do not use std::rel_ops
2023-04-26 14:09:58 +08:00
view_build_test.cc
tests: Make use of make_memtable() helper
2023-11-02 19:28:35 +03:00
view_complex_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
view_schema_ckey_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
view_schema_pkey_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
view_schema_test.cc
test: remove invalid IS NOT NULL restrictions from tests
2023-05-17 15:38:03 +02:00
vint_serialization_test.cc
…
virtual_reader_test.cc
test: Make cql_test_env::get_system_keyspace() return sharded
2023-03-06 13:17:21 +03:00
virtual_table_mutation_source_test.cc
tests: Make use of make_memtable() helper
2023-11-02 19:28:35 +03:00
virtual_table_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
wasm_alloc_test.cc
treewide: use #include <seastar/...> for seastar headers
2023-06-06 08:36:09 +03:00
wasm_test.cc
treewide: use #include <seastar/...> for seastar headers
2023-06-06 08:36:09 +03:00