Kefu Chai a3ac7c3d33 remove redundant std::move() from position_in_partition::key() ...

Fix GCC warning about moving from a const reference in mp_row_consumer_k_l::flush_if_needed.
Since position_in_partition::key() returns a const reference, std::move has no effect.

Considered adding an rvalue reference overload (clustering_key_prefix&& key() &&) but
since the "me" sstable format is mandatory since 63b266e9, this approach offers no benefit.

This change simply removes the redundant std::move() call to silence the warning and
improve code clarity.

Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>

Closes scylladb/scylladb#23085

2025-03-03 12:51:40 +03:00

..

kl

remove redundant std::move() from position_in_partition::key()

2025-03-03 12:51:40 +03:00

mx

treewide: Reduce db/config.hh header fanout

2025-02-25 15:16:40 +01:00

binary_search.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

checksum_utils.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

checksummed_data_source.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

checksummed_data_source.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

CMakeLists.txt

cmake/check_headers: correct typos

2024-10-08 09:38:16 +03:00

column_translation.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

component_type.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

compress.cc

compress: fix compressor initialization order by making namespace_prefix a function

2025-01-26 13:43:02 +02:00

compress.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

consumer.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

data_source_types.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

disk_types.hh

sstables: disk_types: disk_set_of_tagged_union: boost::variant -> std::variant

2025-01-27 09:29:26 -05:00

downsampling.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

exceptions.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

file_writer.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

filter.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

generation_type.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

hyperloglog.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

index_entry.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

index_reader.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

integrity_checked_file_impl.cc

sstables: switch from boost to std::ranges::all_of()

2025-02-10 15:44:55 +03:00

integrity_checked_file_impl.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

key.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

liveness_info.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

m_format_read_helpers.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

m_format_read_helpers.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

metadata_collector.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

metadata_collector.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

mutation_fragment_filter.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

open_info.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

partition_index_cache_stats.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

partition_index_cache.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

prepended_input_stream.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

prepended_input_stream.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

processing_result_generator.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

progress_monitor.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

promoted_index_blocks_reader.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

random_access_reader.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

random_access_reader.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

scanning_clustered_index_cursor.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

segmented_compress_params.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

shareable_components.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

shared_sstable.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

sstable_directory.cc

sstable_directory: Calculate prefixes outside of create_pending_deletion_log()

2025-02-19 13:09:04 +03:00

sstable_directory.hh

sstable_directory: Move sstable_directory::pending_delete_result

2025-02-19 13:09:04 +03:00

sstable_mutation_reader.cc

db,sstables: migate boost::range::stable_partition to std library

2024-12-19 14:56:07 +02:00

sstable_mutation_reader.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

sstable_set_impl.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

sstable_set.cc

sstables: explicitly call parent's default constructor in copy constructor

2025-02-28 13:52:24 +03:00

sstable_set.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

sstable_version_k_l.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

sstable_version_m.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

sstable_version.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

sstable_version.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

sstable_writer.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

sstables_manager.cc

sstables_manager: trigger reclaim/reload on components_memory_reclaim_threshold update

2025-02-17 20:55:45 +05:30

sstables_manager.hh

sstables_manager: maybe_reclaim_components: yield between iterations

2025-02-14 22:11:04 +05:30

sstables_registry.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

sstables.cc

sstables_manager: rename increment_total_reclaimable_memory_and_maybe_reclaim()

2025-02-14 22:11:04 +05:30

sstables.hh

sstable: Unfriend sstable_directory class

2025-02-19 13:09:04 +03:00

stats.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

storage.cc

sstable_directory: Move sstable_directory::pending_delete_result

2025-02-19 13:09:04 +03:00

storage.hh

sstable_directory: Move sstable_directory::pending_delete_result

2025-02-19 13:09:04 +03:00

types_fwd.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

types.hh

Introduce file stream for tablet

2025-01-26 12:51:59 +02:00

version.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

writer_impl.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

writer.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

writer.hh

sstables: writer.hh: drop unneeded boost depedencies

2025-02-24 13:26:44 +03:00