mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-05-02 22:25:48 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
93cf43ae4b64395b67cb0352cbb6f1cc4e242c6e
scylladb/test/boost
History
Avi Kivity 5f92f54f06 Merge 'utils: cached_file: Fix alloc-dealloc mismatch during eviction' from Tomasz Grabiec 
cached_page::on_evicted() is invoked in the LSA allocator context, set in the
reclaimer callback installed by the cache_tracker. However,
cached_pages are allocated in the standard allocator context (note:
page content is allocated inside LSA via lsa_buffer). The LSA region
will happily deallocate these, thinking that they these are large
objects which were delegated to the standard allocator. But the
_non_lsa_memory_in_use metric will underflow. When it underflows
enough, shard_segment_pool.total_memory() will become 0 and memory
reclamation will stop doing anything, leading to apparent OOM.

The fix is to switch to the standard allocator context inside
cached_page::on_evicted(). evict_range() was also given the same
treatment as a precaution, it currently is only invoked in the
standard allocator context.

The series also adds two safety checks to LSA to catch such problems earlier.

Fixes #10056

\cc @slivne @bhalevy

Closes #10130

* github.com:scylladb/scylla:
  lsa: Abort when trying to free a standard allocator object not allocated through the region
  lsa: Abort when _non_lsa_memory_in_use goes negative
  tests: utils: cached_file: Validate occupancy after eviction
  test: sstable_partition_index_cache_test: Fix alloc-dealloc mismatch
  utils: cached_file: Fix alloc-dealloc mismatch during eviction

(cherry picked from commit ff2cd72766)
2022-02-26 11:28:53 +02:00
..
aggregate_fcts_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
allocation_strategy_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
alternator_unit_test.cc
utils: untie rjson.hh from base64.hh
2021-10-05 12:57:54 +02:00
anchorless_list_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
auth_passwords_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
auth_resource_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
auth_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
batchlog_manager_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
big_decimal_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
bptree_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
broken_sstable_test.cc
test: Don't nest seastar::async calls (cont)
2021-09-06 08:26:09 +03:00
btree_test.cc
btree, test: Test exception safety and non-leakness of btree::clone_from
2021-08-31 12:23:49 +03:00
bytes_ostream_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
cache_flat_mutation_reader_test.cc
mutation_partition: Pin mutable access to range tombstones
2021-07-27 20:06:53 +03:00
cached_file_test.cc
Merge 'utils: cached_file: Fix alloc-dealloc mismatch during eviction' from Tomasz Grabiec
2022-02-26 11:28:53 +02:00
caching_options_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
canonical_mutation_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
cartesian_product_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
castas_fcts_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
cdc_generation_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
cdc_test.cc
cql3: deinline non-trivial methods in selection.hh
2021-10-05 12:58:55 +02:00
cell_locker_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
checksum_utils_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
chunked_managed_vector_test.cc
utils: lsa: chunked_managed_vector: Make LSA-aware
2021-07-02 19:02:14 +02:00
chunked_vector_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
clustering_ranges_walker_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
column_mapping_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
commitlog_test.cc
commitlog: Recalculate footprint on delete_segment exceptions
2021-11-29 14:56:48 +00:00
compound_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
compress_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
config_test.cc
config: experimental flag UNUSED_CDC shouldn't be distinct from UNUSED
2021-10-20 17:54:17 +03:00
continuous_data_consumer_test.cc
tests: add test for skipping bytes at end of consumer
2021-07-19 14:42:38 +02:00
counter_test.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
cql_auth_query_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
cql_auth_syntax_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
cql_functions_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
cql_query_group_test.cc
test: Use ALLOW FILTERING more strictly
2021-08-08 08:01:19 +02:00
cql_query_large_test.cc
compaction_manager: rename submit_major_compaction to perform_major_compaction
2021-11-04 09:54:00 -03:00
cql_query_like_test.cc
secondary_index_manager: stop including expression.hh
2021-08-22 21:21:46 +03:00
cql_query_test.cc
test: replace seastar::sprint() with fmt::format()
2021-10-27 17:02:00 +03:00
crc_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
data_listeners_test.cc
build: enable -Winconsistent-missing-override warning
2021-09-15 12:55:54 +03:00
database_test.cc
test: replace seastar::sprint() with fmt::format()
2021-10-27 17:02:00 +03:00
double_decker_test.cc
build, treewide: enable -Wpessimizing-move warning
2021-07-08 17:52:34 +03:00
duration_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
dynamic_bitset_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
enum_option_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
enum_set_test.cc
enum_set: add toggle()
2021-09-13 18:05:11 +03:00
error_injection_test.cc
secondary_index_manager: stop including expression.hh
2021-08-22 21:21:46 +03:00
estimated_histogram_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
extensions_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
filtering_test.cc
test: Use ALLOW FILTERING more strictly
2021-08-08 08:01:19 +02:00
flat_mutation_reader_test.cc
test: flat_mutation_reader_test: test_reverse_reader_is_mutation_source: prepare for reading in reverse
2021-09-29 12:15:48 +03:00
flush_queue_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
fragmented_temporary_buffer_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
frozen_mutation_test.cc
flat_mutation_reader: get rid of timeout parameter
2021-08-24 16:30:51 +03:00
gossip_test.cc
token_metadata, storage_service: unify token_metadata_lock and merge_lock.
2021-10-13 13:01:25 +03:00
gossiping_property_file_snitch_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
hash_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
hashers_test.cc
test: hashers_test: mutation_fragment_sanity_check: stop semaphore
2021-10-24 11:29:23 +03:00
hint_test.cc
hints: fill up missing shards with zeros in decoded sync points
2021-09-15 11:04:34 +02:00
idl_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
index_with_paging_test.cc
cql: Fix missing data in indexed queries with base table short reads
2021-11-23 11:22:00 +02:00
input_stream_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
intrusive_array_test.cc
tests: Return strong-ordering from tri-comparators
2021-06-07 21:41:08 +03:00
json_cql_query_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
json_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
keys_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
large_paging_state_test.cc
test: Use ALLOW FILTERING more strictly
2021-08-08 08:01:19 +02:00
like_matcher_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
limiting_data_source_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
linearizing_input_stream_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
loading_cache_test.cc
loading_shared_values/loading_cache: get rid of iterators interface and return value_ptr from find(...) instead
2021-08-22 16:49:40 +03:00
log_heap_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
logalloc_test.cc
everywhere: make deferred actions noexcept
2021-08-22 21:11:52 +03:00
managed_bytes_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
managed_vector_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
map_difference_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
memtable_test.cc
test: memtable: add full_compaction in background
2021-11-04 16:19:54 +01:00
multishard_combining_reader_as_mutation_source_test.cc
test: Split multishard combining reader case
2021-10-05 11:57:02 +03:00
multishard_mutation_query_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
murmur_hash_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
mutation_fragment_test.cc
reader_concurrency_semaphore: remove default parameter values from constructors
2021-09-14 12:20:28 +02:00
mutation_query_test.cc
querier: consume_page(): remove now unused max_size parameter
2021-09-29 12:15:48 +03:00
mutation_reader_test.cc
test: mutation_reader_test: reversed version of test_clustering_order_merger_sstable_set
2021-09-29 12:15:48 +03:00
mutation_test.cc
tests: mutation_test: Add test for position_in_partition::reversed()
2021-09-28 13:09:39 +02:00
mutation_writer_test.cc
test/boost: mutation_writer_test: harden the partition-based segregator test
2021-11-02 12:24:37 +02:00
mvcc_test.cc
tests: mvcc: Relax monotonicity check
2021-07-26 17:27:03 +02:00
network_topology_strategy_test.cc
abstract_replication_strategy: get rid of shared_token_metadata member and ctor param
2021-10-13 16:10:06 +03:00
nonwrapping_range_test.cc
test: change some internal comparators to std::strong_ordering
2021-07-28 13:28:51 +03:00
observable_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
partitioner_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
querier_cache_test.cc
querier: consume_page(): remove now unused max_size parameter
2021-09-29 12:15:48 +03:00
query_processor_test.cc
test: Use ALLOW FILTERING more strictly
2021-08-08 08:01:19 +02:00
radix_tree_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
range_assert.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
range_test.cc
test: change some internal comparators to std::strong_ordering
2021-07-28 13:28:51 +03:00
range_tombstone_list_assertions.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
range_tombstone_list_test.cc
Merge 'db: range_tombstone_list: Deoverlap empty range tombstones' from Tomasz Grabiec
2022-01-20 12:35:21 +02:00
reader_concurrency_semaphore_test.cc
test: reader_concurrency_semaphore_test: isolate from namespace of source_location
2021-10-10 18:17:53 +03:00
restrictions_test.cc
main: Replace cql_config_updater with updateable_value
2021-09-30 07:23:43 +03:00
reusable_buffer_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
role_manager_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
row_cache_test.cc
flat_mutation_reader: get rid of timeout parameter
2021-08-24 16:30:51 +03:00
schema_change_test.cc
schema: add get_reversed()
2021-09-22 18:55:25 +03:00
schema_changes_test.cc
test: Use now existing helpers elsewhere
2021-09-20 15:44:14 +03:00
schema_loader_test.cc
tools: add schema_loader
2021-09-07 15:47:22 +03:00
schema_registry_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
secondary_index_test.cc
test: Use ALLOW FILTERING more strictly
2021-08-08 08:01:19 +02:00
serialization_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
serialized_action_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
service_level_controller_test.cc
Service Level Controller: Add an extention point to the API (#9374)
2021-10-01 10:20:28 +03:00
small_vector_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
snitch_reset_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
sstable_3_x_test.cc
compaction_manager: simplify creation of compaction_data
2021-11-04 09:35:49 -03:00
sstable_compaction_test.cc
compaction_manager: simplify creation of compaction_data
2021-11-04 09:35:49 -03:00
sstable_conforms_to_mutation_source_test.cc
Merge 'treewide: improve compatibility with gcc 11' from Avi Kivity
2021-10-11 16:54:01 +03:00
sstable_datafile_test.cc
test: Generalize all make_sstable_easy()-s
2021-09-20 15:44:14 +03:00
sstable_directory_test.cc
distributed_loader: Fix methods visibility
2021-10-11 11:03:29 +03:00
sstable_move_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
sstable_mutation_test.cc
test: Use now existing helpers elsewhere
2021-09-20 15:44:14 +03:00
sstable_partition_index_cache_test.cc
Merge 'utils: cached_file: Fix alloc-dealloc mismatch during eviction' from Tomasz Grabiec
2022-02-26 11:28:53 +02:00
sstable_resharding_test.cc
compaction_manager: simplify creation of compaction_data
2021-11-04 09:35:49 -03:00
sstable_set_test.cc
test: Generalize all make_sstable_easy()-s
2021-09-20 15:44:14 +03:00
sstable_test.cc
flat_mutation_reader: get rid of timeout parameter
2021-08-24 16:30:51 +03:00
sstable_test.hh
table: Make correctness of concurrent sstable list update robust
2021-07-21 16:45:30 +03:00
stall_free_test.cc
utils: stall_free: implemnt clear_gently of froeign_ptr
2021-07-01 19:16:11 +03:00
statement_restrictions_test.cc
cql3: expr: Add data_type to *_constructor structs
2021-09-24 11:05:53 +02:00
storage_proxy_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
suite.yaml
tests: Move compaction-related tests into its own unit
2021-08-02 22:26:26 +03:00
test_table.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
top_k_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
total_order_check.hh
treewide: remove redundant "x <=> 0" compares
2021-07-28 13:30:32 +03:00
tracing.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
transport_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
types_test.cc
types: convert abstract_type::compare and related to std::strong_ordering
2021-07-28 13:19:24 +03:00
user_function_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
user_types_test.cc
cql3: expr: Implement evaluate(expr::bind_variable)
2021-09-24 11:05:53 +02:00
utf8_test.cc
test: utf8: add fragmented buffer validation tests
2020-10-21 11:14:44 +03:00
UUID_test.cc
utils: UUID_gen: introduce negate()
2021-09-09 11:49:05 +03:00
view_build_test.cc
reader_concurrency_semaphore: remove default parameter values from constructors
2021-09-14 12:20:28 +02:00
view_complex_test.cc
compaction_manager: rename submit_major_compaction to perform_major_compaction
2021-11-04 09:54:00 -03:00
view_schema_ckey_test.cc
test: replace seastar::sprint() with fmt::format()
2021-10-27 17:02:00 +03:00
view_schema_pkey_test.cc
test: replace seastar::sprint() with fmt::format()
2021-10-27 17:02:00 +03:00
view_schema_test.cc
test: replace seastar::sprint() with fmt::format()
2021-10-27 17:02:00 +03:00
vint_serialization_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
virtual_reader_test.cc
test: replace seastar::sprint() with fmt::format()
2021-10-27 17:02:00 +03:00
virtual_table_mutation_source_test.cc
flat_mutation_reader: get rid of timeout parameter
2021-08-24 16:30:51 +03:00
virtual_table_test.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00