In #16102, we added a test for concurrent bootstrap in the raft-based topology. This test was running in CI for some time and never failed. Now, we can believe that concurrent bootstrap is not bugged or at least the probability of a failure is very low. Therefore, we can safely make use of it in all tests using the raft-based topology. This PR: - makes all initial servers start concurrently in topology tests, - replaces all multiple `server_add` calls with a single `servers_add` call in tests using the raft-based topology, - removes no longer needed `test_concurrent_bootstrap`. The changes listed above: - make running tests a bit faster due to concurrent bootstraps, - make multiple tests test concurrent bootstrap previously tested by a single test. Fixes scylladb/scylladb#15423 Closes scylladb/scylladb#16384 * github.com:scylladb/scylladb: test: test_different_group0_ids: fix comments test: remove test_concurrent_bootstrap test: replace multiple server_add calls with servers_add test: ScyllaCluster: start all initial servers concurrently test: ManagerClient: servers_add: specify consistent-topology-changes assumption
Scylla in-source tests.
For details on how to run the tests, see docs/dev/testing.md
Shared C++ utils, libraries are in lib/, for Python - pylib/
alternator - Python tests which connect to a single server and use the DynamoDB API unit, boost, raft - unit tests in C++ cql-pytest - Python tests which connect to a single server and use CQL topology* - tests that set up clusters and add/remove nodes cql - approval tests that use CQL and pre-recorded output rest_api - tests for Scylla REST API Port 9000 scylla-gdb - tests for scylla-gdb.py helper script nodetool - tests for C++ implementation of nodetool
If you can use an existing folder, consider adding your test to it. New folders should be used for new large categories/subsystems, or when the test environment is significantly different from some existing suite, e.g. you plan to start scylladb with different configuration, and you intend to add many tests and would like them to reuse an existing Scylla cluster (clusters can be reused for tests within the same folder).
To add a new folder, create a new directory, and then
copy & edit its suite.ini.