mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-04-21 00:50:35 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
95bf8eebe003d692e4fdd8c751dda06e5af08ed2
scylladb/test/boost
History
Petr Gusev 95bf8eebe0 query_ranges_to_vnodes_generator: fix for exclusive boundaries 
Let the initial range passed to query_partition_key_range
be [1, 2) where 2 is the successor of 1 in terms
of ring_position order and 1 is equal to vnode.
Then query_ranges_to_vnodes_generator() -> [[1, 1], (1, 2)],
so we get an empty range (1,2) and subsequently will
make a data request with this empty range in
storage_proxy::query_partition_key_range_concurrent,
which will be redundant.

The patch adds a check for this condition after
making a split in the main loop in process_one_range.

The patch does not attempt to handle cases where the
original ranges were empty, since this check is the
responsibility of the caller. We only take care
not to add empty ranges to the result as an
unintentional artifact of the algorithm in
query_ranges_to_vnodes_generator.

A test case is added in test_get_restricted_ranges.
The helper lambda check is changed so that not to limit
the number of ranges to the length of expected
ranges, otherwise this check passes without
the change in process_one_range.

Fixes: #12566

Closes #12755
2023-02-07 16:02:31 +02:00
..
aggregate_fcts_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
allocation_strategy_test.cc
…
alternator_unit_test.cc
…
anchorless_list_test.cc
…
auth_passwords_test.cc
…
auth_resource_test.cc
…
auth_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
batchlog_manager_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
big_decimal_test.cc
…
bptree_test.cc
…
broken_sstable_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
btree_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
bytes_ostream_test.cc
…
cache_flat_mutation_reader_test.cc
Merge 'Keep range tombstones with rows in memtables and cache' from Tomasz Grabiec
2023-02-05 22:33:10 +02:00
cached_file_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
caching_options_test.cc
…
canonical_mutation_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
cartesian_product_test.cc
…
castas_fcts_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
cdc_generation_test.cc
…
cdc_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
cell_locker_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
checksum_utils_test.cc
…
chunked_managed_vector_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
chunked_vector_test.cc
…
clustering_ranges_walker_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
column_mapping_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
commitlog_test.cc
Merge 'test/lib: introduce key_utils.hh' from Botond Dénes
2023-02-06 18:11:32 +01:00
compound_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
compress_test.cc
…
config_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
continuous_data_consumer_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
counter_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
cql_auth_query_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
cql_auth_syntax_test.cc
…
cql_functions_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
cql_query_group_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
cql_query_large_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
cql_query_like_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
cql_query_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
crc_test.cc
…
data_listeners_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
database_test.cc
Merge 'test/lib: introduce key_utils.hh' from Botond Dénes
2023-02-06 18:11:32 +01:00
dirty_memory_manager_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
double_decker_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
duration_test.cc
…
dynamic_bitset_test.cc
…
enum_option_test.cc
…
enum_set_test.cc
…
error_injection_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
estimated_histogram_test.cc
…
exception_container_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
exceptions_fallback_test.cc
…
exceptions_optimized_test.cc
…
exceptions_test.inc.cc
…
expr_test.cc
test/expr_test: test <int_value> IN (123, ?, 456)
2023-02-01 16:29:32 +01:00
extensions_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
filtering_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
flat_mutation_reader_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
flush_queue_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
fragmented_temporary_buffer_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
frozen_mutation_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
gossiping_property_file_snitch_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
group0_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
hash_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
hashers_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
hint_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
idl_test.cc
…
index_with_paging_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
input_stream_test.cc
…
intrusive_array_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
json_cql_query_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
json_test.cc
…
keys_test.cc
…
large_paging_state_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
like_matcher_test.cc
…
limiting_data_source_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
linearizing_input_stream_test.cc
…
lister_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
loading_cache_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
log_heap_test.cc
…
logalloc_standard_allocator_segment_pool_backend_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
logalloc_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
managed_bytes_test.cc
…
managed_vector_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
map_difference_test.cc
…
memtable_test.cc
Merge 'test/lib: introduce key_utils.hh' from Botond Dénes
2023-02-06 18:11:32 +01:00
multishard_combining_reader_as_mutation_source_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
multishard_mutation_query_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
murmur_hash_test.cc
…
mutation_fragment_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
mutation_query_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
mutation_reader_test.cc
Merge 'test/lib: introduce key_utils.hh' from Botond Dénes
2023-02-06 18:11:32 +01:00
mutation_test.cc
Merge 'Add compaction module to task manager' from Aleksandra Martyniuk
2023-02-06 09:25:05 +02:00
mutation_writer_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
mvcc_test.cc
Merge 'Keep range tombstones with rows in memtables and cache' from Tomasz Grabiec
2023-02-05 22:33:10 +02:00
network_topology_strategy_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
nonwrapping_range_test.cc
…
observable_test.cc
…
partitioner_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
per_partition_rate_limit_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
querier_cache_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
query_processor_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
radix_tree_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
range_assert.hh
…
range_test.cc
…
range_tombstone_list_assertions.hh
…
range_tombstone_list_test.cc
position_in_partition: Make after_key() work with non-full keys
2022-12-14 14:47:33 +01:00
rate_limiter_test.cc
…
reader_concurrency_semaphore_test.cc
Merge 'test/lib: introduce key_utils.hh' from Botond Dénes
2023-02-06 18:11:32 +01:00
recent_entries_map_test.cc
utils: introduce recent_entries_map datatype to track least recent visited entries.
2023-02-03 19:04:32 +01:00
repair_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
restrictions_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
result_utils_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
reusable_buffer_test.cc
…
role_manager_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
row_cache_test.cc
Merge 'test/lib: introduce key_utils.hh' from Botond Dénes
2023-02-06 18:11:32 +01:00
rust_test.cc
…
schema_change_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
schema_changes_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
schema_loader_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
schema_registry_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
secondary_index_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
serialization_test.cc
…
serialized_action_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
service_level_controller_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
small_vector_test.cc
…
snitch_reset_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
sstable_3_x_test.cc
Merge 'Add compaction module to task manager' from Aleksandra Martyniuk
2023-02-06 09:25:05 +02:00
sstable_compaction_test.cc
Merge 'test/lib: introduce key_utils.hh' from Botond Dénes
2023-02-06 18:11:32 +01:00
sstable_conforms_to_mutation_source_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
sstable_datafile_test.cc
Merge 'test/lib: introduce key_utils.hh' from Botond Dénes
2023-02-06 18:11:32 +01:00
sstable_directory_test.cc
Merge 'test/lib: introduce key_utils.hh' from Botond Dénes
2023-02-06 18:11:32 +01:00
sstable_move_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
sstable_mutation_test.cc
Merge 'test/lib: introduce key_utils.hh' from Botond Dénes
2023-02-06 18:11:32 +01:00
sstable_partition_index_cache_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
sstable_resharding_test.cc
Merge 'test/lib: introduce key_utils.hh' from Botond Dénes
2023-02-06 18:11:32 +01:00
sstable_set_test.cc
Merge 'test/lib: introduce key_utils.hh' from Botond Dénes
2023-02-06 18:11:32 +01:00
sstable_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
sstable_test.hh
test: sstable_compaction_test: Make it work with compaction groups
2023-02-01 20:14:51 -03:00
stall_free_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
statement_restrictions_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
storage_proxy_test.cc
query_ranges_to_vnodes_generator: fix for exclusive boundaries
2023-02-07 16:02:31 +02:00
suite.yaml
test.py: Add option to run scylla tests with multiple compaction groups
2023-02-01 20:17:16 -03:00
summary_test.cc
…
test_table.cc
…
top_k_test.cc
…
total_order_check.hh
…
tracing_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
transport_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
types_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
user_function_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
user_types_test.cc
Merge 'Allow entire test suite to run with multiple compaction groups' from Raphael "Raph" Carvalho
2023-02-03 06:35:15 +02:00
utf8_test.cc
…
UUID_test.cc
…
view_build_test.cc
Merge 'test/lib: introduce key_utils.hh' from Botond Dénes
2023-02-06 18:11:32 +01:00
view_complex_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
view_schema_ckey_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
view_schema_pkey_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
view_schema_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
vint_serialization_test.cc
…
virtual_reader_test.cc
Merge 'Avoid qctx from view-builder methods of system_keyspace' from Pavel Emelyanov
2023-02-06 12:44:40 +02:00
virtual_table_mutation_source_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
virtual_table_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
wasm_alloc_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00
wasm_test.cc
test: Enable Scylla test command line options for boost tests
2023-02-01 20:14:51 -03:00