mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-28 20:27:03 +00:00
96abf80c5e
This test wants to make sure that an SSTable with generation number 4, which is incomplete, gets deleted. While that works today, the way the test verifies that is fragile because new SSTables can and will be created, especially in the local directory that sees a lot of activity on startup. It works if generations don't go that far, but with SMP, even a single SSTable in the right shard can end up having generation 4. In practice this isn't an issue today because the code calls cf.update_sstables_known_generation() as soon as it sees a file, before deciding whether or not the file has to be deleted. However this behavior is not guaranteed and is changing. The best way to fix this would be to check if the file is the same, including its inode. But given that this is just a unit test (which is almost always if not always single node), I am just moving to use the peers table instead. Again, we could have created a user table, but it's just not worth the hassle. Signed-off-by: Glauber Costa <glauber@scylladb.com>