Avi Kivity 0f59b17056 cql3: select_statement: don't copy metadata object needlessly ...

It's a shared_ptr<const metadata>, so it's safe to pass around.

perf-simple-query:

before:
211989.40 tps ( 62.1 allocs/op,  13.1 tasks/op,   43812 insns/op,        0 errors)
217889.09 tps ( 62.1 allocs/op,  13.1 tasks/op,   43713 insns/op,        0 errors)
211418.75 tps ( 62.1 allocs/op,  13.1 tasks/op,   43782 insns/op,        0 errors)
217388.46 tps ( 62.1 allocs/op,  13.1 tasks/op,   43733 insns/op,        0 errors)
211528.74 tps ( 62.1 allocs/op,  13.1 tasks/op,   43766 insns/op,        0 errors)

after:
215241.86 tps ( 61.1 allocs/op,  13.1 tasks/op,   43563 insns/op,        0 errors)
216172.41 tps ( 61.1 allocs/op,  13.1 tasks/op,   43562 insns/op,        0 errors)
212591.73 tps ( 61.1 allocs/op,  13.1 tasks/op,   43586 insns/op,        0 errors)
212217.28 tps ( 61.1 allocs/op,  13.1 tasks/op,   43553 insns/op,        0 errors)
215863.47 tps ( 61.1 allocs/op,  13.1 tasks/op,   43559 insns/op,        0 errors)

About 200 instructions saved.

Closes #14499

2023-07-04 16:41:51 +03:00

..

expr

cql3: expression: fix field_selection::type interpretation by evaluate()

2023-07-03 19:45:17 +03:00

functions

cql3: selection: drop selector_factories, selectables, and selectors

2023-07-03 19:45:17 +03:00

restrictions

cql3: expression: introduce temporaries

2023-07-03 19:45:17 +03:00

selection

cql3: selection: drop selector_factories, selectables, and selectors

2023-07-03 19:45:17 +03:00

statements

cql3: select_statement: don't copy metadata object needlessly

2023-07-04 16:41:51 +03:00

assignment_testable.hh

cql3: eliminate dynamic_cast<selector> from functions::get()

2023-06-13 21:04:49 +03:00

attributes.cc

cql3: expr: break up expression.hh header

2023-06-22 14:21:03 +03:00

attributes.hh

cql: USING TTL 0 means unlimited, not default TTL

2023-03-08 16:18:23 +02:00

authorized_prepared_statements_cache.hh

treewide: use defaulted operator!=() and operator==()

2023-04-27 10:24:46 +03:00

cf_name.cc

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

cf_name.hh

cql3: mark cf_name final

2023-02-28 22:26:43 +02:00

CMakeLists.txt

cql3: selection: drop selector_factories, selectables, and selectors

2023-07-03 19:45:17 +03:00

column_identifier.cc

cql3: selection: convert processes_selection to work on prepared expressions

2023-07-03 19:45:17 +03:00

column_identifier.hh

cql3: selection: convert processes_selection to work on prepared expressions

2023-07-03 19:45:17 +03:00

column_specification.cc

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

column_specification.hh

types: move types.{cc,hh} into types

2023-02-19 21:05:45 +02:00

constants.cc

cql3: expr: break up expression.hh header

2023-06-22 14:21:03 +03:00

constants.hh

cql3: constants: deinline

2023-06-22 14:19:43 +03:00

cql3_type.cc

Merge 'cql: enable setting permissions on resources with quoted UDT names' from Wojciech Mitros

2023-05-10 19:10:29 +03:00

cql3_type.hh

Merge 'Allow setting permissions for user-defined functions' from Wojciech Mitros

2023-03-12 14:04:34 +02:00

cql_config.hh

…

cql_statement.hh

cql3: remove empty statement::validate functions

2023-06-22 13:57:33 +03:00

Cql.g

cql3: selection: drop selector_factories, selectables, and selectors

2023-07-03 19:45:17 +03:00

error_collector.hh

cql3: fix spurious token names in syntax error messages

2023-05-02 11:23:58 +03:00

error_listener.hh

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

index_name.cc

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

index_name.hh

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

keyspace_element_name.cc

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

keyspace_element_name.hh

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

lists.cc

cql3: expr: break up expression.hh header

2023-06-22 14:21:03 +03:00

lists.hh

cql3: remove abstract_marker vestiges

2023-06-12 10:41:04 +03:00

maps.cc

cql3: expr: break up expression.hh header

2023-06-22 14:21:03 +03:00

maps.hh

cql3: remove abstract_marker vestiges

2023-06-12 10:41:04 +03:00

operation_impl.hh

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

operation.cc

cql3: expr: break up expression.hh header

2023-06-22 14:21:03 +03:00

operation.hh

cql3: deinline operation::fill_prepare_context()

2023-06-22 14:19:43 +03:00

prepare_context.cc

cql3: accept and type-check reused named bind variables

2022-06-17 09:09:49 +02:00

prepare_context.hh

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

prepared_statements_cache.hh

treewide: use defaulted operator!=() and operator==()

2023-04-27 10:24:46 +03:00

query_options_fwd.hh

…

query_options.cc

cql/query_options: add a check for missing bind marker name

2023-02-04 02:13:34 +02:00

query_options.hh

cql3, transport, tests: remove "unset" from value type system

2023-01-16 21:10:56 +02:00

query_processor.cc

query_processor: get rid of internal_state and create individual query_satate for each request

2023-06-22 15:26:20 +03:00

query_processor.hh

query_processor: get rid of internal_state and create individual query_satate for each request

2023-06-22 15:26:20 +03:00

result_generator.hh

cql3: result_set: switch cell data type from bytes_opt to managed_bytes_opt

2023-05-07 17:17:36 +03:00

result_set.cc

cql3: result_set: switch cell data type from bytes_opt to managed_bytes_opt

2023-05-07 17:17:36 +03:00

result_set.hh

cql3: result_set: switch cell data type from bytes_opt to managed_bytes_opt

2023-05-07 17:17:36 +03:00

role_name.cc

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

role_name.hh

treewide: remove empty comments in top-of-files

2022-05-13 07:11:58 +02:00

role_options.hh

…

sets.cc

cql3: expr: break up expression.hh header

2023-06-22 14:21:03 +03:00

sets.hh

cql3: remove abstract_marker vestiges

2023-06-12 10:41:04 +03:00

stats.hh

cql3/stats: use zero-initialization

2023-04-28 16:59:29 +08:00

type_json.cc

test: relax NULL check test predicate

2023-01-18 10:38:24 +02:00

type_json.hh

types: move types.{cc,hh} into types

2023-02-19 21:05:45 +02:00

untyped_result_set.cc

cql3: untyped_result_set: switch to managed_bytes_view as the cell type

2023-05-07 17:17:36 +03:00

untyped_result_set.hh

cql3: untyped_result_set: document performance characteristics

2023-05-10 15:03:12 +03:00

update_parameters.cc

cql3: expr: break up expression.hh header

2023-06-22 14:21:03 +03:00

update_parameters.hh

cql: USING TTL 0 means unlimited, not default TTL

2023-03-08 16:18:23 +02:00

user_types.cc

cql3: expr: break up expression.hh header

2023-06-22 14:21:03 +03:00

user_types.hh

cql3: remove abstract_marker vestiges

2023-06-12 10:41:04 +03:00

ut_name.cc

cql: maybe quote user type name in ut_name::to_string()

2023-03-23 01:41:58 +01:00

ut_name.hh

cql: maybe quote user type name in ut_name::to_string()

2023-03-23 01:41:58 +01:00

util.cc

cql3: expr: break up expression.hh header

2023-06-22 14:21:03 +03:00

util.hh

cql: allow disabling of USING TIMESTAMP sanity checking

2023-01-16 23:18:56 +02:00

values.cc

cql3, transport, tests: remove "unset" from value type system

2023-01-16 21:10:56 +02:00

values.hh

types: move types.{cc,hh} into types

2023-02-19 21:05:45 +02:00