scylladb

mirror of https://github.com/scylladb/scylladb.git synced 2026-06-04 14:03:06 +00:00

Files

Piotr Dulikowski 63a47117d7 service_level_controller: more permissive computation of effective SLs

In order to calculate an effective service level, parameters of all
roles reachable in the role grants graph need to be considered (or,
equivalently, the effective service levels of the direct children need
to be considered). The current logic performs a topological sort on the
role grants graph in order to compute effective service levels of all
roles efficiently. The role grants graph should, in theory, always be
acyclic - the GRANT statement refuses to proceed if it sees that it
would create a cycle.

However, in pre-group0 auth acyclicity is only best-effort because of
the lack of linearizability of auth statements. Moreover, data can
become out of shape due to other reasons such as lack of repair or
manual edits. Our current topological sort algorithm does not handle
these well.

Change the algorithm to a DFS with memoization. Unlike topological sort,
this algorithm gracefully handles algorithms with cycles - while the
computed effective service levels might not be entirely correct in such
case, the algorithm detects and reports those by logging a warning with
an example of a cycle.

In addition to the algorithm change, two test cases are added: one with
an example of a cyclic roles graph, and the other with an example of a
graph with edges leading to roles which do not exist. The new algorithm
handles both gracefully.

Fixes: SCYLLADB-2328

Closes scylladb/scylladb#30170

2026-06-03 17:04:12 +03:00

auth_cluster

service_level_controller: more permissive computation of effective SLs

2026-06-03 17:04:12 +03:00

dtest

test: enforce skip_bug(link, reason) and migrate call sites

2026-06-01 18:30:55 +02:00

lwt

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test/cluster/mv/tablet: Improve determinism and runtime in test_mv_tablets_replace

2026-06-02 17:59:30 +02:00

object_store

Merge 'sstables: fix stream sink write failure with S3-backed storage' from Ernest Zaslavsky

2026-06-03 10:21:32 +03:00

random_failures

test: Annotate server_stop() calls where conviction is beneficial

2026-05-21 21:31:22 +02:00

storage

test: Annotate server_stop() calls where conviction is useless

2026-05-21 21:13:55 +02:00

tasks

tasks: fix busy-spin and shutdown hang in tablet_virtual_task::wait() for repair tasks

2026-05-22 16:47:48 +03:00

__init__.py

…

conftest.py

test: parametrize encrypted streaming test with storage backends

2026-06-02 12:26:44 +03:00

test_aggregation.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_alternator_proxy_protocol.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_alternator.py

test: Annotate server_stop() calls where conviction is beneficial

2026-05-21 21:31:22 +02:00

test_audit.py

Merge 'test: audit: pin empty-keyspace DDL audit behavior' from Andrzej Jackowski

2026-05-22 09:42:34 +02:00

test_automatic_cleanup.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_bad_initial_token.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_batchlog_manager.py

test: Annotate server_stop() calls where conviction is beneficial

2026-05-21 21:31:22 +02:00

test_blocked_bootstrap.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_boot_nodes.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_bootstrap_with_quick_group0_join.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_bti_index.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_cdc_generation_clearing.py

error_injection: Convert handler-style breakpoints to wait_for_message sugar

2026-05-26 15:01:01 +03:00

test_cdc_generation_data.py

error_injection: Convert handler-style breakpoints to wait_for_message sugar

2026-05-26 15:01:01 +03:00

test_cdc_generation_publishing.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_cdc_with_alter.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_cdc_with_tablets.py

test: test_cdc_with_tablets: add read barrier

2026-06-01 13:56:01 +02:00

test_change_ip.py

test: Annotate server_stop() calls where conviction is useless

2026-05-21 21:13:55 +02:00

test_change_replication_factor_1_to_0.py

test: enforce skip_bug(link, reason) and migrate call sites

2026-06-01 18:30:55 +02:00

test_change_rpc_address.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_client_routes.py

test: Annotate server_stop() calls where conviction is beneficial

2026-05-21 21:31:22 +02:00

test_cluster_features.py

test: enforce skip_bug(link, reason) and migrate call sites

2026-06-01 18:30:55 +02:00

test_commitlog_segment_data_resurrection.py

test_...data_resurrection: Add test case for repair CL truncation

2026-05-26 14:02:20 +02:00

test_commitlog.py

test: Annotate server_stop() calls where conviction is useless

2026-05-21 21:13:55 +02:00

test_compaction_backpressure.py

test/cluster: add pylib-style nodetool.py

2026-06-01 13:03:29 +03:00

test_concurrent_schema.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_config_live_updates.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_config.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_config.yaml

test: remove dead suite subclasses and legacy execution pipeline

2026-05-17 22:16:31 +03:00

test_conflicting_keys_read_repair.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_coordinator_queue_management.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_counter_write_timeout_metric.py

LICENSE: Update to version 1.1

2026-04-12 19:46:33 +03:00

test_counters_with_tablets.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_crash_coordinator_before_streaming.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_create_table_during_node_shutdown.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_data_resurrection_after_cleanup.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_data_resurrection_in_memtable.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_decommission_kill_then_replace.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_decommission.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_deprecating_cluster_features.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_describe.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_different_group0_ids.py

test: Annotate server_stop() calls where conviction is useless

2026-05-21 21:13:55 +02:00

test_encryption.py

test: parametrize encrypted streaming test with storage backends

2026-06-02 12:26:44 +03:00

test_ensure_committed_by_group0.py

schema: ensure committed_by_group0 is set for all non-system tables on boot

2026-05-21 10:22:07 +02:00

test_error_becoming_voter.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_failure_after_group0_server_registration.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_fencing.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_global_ignore_nodes.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_gossiper_empty_self_id_on_shadow_round.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_gossiper_orphan_remover.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_gossiper_race.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_gossiper.py

test: gossiper: Add test for natural failure detection

2026-05-21 21:33:24 +02:00

test_group0_recovers_after_partial_command_application.py

test: Annotate server_stop() calls where conviction is useless

2026-05-21 21:13:55 +02:00

test_guardrails.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_hints.py

test/cluster: add pylib-style nodetool.py

2026-06-01 13:03:29 +03:00

test_incremental_repair.py

test: enforce skip_bug(link, reason) and migrate call sites

2026-06-01 18:30:55 +02:00

test_initial_token.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_internode_compression.py

test/cluster: fix proxy resource leak in internode compression test

2026-05-29 13:51:43 +03:00

test_ip_mappings.py

test: Annotate server_stop() calls where conviction is useless

2026-05-21 21:13:55 +02:00

test_keyspace_rf.py

tests: avoid CQL_ALTERNATOR_QUERIED on zero-token nodes

2026-05-25 14:22:04 +03:00

test_large_partition_guardrail.py

test/cluster: add large data guardrails rolling upgrade test

2026-05-29 12:51:31 +02:00

test_left_node_notification.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_logstor.py

logstor: disable logstor compaction in table truncate

2026-05-24 10:25:08 +02:00

test_long_join.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_long_query_timeout_erm.py

test: Annotate server_stop() calls where conviction is beneficial

2026-05-21 21:31:22 +02:00

test_lwt_semaphore.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_maintenance_mode.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_major_compaction.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_metadata_id.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_multidc.py

test/cluster: add pylib-style nodetool.py

2026-06-01 13:03:29 +03:00

test_mutation_schema_change.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_mv.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_no_dc_rack_change.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_no_removed_node_event_on_ip_change.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_node_isolation.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_node_ops_metrics.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_node_shutdown_waits_for_pending_requests.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_nodetool.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_not_enough_token_owners.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_prepare_race.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_proxy_protocol.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_query_rebounce.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_raft_cluster_features.py

test: Annotate server_stop() calls where conviction is useless

2026-05-21 21:13:55 +02:00

test_raft_ignore_nodes.py

test: Annotate server_stop() calls where conviction is beneficial

2026-05-21 21:31:22 +02:00

test_raft_no_quorum.py

test: Annotate server_stop() calls where conviction is useless

2026-05-21 21:13:55 +02:00

test_raft_recovery_during_join.py

test: Annotate server_stop() calls where conviction is useless

2026-05-21 21:13:55 +02:00

test_raft_recovery_entry_loss.py

test: Annotate server_stop() calls where conviction is harmful

2026-05-21 21:33:19 +02:00

test_raft_recovery_user_data.py

test: Annotate server_stop() calls where conviction is useless

2026-05-21 21:13:55 +02:00

test_raft_snapshot_request.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_raft_snapshot_truncation.py

test: fix flaky test_raft_snapshot_truncation by waiting for async log truncation

2026-05-21 10:50:00 +03:00

test_raft_voters.py

test: Annotate server_stop() calls where conviction is harmful

2026-05-21 21:33:19 +02:00

test_random_tables.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_read_repair.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_refresh.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_remove_alive_node.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_remove_rpc_client_with_pending_requests.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_repair.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_replace_alive_node.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_replace_with_encryption.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_replace_with_same_ip_twice.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_replace.py

test: Annotate server_stop() calls where conviction is beneficial

2026-05-21 21:31:22 +02:00

test_replica_exceptions.py

LICENSE: Update to version 1.1

2026-04-12 19:46:33 +03:00

test_rest_api_on_startup.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_restart_cluster.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_resurrection.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_reversed_queries_during_simulated_upgrade_process.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_rpc_compression.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_select_from_mutation_fragments.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_shutdown_hang.py

test: Annotate server_stop() calls where conviction is beneficial

2026-05-21 21:31:22 +02:00

test_size_based_load_balancing.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_snapshot_with_tablets.py

test/cluster: add pylib-style nodetool.py

2026-06-01 13:03:29 +03:00

test_snapshot.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_sstable_cleanup_stop.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_sstable_compression_config.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_sstable_compression_dictionaries_autotrain.py

LICENSE: Update to version 1.1

2026-04-12 19:46:33 +03:00

test_sstable_compression_dictionaries_basic.py

test_sstable_compression_dictionaries: fix the test when running on more than one NUMA node

2026-06-01 19:41:19 +02:00

test_sstable_compression_dictionaries_upgrade.py

test: update get_scylla_2025_1_executable() to use 2025.1.12

2026-05-12 23:20:55 +02:00

test_sstable_set.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_start_bootstrapped_with_invalid_seed.py

test: enforce skip_bug(link, reason) and migrate call sites

2026-06-01 18:30:55 +02:00

test_stop_before_starting_compaction_manager.py

test: add test_stop_before_starting_compaction_manager

2026-05-22 11:58:37 +02:00

test_streaming_deadlock.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_strong_consistency.py

Merge 'Enforce strict skip_bug signature with link/reason validation and CI checks' from Artsiom Mishuta

2026-06-02 14:12:48 +02:00

test_table_desc_read_barrier.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_table_drop.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_tablet_repair_scheduler.py

test: enforce skip_bug(link, reason) and migrate call sites

2026-06-01 18:30:55 +02:00

test_tablet_stats.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_tablets2.py

repair, test: fix split-repair synchronization test timeout in debug mode

2026-05-22 15:03:47 +03:00

test_tablets_colocation.py

test: Annotate server_stop() calls where conviction is useless

2026-05-21 21:13:55 +02:00

test_tablets_cql.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_tablets_intranode.py

test: Annotate server_stop() calls where conviction is useless

2026-05-21 21:13:55 +02:00

test_tablets_lwt.py

error_injection: Convert handler-style breakpoints to wait_for_message sugar

2026-05-26 15:01:01 +03:00

test_tablets_merge.py

test: Annotate server_stop() calls where conviction is useless

2026-05-21 21:13:55 +02:00

test_tablets_migration.py

error_injection: Convert handler-style breakpoints to wait_for_message sugar

2026-05-26 15:01:01 +03:00

test_tablets_parallel_decommission.py

error_injection: Convert handler-style breakpoints to wait_for_message sugar

2026-05-26 15:01:01 +03:00

test_tablets_removenode.py

test: Annotate server_stop() calls where conviction is beneficial

2026-05-21 21:31:22 +02:00

test_tablets.py

test/cluster/test_tablets: increase timeout for test_multi_rf_of_many_keyspaces_0_N

2026-06-01 20:07:03 +03:00

test_tls.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_tombstone_gc.py

test: Annotate server_stop() calls where conviction is beneficial

2026-05-21 21:31:22 +02:00

test_tools_perf.py

test/cluster: remove now-redundant expected_server_up_state=SERVING

2026-05-05 18:56:37 +03:00

test_topology_failure_recovery.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_topology_ops_encrypted.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_topology_ops_with_rf_rack_valid.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_topology_ops.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_topology_rejoin.py

test: Annotate server_stop() calls where conviction is beneficial

2026-05-21 21:31:22 +02:00

test_topology_remove_decom.py

test: enforce skip_bug(link, reason) and migrate call sites

2026-06-01 18:30:55 +02:00

test_topology_schema.py

test: Annotate server_stop() calls where conviction is beneficial

2026-05-21 21:31:22 +02:00

test_topology_smp.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_truncate_concurrent_writes.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_truncate_with_drop.py

test: Annotate server_stop() calls where conviction is useless

2026-05-21 21:13:55 +02:00

test_truncate_with_tablets.py

error_injection: Convert handler-style breakpoints to wait_for_message sugar

2026-05-26 15:01:01 +03:00

test_ttl_row.py

test: wait for TTL scheduling sanity metric

2026-05-12 12:38:25 +03:00

test_unfinished_writes_during_shutdown.py

Merge 'storage_service: cancel write handlers during drain to prevent shutdown deadlock' from Petr Gusev

2026-05-21 15:43:36 +02:00

test_uninitialized_conns_semaphore.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_vector_store.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_view_build_status.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_view_building_coordinator.py

Merge 'db/view/view_building_coordinator: add flag to mark if any remote work was finished' from Michał Jadwiszczak

2026-05-21 15:11:58 +02:00

test_vnodes_to_tablets_migration.py

test: Order task-wait before finalization in test_migration_wait_task

2026-05-26 10:43:22 +03:00

test_write_query_during_cql_server_shutdown.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_writes_to_previous_cdc_generations.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_zero_token_nodes_multidc.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_zero_token_nodes_no_replication.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

test_zero_token_nodes_topology_ops.py

test.py: remove redundant pytest.mark.asyncio decorators

2026-05-21 10:36:47 +03:00

util.py

test: fix flaky test_kill_coordinator_during_op

2026-04-30 21:27:56 +03:00