scylladb

mirror of https://github.com/scylladb/scylladb.git synced 2026-04-21 00:50:35 +00:00

Files

Nadav Har'El 506b366e5d alternator: fix "/localnodes" to not return down nodes

Alternator's "/localnodes" HTTP requests is supposed to return the list
of nodes in the local DC to which the user can send requests.

Before commit bac7c33313 we used the
gossiper is_alive() method to determine if a node should be returned.
That commit changed the check to is_normal() - because a node can be
alive but in non-normal (e.g., joining) state and not ready for
requests.

However, it turns out that checking is_normal() is not enough, because
if node is stopped abruptly, other nodes will still consider it "normal",
but down (this is so-called "DN" state). So we need to check **both**
is_alive() and is_normal().

This patch also adds a test reproducing this case, where a node is
shut down abruptly. Before this patch, the test failed ("/localnodes"
continued to return the dead node), and after it it passes.

Fixes #21538

Signed-off-by: Nadav Har'El <nyh@scylladb.com>

Closes scylladb/scylladb#21540

(cherry picked from commit 7607f5e33e)

Closes scylladb/scylladb#21633

2024-11-21 08:50:44 +02:00

auth.cc

alternator: do not allow authentication with a non-"login" role

2024-07-25 12:45:27 +03:00

auth.hh

alternator: add support for auth-v2

2024-03-01 16:25:14 +01:00

CMakeLists.txt

build: bring abseil submodule back

2024-05-05 23:31:09 +03:00

conditions.cc

alternator: not include unused headers