Marcin Maliszkiewicz a425385233 Merge 'utils: loading_cache: add insert() that is a no-op when caching is disabled' from Dario Mirovic ...

When `permissions_validity_in_ms` is set to 0, executing a prepared statement under authentication crashes with:
```
    Assertion `caching_enabled()' failed.
        at utils/loading_cache.hh:319
        in authorized_prepared_statements_cache::insert
```

`loading_cache::get_ptr()` asserts when caching is disabled (expiry == 0), but `authorized_prepared_statements_cache::insert()` was using it purely for its side effect of populating the cache, which is meaningless when caching is off.

Add a new `loading_cache::insert(k, load)` method that is a no-op when caching is disabled and otherwise forwards to `get_ptr()`. Switch `authorized_prepared_statements_cache::insert()` to use it. This
completes the disabled-mode safety contract of the cache for the write side, mirroring the fallback that `get()` already provides for the read side.

Includes a regression test in `test/boost/loading_cache_test.cc` plus a positive test for the new `insert()` overload.

Fixes SCYLLADB-1699

The crash is introduced a long time ago. It is present on all the live versions, from 2025.1 onward. No client tickets, but it should be backported.

Closes scylladb/scylladb#29638

* github.com:scylladb/scylladb:
  test: boost: regression test for loading_cache::insert with caching disabled
  utils: loading_cache: add insert() that is a no-op when caching is disabled

(cherry picked from commit c00fee0316)

Closes scylladb/scylladb#29762

Closes scylladb/scylladb#29782

Closes scylladb/scylladb#29790

Closes scylladb/scylladb#29803

2026-05-11 15:14:36 +02:00

..

abi

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

arch/powerpc/crc32-vpmsum

…

gz

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

lsa

utils/lsa/chunked_managed_vector: fix the calculation of max_chunk_capacity()

2025-06-03 21:11:52 +03:00

s3

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

advanced_rpc_compressor_protocol.hh

utils: add advanced_rpc_compressor

2024-12-23 23:37:02 +01:00

advanced_rpc_compressor.cc

utils: add advanced_rpc_compressor

2024-12-23 23:37:02 +01:00

advanced_rpc_compressor.hh

utils: add advanced_rpc_compressor

2024-12-23 23:37:02 +01:00

alien_worker.cc

Revert "Merge 'auth: move passwords::check call to alien thread' from Andrzej Jackowski"

2025-10-09 11:04:34 +03:00

alien_worker.hh

Revert "Merge 'auth: move passwords::check call to alien thread' from Andrzej Jackowski"

2025-10-09 11:04:34 +03:00

allocation_strategy.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

amortized_reserve.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

anchorless_list.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

array-search.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

array-search.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

ascii.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

ascii.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

assert.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

atomic_vector.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

aws_sigv4.cc

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

aws_sigv4.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

base64.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

base64.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

big_decimal.cc

utils/big_decimal: fix scale overflow when parsing values with large exponents

2025-07-02 11:34:38 +03:00

big_decimal.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

bit_cast.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

bloom_calculations.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

bloom_calculations.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

bloom_filter.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

bloom_filter.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

bounded_stats_deque.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

bptree.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

buffer_input_stream.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

buffer_input_stream.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

buffer_view-to-managed_bytes_view.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

build_id.cc

treewide: change assert() to SCYLLA_ASSERT()

2024-08-05 08:23:35 +03:00

build_id.hh

…

cached_file_stats.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

cached_file.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

chunked_vector.hh

utils: chunked_vector: add swap() method

2025-08-27 14:24:35 +03:00

class_registrator.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

clmul.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

CMakeLists.txt

utils::http::dns_connection_factory: Use a shared certificate_credentials

2025-07-22 11:02:59 +03:00

coarse_steady_clock.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

collection-concepts.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

compact-radix-tree.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

composite_abort_source.hh

treewide: change assert() to SCYLLA_ASSERT()

2024-08-05 08:23:35 +03:00

config_file_impl.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

config_file.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

config_file.hh

utils: do not include unused headers

2025-01-17 11:24:54 +03:00

contiguous_shared_buffer.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

coroutine.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

crc.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

cross-shard-barrier.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

data_input.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

date.h

date: do not put space before literal operator

2024-10-21 11:21:52 +03:00

dict_trainer.cc

utils/dict_trainer: silence an ERROR log when raft is aborted during dict publication

2025-01-08 17:55:05 +01:00

dict_trainer.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

digest_algorithm.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

digester.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

directories.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

directories.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

disk_space_monitor.cc

Merge 'tablets: Make load balancing capacity-aware' from Tomasz Grabiec

2025-03-25 23:16:35 +01:00

disk_space_monitor.hh

Merge 'tablets: Make load balancing capacity-aware' from Tomasz Grabiec

2025-03-25 23:16:35 +01:00

disk-error-handler.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

disk-error-handler.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

div_ceil.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

double-decker.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

dynamic_bitset.cc

treewide: migrate from boost::adaptors::reversed to std::views::reverse

2025-01-07 13:22:00 +02:00

dynamic_bitset.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

entangled.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

enum_option.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

error_injection.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

error_injection.hh

utils: error_injection: allow aborting wait_for_message

2026-01-13 17:14:19 +01:00

estimated_histogram.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

exception_container.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

exceptions.cc

utils/exceptions.cc: Added check for exceptions::request_timeout_exception in is_timeout_exception function.

2025-07-02 11:30:26 +03:00

exceptions.hh

exceptions: Add try_catch_nested to universally handle nested exceptions of the same type.

2025-03-27 21:28:12 +00:00

exponential_backoff_retry.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

extremum_tracking.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

file_lock.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

file_lock.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

flush_queue.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

fragment_range.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

fragmented_temporary_buffer.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

from_chars_exactly.hh

utils: introduce from_chars_exactly()

2025-01-09 11:14:49 +02:00

hash.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

hashers.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

hashers.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

hashing.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

histogram_metrics_helper.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

histogram_metrics_helper.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

histogram.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

http.cc

utils::http::dns_connection_factory: Use a shared certificate_credentials

2025-07-22 11:02:59 +03:00

http.hh

utils::http::dns_connection_factory: Use a shared certificate_credentials

2025-07-22 11:02:59 +03:00

human_readable.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

human_readable.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

i_filter.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

i_filter.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

immutable-collection.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

input_stream.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

int_range.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

intrusive_btree.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

intrusive-array.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

io-wrappers.cc

utils: Add "io-wrappers", useful IO helper types

2025-04-15 10:36:47 +00:00

io-wrappers.hh

utils: Add "io-wrappers", useful IO helper types

2025-04-15 10:36:47 +00:00

large_bitset.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

large_bitset.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

latency.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

lexicographical_compare.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

like_matcher.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

like_matcher.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

limiting_data_source.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

limiting_data_source.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

linearizing_input_stream.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

lister.cc

lister: Fix race between readdir and stat

2025-11-24 17:19:42 +03:00

lister.hh

lister: Fix race between readdir and stat

2025-11-24 17:19:42 +03:00

loading_cache.hh

Merge 'utils: loading_cache: add insert() that is a no-op when caching is disabled' from Dario Mirovic

2026-05-11 15:14:36 +02:00

loading_shared_values.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

log_heap.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

log.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

logalloc.cc

utils/lsa/chunked_managed_vector: fix the calculation of max_chunk_capacity()

2025-06-03 21:11:52 +03:00

logalloc.hh

utils/lsa/chunked_managed_vector: fix the calculation of max_chunk_capacity()

2025-06-03 21:11:52 +03:00

lru.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

managed_bytes.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

managed_bytes.hh

managed_bytes: in the copy constructor, respect the target preferred allocation size

2025-04-18 07:55:46 +00:00

managed_ref.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

managed_vector.hh

utils/lsa/chunked_managed_vector: fix the calculation of max_chunk_capacity()

2025-06-03 21:11:52 +03:00

maybe_yield.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

memory_data_sink.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

memory_limit_reached.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

multiprecision_int.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

multiprecision_int.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

murmur_hash.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

murmur_hash.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

mutable_view.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

neat-object-id.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

observable.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

on_internal_error.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

on_internal_error.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

only_on_shard0.hh

Merge 'tablets: Make load balancing capacity-aware' from Tomasz Grabiec

2025-03-25 23:16:35 +01:00

overloaded_functor.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

phased_barrier.hh

utils: phased_barrier: add close() method

2024-12-26 06:54:07 +02:00

preempt.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

pretty_printers.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

pretty_printers.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

rate_limiter.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

rate_limiter.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

recent_entries_map.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

refcounted.hh

utils: add advanced_rpc_compressor

2024-12-23 23:37:02 +01:00

reservoir_sampling.hh

utils: introduce reservoir_sampling

2024-12-23 23:37:02 +01:00

result_combinators.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

result_loop.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

result_try.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

result.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

reusable_buffer.hh

utils/reusable_buffer: accept non-throwing writer callbacks via result_with_exception

2025-07-30 21:57:15 +02:00

rjson.cc

alternator: avoid oversized allocation in Query/Scan

2025-08-27 10:26:00 +03:00

rjson.hh

alternator: avoid oversized allocation in Query/Scan

2025-08-27 10:26:00 +03:00

rpc_utils.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

runtime.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

runtime.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

sequenced_set.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

sequential_producer.hh

Introduce LDAP role manager & saslauthd authenticator

2025-01-12 14:50:29 +02:00

serialization.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

serialized_action.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

shared_dict.hh

utils: add advanced_rpc_compressor

2024-12-23 23:37:02 +01:00

simple_hashers.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

small_vector.hh

utils: small_vector: expose internal_capacity()

2024-12-24 12:19:20 +02:00

sorting.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

stall_free.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

stream_compressor.cc

utils/stream_compressor: allocate memory for zstd compressors externally

2025-06-13 14:44:04 +03:00

stream_compressor.hh

utils/stream_compressor: allocate memory for zstd compressors externally

2025-06-13 14:44:04 +03:00

streaming_histogram.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

tagged_integer.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

throttle.hh

treewide: change assert() to SCYLLA_ASSERT()

2024-08-05 08:23:35 +03:00

to_string.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

to_string.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

top_k.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

tuple_utils.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

unconst.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

unique_view.hh

utils: implement drop-in replacement for replacing boost::adaptors::uniqued

2025-01-21 16:24:45 +08:00

updateable_value.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

updateable_value.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

user_provided_param.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

utf8.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

utf8.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

UUID_gen.cc

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

UUID_gen.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

uuid.cc

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

UUID.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00

value_or_reference.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

variant_element.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

vle.hh

treewide: relicense to ScyllaDB-Source-Available-1.0

2024-12-18 17:45:13 +02:00

xx_hasher.hh

utils: do not include unused headers

2025-01-14 07:56:39 -05:00