mirror of
https://github.com/scylladb/scylladb.git
synced 2026-06-07 15:33:15 +00:00
in in {fmt} before v10, it provides the specialization of `fmt::formatter<..>`
for `std::string_view` as well as the specialization of `fmt::formatter<..>`
for `fmt::string_view` which is an implementation builtin in {fmt} for
compatibility of pre-C++17. and this type is used even if the code is
compiled with C++ stadandard greater or equal to C++17. also, before v10,
the `fmt::formatter<std::string_view>::format()` is defined so it accepts
`std::string_view`. after v10, `fmt::formatter<std::string_view>` still
exists, but it is now defined using `format_as()` machinery, so it's
`format()` method does not actually accept `std::string_view`, it
accepts `fmt::string_view`, as the former can be converted to
`fmt::string_view`.
this is why we can inherit from `fmt::formatter<std::string_view>` and
use `formatter<std::string_view>::format(foo, ctx);` to implement the
`format()` method with {fmt} v9, but we cannot do this with {fmt} v10,
and we would have following compilation failure:
```
FAILED: service/CMakeFiles/service.dir/RelWithDebInfo/topology_state_machine.cc.o
/home/kefu/.local/bin/clang++ -DFMT_DEPRECATED_OSTREAM -DFMT_SHARED -DSCYLLA_BUILD_MODE=release -DSEASTAR_API_LEVEL=7 -DSEASTAR_LOGGER_COMPILE_TIME_FMT -DSEASTAR_LOGGER_TYPE_STDOUT -DSEASTAR_SCHEDULING_GROUPS_COUNT=16 -DSEASTAR_SSTRING -DXXH_PRIVATE_API -DCMAKE_INTDIR=\"RelWithDebInfo\" -I/home/kefu/dev/scylladb -I/home/kefu/dev/scylladb/build/gen -I/home/kefu/dev/scylladb/seastar/include -I/home/kefu/dev/scylladb/build/seastar/gen/include -I/home/kefu/dev/scylladb/build/seastar/gen/src -ffunction-sections -fdata-sections -O3 -g -gz -std=gnu++20 -fvisibility=hidden -Wall -Werror -Wextra -Wno-error=deprecated-declarations -Wimplicit-fallthrough -Wno-c++11-narrowing -Wno-deprecated-copy -Wno-mismatched-tags -Wno-missing-field-initializers -Wno-overloaded-virtual -Wno-unsupported-friend -Wno-enum-constexpr-conversion -Wno-unused-parameter -ffile-prefix-map=/home/kefu/dev/scylladb=. -march=westmere -mllvm -inline-threshold=2500 -fno-slp-vectorize -U_FORTIFY_SOURCE -Werror=unused-result -MD -MT service/CMakeFiles/service.dir/RelWithDebInfo/topology_state_machine.cc.o -MF service/CMakeFiles/service.dir/RelWithDebInfo/topology_state_machine.cc.o.d -o service/CMakeFiles/service.dir/RelWithDebInfo/topology_state_machine.cc.o -c /home/kefu/dev/scylladb/service/topology_state_machine.cc
/home/kefu/dev/scylladb/service/topology_state_machine.cc:254:41: error: no matching member function for call to 'format'
254 | return formatter<std::string_view>::format(it->second, ctx);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
/usr/include/fmt/core.h:2759:22: note: candidate function template not viable: no known conversion from 'seastar::basic_sstring<char, unsigned int, 15>' to 'const fmt::basic_string_view<char>' for 1st argument
2759 | FMT_CONSTEXPR auto format(const T& val, FormatContext& ctx) const
| ^ ~~~~~~~~~~~~
```
because the inherited `format()` method actually comes from
`fmt::formatter<fmt::string_view>`. to reduce the confusion, in this
change, we just inherit from `fmt::format<string_view>`, where
`string_view` is actually `fmt::string_view`. this follows
the document at
https://fmt.dev/latest/api.html#formatting-user-defined-types,
and since there is less indirection under the hood -- we do not
use the specialization created by `FMT_FORMAT_AS` which inherit
from `formatter<fmt::string_view>`, hopefully this can improve
the compilation speed a little bit. also, this change addresses
the build failure with {fmt} v10.
Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>
Closes scylladb/scylladb#18299
147 lines
4.1 KiB
C++
147 lines
4.1 KiB
C++
/*
|
|
* Copyright (C) 2015-present ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: AGPL-3.0-or-later
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <seastar/core/sstring.hh>
|
|
#include <ranges>
|
|
#include <vector>
|
|
#include <sstream>
|
|
#include <unordered_set>
|
|
#include <set>
|
|
#include <optional>
|
|
#include <list>
|
|
#include <map>
|
|
#include <array>
|
|
#include <deque>
|
|
|
|
#include <fmt/format.h>
|
|
#include <fmt/ostream.h>
|
|
|
|
#include "seastarx.hh"
|
|
|
|
#include <boost/range/adaptor/transformed.hpp>
|
|
|
|
namespace utils {
|
|
|
|
template <std::ranges::range Range>
|
|
std::ostream& format_range(std::ostream& os, const Range& items, std::string_view paren = "{}") {
|
|
fmt::print(os, "{}{}{}", paren.front(), fmt::join(items, ", "), paren.back());
|
|
return os;
|
|
}
|
|
|
|
namespace internal {
|
|
|
|
template<bool NeedsComma, typename Printable>
|
|
struct print_with_comma {
|
|
const Printable& v;
|
|
};
|
|
|
|
template<bool NeedsComma, typename Printable>
|
|
std::ostream& operator<<(std::ostream& os, const print_with_comma<NeedsComma, Printable>& x) {
|
|
os << x.v;
|
|
if (NeedsComma) {
|
|
os << ", ";
|
|
}
|
|
return os;
|
|
}
|
|
|
|
} // namespace internal
|
|
} // namespace utils
|
|
|
|
namespace std {
|
|
|
|
template <typename K, typename V>
|
|
std::ostream& operator<<(std::ostream& os, const std::pair<K, V>& p) {
|
|
os << "{" << p.first << ", " << p.second << "}";
|
|
return os;
|
|
}
|
|
|
|
template<typename... T, size_t... I>
|
|
std::ostream& print_tuple(std::ostream& os, const std::tuple<T...>& p, std::index_sequence<I...>) {
|
|
return ((os << "{" ) << ... << utils::internal::print_with_comma<I < sizeof...(I) - 1, T>{std::get<I>(p)}) << "}";
|
|
}
|
|
|
|
template <typename... T>
|
|
std::ostream& operator<<(std::ostream& os, const std::tuple<T...>& p) {
|
|
return print_tuple(os, p, std::make_index_sequence<sizeof...(T)>());
|
|
}
|
|
|
|
// Vector-like ranges
|
|
template <std::ranges::range Range>
|
|
requires (
|
|
std::same_as<Range, std::vector<std::ranges::range_value_t<Range>>>
|
|
|| std::same_as<Range, std::list<std::ranges::range_value_t<Range>>>
|
|
|| std::same_as<Range, std::initializer_list<std::ranges::range_value_t<Range>>>
|
|
|| std::same_as<Range, std::deque<std::ranges::range_value_t<Range>>>
|
|
)
|
|
std::ostream& operator<<(std::ostream& os, const Range& items) {
|
|
return utils::format_range(os, items);
|
|
}
|
|
|
|
template <typename T, typename... Args>
|
|
std::ostream& operator<<(std::ostream& os, const std::set<T, Args...>& items) {
|
|
return utils::format_range(os, items);
|
|
}
|
|
|
|
template <typename T, typename... Args>
|
|
std::ostream& operator<<(std::ostream& os, const std::unordered_set<T, Args...>& items) {
|
|
return utils::format_range(os, items);
|
|
}
|
|
|
|
template <typename K, typename V, typename... Args>
|
|
std::ostream& operator<<(std::ostream& os, const std::map<K, V, Args...>& items) {
|
|
return utils::format_range(os, items);
|
|
}
|
|
|
|
template <typename... Args>
|
|
std::ostream& operator<<(std::ostream& os, const boost::transformed_range<Args...>& items) {
|
|
return utils::format_range(os, items);
|
|
}
|
|
|
|
template <typename T, std::size_t N>
|
|
std::ostream& operator<<(std::ostream& os, const std::array<T, N>& items) {
|
|
return utils::format_range(os, items, "[]");
|
|
}
|
|
|
|
template <typename T>
|
|
std::ostream& operator<<(std::ostream& os, const std::optional<T>& opt) {
|
|
if (opt) {
|
|
os << "{" << *opt << "}";
|
|
} else {
|
|
os << "{}";
|
|
}
|
|
return os;
|
|
}
|
|
|
|
} // namespace std
|
|
|
|
template<typename T>
|
|
struct fmt::formatter<std::optional<T>> : fmt::formatter<string_view> {
|
|
template <typename FormatContext>
|
|
auto format(const std::optional<T>& opt, FormatContext& ctx) const {
|
|
if (opt) {
|
|
return fmt::format_to(ctx.out(), "{}", *opt);
|
|
} else {
|
|
return fmt::format_to(ctx.out(), "{{}}");
|
|
}
|
|
}
|
|
};
|
|
|
|
template <> struct fmt::formatter<std::strong_ordering> : fmt::formatter<string_view> {
|
|
auto format(std::strong_ordering, fmt::format_context& ctx) const -> decltype(ctx.out());
|
|
};
|
|
|
|
template <> struct fmt::formatter<std::weak_ordering> : fmt::formatter<string_view> {
|
|
auto format(std::weak_ordering, fmt::format_context& ctx) const -> decltype(ctx.out());
|
|
};
|
|
|
|
template <> struct fmt::formatter<std::partial_ordering> : fmt::formatter<string_view> {
|
|
auto format(std::partial_ordering, fmt::format_context& ctx) const -> decltype(ctx.out());
|
|
};
|