mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-23 01:50:35 +00:00
00b9640b2c
"Currently new nodes calculate digests based on v3 schema mutations,
which are very different from v2 mutations. As a result they will
use schemas with different table_schema_version that the old nodes.
The old nodes will not recognize the version and will try to request
its definition. That will fail, because old nodes don't understand
v3 schema mutations.
To fix this problem, let's preserve the digests during migration,
so that they're the same on new and old nodes. This will allow
requests to proceed as usual.
This does not solve the problem of schema being changed during
the rolling upgrade. This is not allowed, as it would bring the
same problem back.
Fixes #2549."
* tag 'tgrabiec/use-consistent-schema-table-digests-v2' of github.com:cloudius-systems/seastar-dev:
tests: Add test for concurrent column addition
legacy_schema_migrator: Set digest to one compatible with the old nodes
schema_tables: Persist table_schema_version
schema_tables: Introduce system_schema.scylla_tables
schema_tables: Simplify read_table_mutations()
schema_tables: Resurrect v2 read_table_mutations()
system_keyspace: Forward-declare legacy schemas
legacy_schema_migrator: Take storage_proxy as dependency
(cherry picked from commit a397889c81)
103 lines
3.9 KiB
C++
103 lines
3.9 KiB
C++
/*
|
|
* Copyright 2015 ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* This file is part of Scylla.
|
|
*
|
|
* Scylla is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* Scylla is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with Scylla. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "schema_mutations.hh"
|
|
#include "canonical_mutation.hh"
|
|
#include "db/schema_tables.hh"
|
|
#include "md5_hasher.hh"
|
|
|
|
schema_mutations::schema_mutations(canonical_mutation columnfamilies,
|
|
canonical_mutation columns,
|
|
bool is_view,
|
|
stdx::optional<canonical_mutation> indices,
|
|
stdx::optional<canonical_mutation> dropped_columns,
|
|
stdx::optional<canonical_mutation> scylla_tables)
|
|
: _columnfamilies(columnfamilies.to_mutation(is_view ? db::schema_tables::views() : db::schema_tables::tables()))
|
|
, _columns(columns.to_mutation(db::schema_tables::columns()))
|
|
, _indices(indices ? stdx::optional<mutation>{indices.value().to_mutation(db::schema_tables::indexes())} : stdx::nullopt)
|
|
, _dropped_columns(dropped_columns ? stdx::optional<mutation>{dropped_columns.value().to_mutation(db::schema_tables::dropped_columns())} : stdx::nullopt)
|
|
, _scylla_tables(scylla_tables ? stdx::optional<mutation>{scylla_tables.value().to_mutation(db::schema_tables::scylla_tables())} : stdx::nullopt)
|
|
{}
|
|
|
|
void schema_mutations::copy_to(std::vector<mutation>& dst) const {
|
|
dst.push_back(_columnfamilies);
|
|
dst.push_back(_columns);
|
|
if (_indices) {
|
|
dst.push_back(_indices.value());
|
|
}
|
|
if (_dropped_columns) {
|
|
dst.push_back(_dropped_columns.value());
|
|
}
|
|
if (_scylla_tables) {
|
|
dst.push_back(_scylla_tables.value());
|
|
}
|
|
}
|
|
|
|
table_schema_version schema_mutations::digest() const {
|
|
if (_scylla_tables) {
|
|
auto rs = query::result_set(*_scylla_tables);
|
|
if (!rs.empty()) {
|
|
auto&& row = rs.row(0);
|
|
if (row.has("version")) {
|
|
auto val = row.get<utils::UUID>("version");
|
|
if (val) {
|
|
return *val;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
md5_hasher h;
|
|
db::schema_tables::feed_hash_for_schema_digest(h, _columnfamilies);
|
|
db::schema_tables::feed_hash_for_schema_digest(h, _columns);
|
|
if (_indices && !_indices.value().partition().empty()) {
|
|
db::schema_tables::feed_hash_for_schema_digest(h, _indices.value());
|
|
}
|
|
if (_dropped_columns && !_dropped_columns.value().partition().empty()) {
|
|
db::schema_tables::feed_hash_for_schema_digest(h, _dropped_columns.value());
|
|
}
|
|
if (_scylla_tables) {
|
|
db::schema_tables::feed_hash_for_schema_digest(h, _scylla_tables.value());
|
|
}
|
|
return utils::UUID_gen::get_name_UUID(h.finalize());
|
|
}
|
|
|
|
bool schema_mutations::operator==(const schema_mutations& other) const {
|
|
return _columnfamilies == other._columnfamilies
|
|
&& _columns == other._columns
|
|
&& _indices == other._indices
|
|
&& _dropped_columns == other._dropped_columns
|
|
&& _scylla_tables == other._scylla_tables
|
|
;
|
|
}
|
|
|
|
bool schema_mutations::operator!=(const schema_mutations& other) const {
|
|
return !(*this == other);
|
|
}
|
|
|
|
bool schema_mutations::live() const {
|
|
return _columnfamilies.live_row_count() > 0 || _columns.live_row_count() > 0;
|
|
}
|
|
|
|
bool schema_mutations::is_view() const {
|
|
return _columnfamilies.schema() == db::schema_tables::views();
|
|
}
|