cryptopp's config.h has the following pragma: #pragma GCC diagnostic ignored "-Wunused-function" It is not wrapped in a push/pop. Because of that, including cryptopp headers disables that warning on scylla code too. The issue has been reported as https://github.com/weidai11/cryptopp/issues/793 To work around it, this patch uses a pimpl to have a single .cc file that has to include cryptopp headers. While at it, it also reduces the differences and code duplication between the md5 and sha1 hashers. Signed-off-by: Rafael Ávila de Espíndola <espindola@scylladb.com>
51 lines
1.4 KiB
C++
51 lines
1.4 KiB
C++
/*
|
|
* Copyright (C) 2019 ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* This file is part of Scylla.
|
|
*
|
|
* Scylla is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* Scylla is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with Scylla. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "bytes.hh"
|
|
|
|
class md5_hasher;
|
|
|
|
template <typename T, size_t size> class hasher {
|
|
struct impl;
|
|
std::unique_ptr<impl> _impl;
|
|
|
|
public:
|
|
hasher();
|
|
~hasher();
|
|
hasher(hasher&&) noexcept;
|
|
hasher(const hasher&);
|
|
hasher& operator=(hasher&&) noexcept;
|
|
hasher& operator=(const hasher&);
|
|
|
|
bytes finalize();
|
|
std::array<uint8_t, size> finalize_array();
|
|
void update(const char* ptr, size_t length);
|
|
|
|
// Use update and finalize to compute the hash over the full view.
|
|
static bytes calculate(const std::string_view& s);
|
|
};
|
|
|
|
class md5_hasher : public hasher<md5_hasher, 16> {};
|
|
|
|
class sha256_hasher : public hasher<sha256_hasher, 32> {};
|