mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-28 12:17:02 +00:00
2ed29e31db
In particular, `inet_address(const sstring& addr)` is dangerous, since a function like `topology::get_datacenter(inet_address ep)` might accidentally convert a `sstring` argument into an `inet_address` (which would most likely throw an obscure std::invalid_argument if the datacenter name does not look like an inet_address). Signed-off-by: Benny Halevy <bhalevy@scylladb.com> Closes scylladb/scylladb#17260
95 lines
2.5 KiB
C++
95 lines
2.5 KiB
C++
/*
|
|
* Copyright (C) 2015-present ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: AGPL-3.0-or-later
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <fmt/ostream.h>
|
|
|
|
#include <seastar/net/ipv4_address.hh>
|
|
#include <seastar/net/inet_address.hh>
|
|
#include <seastar/net/socket_defs.hh>
|
|
#include <iosfwd>
|
|
#include <optional>
|
|
#include <functional>
|
|
|
|
#include "bytes.hh"
|
|
|
|
namespace gms {
|
|
|
|
class inet_address {
|
|
private:
|
|
net::inet_address _addr;
|
|
public:
|
|
inet_address() = default;
|
|
explicit inet_address(int32_t ip) noexcept
|
|
: inet_address(uint32_t(ip)) {
|
|
}
|
|
explicit inet_address(uint32_t ip) noexcept
|
|
: _addr(net::ipv4_address(ip)) {
|
|
}
|
|
inet_address(const net::inet_address& addr) noexcept : _addr(addr) {}
|
|
inet_address(const socket_address& sa) noexcept
|
|
: inet_address(sa.addr())
|
|
{}
|
|
const net::inet_address& addr() const noexcept {
|
|
return _addr;
|
|
}
|
|
|
|
inet_address(const inet_address&) = default;
|
|
|
|
operator const seastar::net::inet_address&() const noexcept {
|
|
return _addr;
|
|
}
|
|
|
|
// throws std::invalid_argument if sstring is invalid
|
|
explicit inet_address(const sstring& addr) {
|
|
// FIXME: We need a real DNS resolver
|
|
if (addr == "localhost") {
|
|
_addr = net::ipv4_address("127.0.0.1");
|
|
} else {
|
|
_addr = net::inet_address(addr);
|
|
}
|
|
}
|
|
bytes_view bytes() const noexcept {
|
|
return bytes_view(reinterpret_cast<const int8_t*>(_addr.data()), _addr.size());
|
|
}
|
|
// TODO remove
|
|
uint32_t raw_addr() const {
|
|
return addr().as_ipv4_address().ip;
|
|
}
|
|
sstring to_sstring() const;
|
|
friend inline bool operator==(const inet_address& x, const inet_address& y) noexcept = default;
|
|
friend inline bool operator<(const inet_address& x, const inet_address& y) noexcept {
|
|
return x.bytes() < y.bytes();
|
|
}
|
|
friend struct std::hash<inet_address>;
|
|
|
|
using opt_family = std::optional<net::inet_address::family>;
|
|
|
|
static future<inet_address> lookup(sstring, opt_family family = {}, opt_family preferred = {});
|
|
};
|
|
|
|
std::ostream& operator<<(std::ostream& os, const inet_address& x);
|
|
|
|
}
|
|
|
|
namespace std {
|
|
template<>
|
|
struct hash<gms::inet_address> {
|
|
size_t operator()(gms::inet_address a) const noexcept { return std::hash<net::inet_address>()(a._addr); }
|
|
};
|
|
}
|
|
|
|
template <>
|
|
struct fmt::formatter<gms::inet_address> : fmt::formatter<std::string_view> {
|
|
template <typename FormatContext>
|
|
auto format(const ::gms::inet_address& x, FormatContext& ctx) const {
|
|
return fmt::format_to(ctx.out(), "{}", x.addr());
|
|
}
|
|
};
|