mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-25 19:10:42 +00:00
ad46daa6aa
When we create a column family, we can pass as an extra parameter, the commitlog - or lack thereof. Because the commitlog is optional to begin with - it won't exist if we don't call init_commitlog, we can have this to be empty meaning no commit log. The creation of a column family should be always done through add_column_family. And if that is the case, we have the database's commitlog right there and can get the pointer through the db. Only tests are not creating the column family this way, and for them, it is fine. We want to do that, because some column family operations will use the commit log. Right now, they are forcing us to add parameters to APIs that would be much cleaner without it. So while separation is good, this level of coupling is a net win as it allows us to clean up some visible APIs. Signed-off-by: Glauber Costa <glommer@cloudius-systems.com>