mirror of
https://github.com/scylladb/scylladb.git
synced 2026-05-28 18:50:53 +00:00
4d302dfa1a
There are several places that (still) use throwing b-tree .insert_before() method and don't manage the inserted object lifetime. Some of those places also leave the leaked rows_entry on the LRU delaying the assertion failure by the time those entries get evicted (#9728) To prevent such surprises in the future, the set removes the non-safe inserters from the B-tree code. Actually most of this set is that removal plus preparations for reviewability. * xemul/br-rows-insertion-exception-safety-2: btree: Earnestly discourage from insertion of plain references row-cache: Handle exception (un)safety of rows_entry insertion partition_snapshot_row_cursor: Shuffle ensure_result creation mutation_partition: Use B-tree insertion sugar tests: Make B-tree tests use unique-ptrs for insertion