mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-04-21 00:50:35 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
b165f1e88ba6370e0a8cab052d889d51cb39a2c6
scylladb/cql3/statements
History
Kamil Braun 3d58e8e424 Revert "cql3: Extend the scope of group0_guard during DDL statement execution" 
This reverts commit c42a91ec72.

A significant performance regression was observed due to this change.

From Avi:
> perf-simple-query --smp 1
>
> before:
>
> 216489.88 tps ( 61.1 allocs/op, 13.1 tasks/op, 43558 insns/op, 0 errors)
> 217708.69 tps ( 61.1 allocs/op, 13.1 tasks/op, 43542 insns/op, 0 errors)
> 219495.02 tps ( 61.1 allocs/op, 13.1 tasks/op, 43538 insns/op, 0 errors)
> 216863.84 tps ( 61.1 allocs/op, 13.1 tasks/op, 43567 insns/op, 0 errors)
> 218936.48 tps ( 61.1 allocs/op, 13.1 tasks/op, 43546 insns/op, 0 errors)
>
> after:
>
> 201773.52 tps ( 63.1 allocs/op, 15.1 tasks/op, 44600 insns/op, 0 errors)
> 210875.48 tps ( 63.1 allocs/op, 15.1 tasks/op, 44558 insns/op, 0 errors)
> 210186.55 tps ( 63.1 allocs/op, 15.1 tasks/op, 44588 insns/op, 0 errors)
> 211021.76 tps ( 63.1 allocs/op, 15.1 tasks/op, 44569 insns/op, 0 errors)
> 208597.52 tps ( 63.1 allocs/op, 15.1 tasks/op, 44587 insns/op, 0 errors)
>
> Two extra allocations, two extra tasks, 1k extra instructions, for
> something that is DDL only.

Fixes #14590
2023-07-10 13:20:49 +02:00
..
raw
cql3: select_statement: use prepared selectors
2023-07-03 19:45:17 +03:00
alter_keyspace_statement.cc
client_state: drop unneeded argument from has.*access functions
2023-06-22 13:57:36 +03:00
alter_keyspace_statement.hh
cql3: statements: pass migration_manager& explicitly to prepare_schema_mutations
2023-06-15 09:48:54 +02:00
alter_role_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
alter_service_level_statement.cc
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
alter_service_level_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
alter_table_statement.cc
cql3: move validation::validate_column_family from client_state::has_column_family_access
2023-06-22 13:57:36 +03:00
alter_table_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
alter_type_statement.cc
client_state: drop unneeded argument from has.*access functions
2023-06-22 13:57:36 +03:00
alter_type_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
alter_view_statement.cc
cql3: move validation::validate_column_family from client_state::has_column_family_access
2023-06-22 13:57:36 +03:00
alter_view_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
attach_service_level_statement.cc
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
attach_service_level_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
authentication_statement.cc
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
authentication_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
authorization_statement.cc
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
authorization_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
batch_statement.cc
treewide: use fmt::join() when appropriate
2023-03-16 20:34:18 +08:00
batch_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
bound.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
cas_request.cc
statements/cas_request: fix crash on empty clustering range in LWT
2023-06-28 10:18:06 +02:00
cas_request.hh
cql3: update_parameters: use evaluation_inputs compatible row prefetch
2023-02-12 17:25:41 +02:00
cf_prop_defs.cc
cql: validate bloom_filter_fp_chance up-front
2022-09-20 06:18:51 +03:00
cf_prop_defs.hh
Introduce schema/ module
2023-02-15 11:01:50 +02:00
cf_properties.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
cf_statement.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
create_aggregate_statement.cc
cql3: Specify arguments types in UDA creation errors
2023-06-28 15:27:49 +03:00
create_aggregate_statement.hh
cql3: statements: pass migration_manager& explicitly to prepare_schema_mutations
2023-06-15 09:48:54 +02:00
create_function_statement.cc
cql3: statements: pass migration_manager& explicitly to prepare_schema_mutations
2023-06-15 09:48:54 +02:00
create_function_statement.hh
cql3: statements: pass migration_manager& explicitly to prepare_schema_mutations
2023-06-15 09:48:54 +02:00
create_index_statement.cc
cql3: move validation::validate_column_family from client_state::has_column_family_access
2023-06-22 13:57:36 +03:00
create_index_statement.hh
cql3: statements: pass migration_manager& explicitly to prepare_schema_mutations
2023-06-15 09:48:54 +02:00
create_keyspace_statement.cc
cql3: statements: pass migration_manager& explicitly to prepare_schema_mutations
2023-06-15 09:48:54 +02:00
create_keyspace_statement.hh
cql3: statements: pass migration_manager& explicitly to prepare_schema_mutations
2023-06-15 09:48:54 +02:00
create_role_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
create_service_level_statement.cc
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
create_service_level_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
create_table_statement.cc
client_state: drop unneeded argument from has.*access functions
2023-06-22 13:57:36 +03:00
create_table_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
create_type_statement.cc
client_state: drop unneeded argument from has.*access functions
2023-06-22 13:57:36 +03:00
create_type_statement.hh
cql3: statements: pass migration_manager& explicitly to prepare_schema_mutations
2023-06-15 09:48:54 +02:00
create_view_statement.cc
cql3: selection: drop selector_factories, selectables, and selectors
2023-07-03 19:45:17 +03:00
create_view_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
delete_statement.cc
cql3: expr: break up expression.hh header
2023-06-22 14:21:03 +03:00
delete_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
describe_statement.cc
Merge 'query processor code cleanup' from Gleb
2023-06-23 10:32:57 +02:00
describe_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
detach_service_level_statement.cc
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
detach_service_level_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
drop_aggregate_statement.cc
cql3: statements: pass migration_manager& explicitly to prepare_schema_mutations
2023-06-15 09:48:54 +02:00
drop_aggregate_statement.hh
cql3: statements: pass migration_manager& explicitly to prepare_schema_mutations
2023-06-15 09:48:54 +02:00
drop_function_statement.cc
cql3: statements: pass migration_manager& explicitly to prepare_schema_mutations
2023-06-15 09:48:54 +02:00
drop_function_statement.hh
cql3: statements: pass migration_manager& explicitly to prepare_schema_mutations
2023-06-15 09:48:54 +02:00
drop_index_statement.cc
cql3: move validation::validate_column_family from client_state::has_column_family_access
2023-06-22 13:57:36 +03:00
drop_index_statement.hh
cql3: statements: pass migration_manager& explicitly to prepare_schema_mutations
2023-06-15 09:48:54 +02:00
drop_keyspace_statement.cc
client_state: drop unneeded argument from has.*access functions
2023-06-22 13:57:36 +03:00
drop_keyspace_statement.hh
cql3: statements: pass migration_manager& explicitly to prepare_schema_mutations
2023-06-15 09:48:54 +02:00
drop_role_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
drop_service_level_statement.cc
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
drop_service_level_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
drop_table_statement.cc
cql3: move validation::validate_column_family from client_state::has_column_family_access
2023-06-22 13:57:36 +03:00
drop_table_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
drop_type_statement.cc
client_state: drop unneeded argument from has.*access functions
2023-06-22 13:57:36 +03:00
drop_type_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
drop_view_statement.cc
cql3: move validation::validate_column_family from client_state::has_column_family_access
2023-06-22 13:57:36 +03:00
drop_view_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
function_statement.cc
client_state: drop unneeded argument from has.*access functions
2023-06-22 13:57:36 +03:00
function_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
grant_role_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
grant_statement.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
grant_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
index_prop_defs.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
index_prop_defs.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
index_target.cc
cql3: s/std::regex/boost::regex/
2023-04-06 09:50:32 -04:00
index_target.hh
cql3: s/std::regex/boost::regex/
2023-04-06 09:50:32 -04:00
ks_prop_defs.cc
ks_prop_defs: disallow empty replication factor string in NTS
2023-05-22 17:56:16 +02:00
ks_prop_defs.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
list_permissions_statement.cc
Merge 'Allow setting permissions for user-defined functions' from Wojciech Mitros
2023-03-12 14:04:34 +02:00
list_permissions_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
list_roles_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
list_service_level_attachments_statement.cc
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
list_service_level_attachments_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
list_service_level_statement.cc
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
list_service_level_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
list_users_statement.cc
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
list_users_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
modification_statement.cc
modification_statement: reject conditional statements with empty clustering key
2023-06-28 10:30:52 +02:00
modification_statement.hh
cql: USING TTL 0 means unlimited, not default TTL
2023-03-08 16:18:23 +02:00
permission_altering_statement.cc
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
permission_altering_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
prepared_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
property_definitions.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
property_definitions.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
prune_materialized_view_statement.cc
treewide: drop cql_serialization_format
2023-01-03 19:54:13 +02:00
prune_materialized_view_statement.hh
cql3: add a statement for deleting ghost rows
2022-05-19 10:11:50 +02:00
request_validations.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
revoke_role_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
revoke_statement.cc
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
revoke_statement.hh
treewide: remove empty comments in top-of-files
2022-05-13 07:11:58 +02:00
role-management-statements.cc
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
schema_altering_statement.cc
Revert "cql3: Extend the scope of group0_guard during DDL statement execution"
2023-07-10 13:20:49 +02:00
schema_altering_statement.hh
Revert "cql3: Extend the scope of group0_guard during DDL statement execution"
2023-07-10 13:20:49 +02:00
select_statement.cc
cql3: select_statement: don't copy metadata object needlessly
2023-07-04 16:41:51 +03:00
select_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
service_level_statement.cc
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
service_level_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
sl_prop_defs.cc
cql3: fix misleading error message for service level timeouts
2022-03-31 07:04:00 +03:00
sl_prop_defs.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
statement_type.hh
treewide: use defaulted operator!=() and operator==()
2023-04-27 10:24:46 +03:00
strongly_consistent_modification_statement.cc
Merge 'query processor code cleanup' from Gleb
2023-06-23 10:32:57 +02:00
strongly_consistent_modification_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
strongly_consistent_select_statement.cc
Merge 'query processor code cleanup' from Gleb
2023-06-23 10:32:57 +02:00
strongly_consistent_select_statement.hh
raft: broadcast_tables: add support for bind variables
2022-09-28 09:54:59 +03:00
truncate_statement.cc
cql3: move validation::validate_column_family from client_state::has_column_family_access
2023-06-22 13:57:36 +03:00
truncate_statement.hh
cql3/statements/truncate_statement: remove defaulted move ctor
2023-02-19 12:57:40 +08:00
update_statement.cc
cql3: expr: break up expression.hh header
2023-06-22 14:21:03 +03:00
update_statement.hh
raft: broadcast_tables: add compilation of cql to intermediate language
2022-09-08 15:25:36 +02:00
use_statement.cc
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00
use_statement.hh
cql3: remove empty statement::validate functions
2023-06-22 13:57:33 +03:00