b7afda5030
When `mx::make_reader` is used to construct an sstable reader, it constructs its own index reader internally. `mx::make_reader_with_index_reader` was originally added as a variant of `mx::make_reader` which can be used to inject a custom `index_reader` for testing that the mx Data reader tolerates inexact indexes. But now we want the ability to choose between BIG index readers and BTI index readers if both are present. And at this point, it seems to me that it makes sense to just construct the index reader in the caller and pass it via argument to `mx::make_reader` instead of putting the index selection inside it. So that's what we do in this patch. And we remove `mx::make_reader_with_index_reader` because it's no longer different from `mx::make_reader`.
72 lines
2.3 KiB
C++
72 lines
2.3 KiB
C++
/*
|
|
* Copyright (C) 2021-present ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: LicenseRef-ScyllaDB-Source-Available-1.0
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "readers/mutation_reader_fwd.hh"
|
|
#include "readers/mutation_reader.hh"
|
|
#include "sstables/progress_monitor.hh"
|
|
#include "sstables/types_fwd.hh"
|
|
#include "sstables/index_reader.hh"
|
|
|
|
namespace sstables {
|
|
namespace mx {
|
|
|
|
// Precondition: if the slice is reversed, the schema must be reversed as well
|
|
// and the range must be singular (`range.is_singular()`).
|
|
// Fast-forwarding is not supported in reversed queries (FIXME).
|
|
mutation_reader make_reader(
|
|
shared_sstable sstable,
|
|
schema_ptr schema,
|
|
reader_permit permit,
|
|
const dht::partition_range& range,
|
|
const query::partition_slice& slice,
|
|
tracing::trace_state_ptr trace_state,
|
|
streamed_mutation::forwarding fwd,
|
|
mutation_reader::forwarding fwd_mr,
|
|
read_monitor& monitor,
|
|
integrity_check integrity,
|
|
std::unique_ptr<abstract_index_reader>);
|
|
|
|
// Same as above but the slice is moved and stored inside the reader.
|
|
mutation_reader make_reader(
|
|
shared_sstable sstable,
|
|
schema_ptr schema,
|
|
reader_permit permit,
|
|
const dht::partition_range& range,
|
|
query::partition_slice&& slice,
|
|
tracing::trace_state_ptr trace_state,
|
|
streamed_mutation::forwarding fwd,
|
|
mutation_reader::forwarding fwd_mr,
|
|
read_monitor& monitor,
|
|
integrity_check integrity,
|
|
std::unique_ptr<abstract_index_reader>);
|
|
|
|
// A reader which doesn't use the index at all. It reads everything from the
|
|
// sstable and it doesn't support skipping.
|
|
mutation_reader make_full_scan_reader(
|
|
shared_sstable sstable,
|
|
schema_ptr schema,
|
|
reader_permit permit,
|
|
tracing::trace_state_ptr trace_state,
|
|
read_monitor& monitor,
|
|
integrity_check integrity);
|
|
|
|
// Validate the content of the sstable with the mutation_fragment_stream_valdiator,
|
|
// additionally cross checking that the content is laid out as expected by the
|
|
// index and promoted index respectively.
|
|
future<uint64_t> validate(
|
|
shared_sstable sstable,
|
|
reader_permit permit,
|
|
abort_source& abort,
|
|
std::function<void(sstring)> error_handler,
|
|
sstables::read_monitor& monitor);
|
|
|
|
} // namespace mx
|
|
} // namespace sstables
|