a51529dd15
In early versions of the series which proposed protocol servers, the interface had two methods answering pretty much the same question of whether the server is running or not: * listen_addresses(): empty list -> server not running * is_server_running() To reduce redundancy and to avoid possible inconsistencies between the two methods, `is_server_running()` was scrapped, but re-added by a follow-up patch because `listen_addresses()` proved to be unreliable as a source for whether the server is running or not. This patch restores the previous state of having only `listen_addresses()` with two additional changes: * rephrase the comment on `listen_addresses()` to make it clear that implementations must return empty list when the server is not running; * those implementations that have a reliable source of whether the server is running or not, use it to force-return an empty list when the server is not running Tests: dtest(nodetool_additional_test.py) Signed-off-by: Botond Dénes <bdenes@scylladb.com> Message-Id: <20211117062539.16932-1-bdenes@scylladb.com>
96 lines
2.6 KiB
C++
96 lines
2.6 KiB
C++
/*
|
|
* Copyright (C) 2021-present ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* This file is part of Scylla.
|
|
*
|
|
* Scylla is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* Scylla is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with Scylla. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <seastar/core/sharded.hh>
|
|
#include <seastar/core/smp.hh>
|
|
|
|
#include "protocol_server.hh"
|
|
|
|
namespace service {
|
|
class storage_proxy;
|
|
class migration_manager;
|
|
class memory_limiter;
|
|
}
|
|
|
|
namespace db {
|
|
class system_distributed_keyspace;
|
|
class config;
|
|
}
|
|
|
|
namespace cdc {
|
|
class generation_service;
|
|
}
|
|
|
|
namespace gms {
|
|
|
|
class gossiper;
|
|
|
|
}
|
|
|
|
namespace alternator {
|
|
|
|
// This is the official DynamoDB API version.
|
|
// It represents the last major reorganization of that API, and all the features
|
|
// that were added since did NOT increment this version string.
|
|
constexpr const char* version = "2012-08-10";
|
|
|
|
using namespace seastar;
|
|
|
|
class executor;
|
|
class server;
|
|
|
|
class controller : public protocol_server {
|
|
sharded<gms::gossiper>& _gossiper;
|
|
sharded<service::storage_proxy>& _proxy;
|
|
sharded<service::migration_manager>& _mm;
|
|
sharded<db::system_distributed_keyspace>& _sys_dist_ks;
|
|
sharded<cdc::generation_service>& _cdc_gen_svc;
|
|
sharded<service::memory_limiter>& _memory_limiter;
|
|
const db::config& _config;
|
|
|
|
std::vector<socket_address> _listen_addresses;
|
|
sharded<executor> _executor;
|
|
sharded<server> _server;
|
|
std::optional<smp_service_group> _ssg;
|
|
|
|
public:
|
|
controller(
|
|
sharded<gms::gossiper>& gossiper,
|
|
sharded<service::storage_proxy>& proxy,
|
|
sharded<service::migration_manager>& mm,
|
|
sharded<db::system_distributed_keyspace>& sys_dist_ks,
|
|
sharded<cdc::generation_service>& cdc_gen_svc,
|
|
sharded<service::memory_limiter>& memory_limiter,
|
|
const db::config& config);
|
|
|
|
virtual sstring name() const override;
|
|
virtual sstring protocol() const override;
|
|
virtual sstring protocol_version() const override;
|
|
virtual std::vector<socket_address> listen_addresses() const override;
|
|
virtual future<> start_server() override;
|
|
virtual future<> stop_server() override;
|
|
virtual future<> request_stop_server() override;
|
|
};
|
|
|
|
}
|