Files
scylladb/utils/exception_container.hh
Piotr Dulikowski 742f2abfd8 exception_container: do not throw in accept
This commit changes the behavior of `exception_container::accept`. Now,
instead of throwing an `utils::bad_exception_container_access` exception
when the container is empty, the provided visitor is invoked with that
exception instead. There are two reasons for this change:

- The exception_container is supposed to allow handling exceptions
  without using the costly C++'s exception runtime. Although an empty
  container is an edge case, I think it the new behavior is more aligned
  with the class' purpose. The old behavior can be simulated by
  providing a visitor which throws when called with bad access
  exception.

- The new behavior fixes a bug in `result_try`/`result_futurize_try`.
  Before the change, if the `try` block returned a failed result with an
  empty exception container, a bad access exception would either be
  thrown or returned as an exceptional future without being handled by
  the `catch` clauses. Although nobody is supposed to return such
  result<>s on purpose, a moved out result can be returned by accident
  and it's important for the exception handling logic to be correct in
  such a situation.

Tests: unit(dev)

Closes #10086
2022-02-16 10:06:10 +02:00

147 lines
4.6 KiB
C++

/*
* Copyright 2022-present ScyllaDB
*/
/*
* SPDX-License-Identifier: AGPL-3.0-or-later
*/
#pragma once
#include <exception>
#include <typeinfo>
#include <type_traits>
#include <memory>
#include <ostream>
#include <variant>
#include <seastar/core/future.hh>
#include <seastar/core/distributed.hh>
#include <seastar/util/log.hh>
#include "utils/variant_element.hh"
namespace utils {
class bad_exception_container_access : public std::exception {
public:
const char* what() const noexcept override {
return "bad exception container access";
}
};
// A variant-like type capable of holding one of the allowed exception types.
// This allows inspecting the exception in the error handling code without
// having to resort to costly rethrowing of std::exception_ptr, as is
// in the case of the usual exception handling.
//
// It's not as ergonomic as using exceptions with seastar, but allows for
// fast inspection and manipulation.
//
// Exceptions are held in a std::variant. The variant is kept behind
// a std::unique_ptr to ensure that moves are cheap. This means that
// a moved-out exception container becomes "empty" and does not contain
// a valid exception.
//
// Copying is not supported.
template<typename... Exs>
struct exception_container {
private:
using exception_variant = std::variant<Exs...>;
// TODO: Idea for a possible improvement: get rid of the variant
// and just store a pointer to an error allocated on the heap.
// Keep an integer which identifies the variant.
// Bonus points: if each error type has a unique, globally-assigned
// identified integer, then conversion of the exception_container
// to a container supporting a superset of errors becomes very cheap.
seastar::foreign_ptr<std::unique_ptr<std::variant<Exs...>>> _eptr;
void check_nonempty() const {
if (empty()) {
throw bad_exception_container_access();
}
}
public:
// Constructs an exception_container which does not contain any exception.
exception_container() = default;
template<typename Ex>
requires VariantElement<Ex, exception_variant>
exception_container(Ex&& ex)
: _eptr(seastar::make_foreign(std::make_unique<exception_variant>(std::move(ex))))
{ }
inline bool empty() const {
return __builtin_expect(!_eptr, false);
}
inline operator bool() const {
return !empty();
}
// Accepts a visitor.
// If the container is empty, the visitor is called with
// a bad_exception_container_access.
auto accept(auto f) const {
if (empty()) {
return f(bad_exception_container_access());
}
return std::visit(std::move(f), *_eptr);
}
// Throws currently held exception as a C++ exception.
// If the container is empty, it throws bad_exception_container_access.
[[noreturn]] void throw_me() const {
check_nonempty();
std::visit([] (const auto& ex) { throw ex; }, *_eptr);
std::terminate(); // Should be unreachable
}
// Creates an exceptional future from this error.
// The exception is copied into the new exceptional future.
// If the container is empty, returns an exceptional future
// with the bad_exception_container_access exception.
template<typename T = void>
seastar::future<T> as_exception_future() const & {
if (!_eptr) {
return seastar::make_exception_future<T>(bad_exception_container_access());
}
return std::visit([] (const auto& ex) {
return seastar::make_exception_future<T>(ex);
}, *_eptr);
}
// Transforms this exception future into an exceptional future.
// The exception is moved out and the container becomes empty.
// If the container was empty, returns an exceptional future
// with the bad_exception_container_access exception.
template<typename T = void>
seastar::future<T> into_exception_future() && {
if (!_eptr) {
return seastar::make_exception_future<T>(bad_exception_container_access());
}
auto f = std::visit([] (auto&& ex) {
return seastar::make_exception_future<T>(std::move(ex));
}, *_eptr);
_eptr.reset();
return f;
}
};
template<typename... Exs>
inline std::ostream& operator<<(std::ostream& os, const exception_container<Exs...>& ec) {
ec.accept([&os] (const auto& ex) { os << ex; });
return os;
}
template<typename T>
struct is_exception_container : std::false_type {};
template<typename... Exs>
struct is_exception_container<exception_container<Exs...>> : std::true_type {};
template<typename T>
concept ExceptionContainer = is_exception_container<T>::value;
}