Files
scylladb/gms/versioned_value.cc
Kefu Chai bab12e3a98 treewide: migrate from boost::adaptors::transformed to std::views::transform
now that we are allowed to use C++23. we now have the luxury of using
`std::views::transform`.

in this change, we:

- replace `boost::adaptors::transformed` with `std::views::transform`
- use `fmt::join()` when appropriate where `boost::algorithm::join()`
  is not applicable to a range view returned by `std::view::transform`.
- use `std::ranges::fold_left()` to accumulate the range returned by
  `std::view::transform`
- use `std::ranges::fold_left()` to get the maximum element in the
  range returned by `std::view::transform`
- use `std::ranges::min()` to get the minimal element in the range
  returned by `std::view::transform`
- use `std::ranges::equal()` to compare the range views returned
  by `std::view::transform`
- remove unused `#include <boost/range/adaptor/transformed.hpp>`
- use `std::ranges::subrange()` instead of `boost::make_iterator_range()`,
  to feed `std::views::transform()` a view range.

to reduce the dependency to boost for better maintainability, and
leverage standard library features for better long-term support.

this change is part of our ongoing effort to modernize our codebase
and reduce external dependencies where possible.

limitations:

there are still a couple places where we are still using
`boost::adaptors::transformed` due to the lack of a C++23 alternative
for `boost::join()` and `boost::adaptors::uniqued`.

Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>

Closes scylladb/scylladb#21700
2024-12-03 09:41:32 +02:00

106 lines
3.4 KiB
C++

/*
*
* Modified by ScyllaDB
* Copyright (C) 2015-present ScyllaDB
*/
/*
* SPDX-License-Identifier: (AGPL-3.0-or-later and Apache-2.0)
*/
#include "gms/versioned_value.hh"
#include "message/messaging_service.hh"
#include <boost/algorithm/string/split.hpp>
#include <boost/algorithm/string/classification.hpp>
#include <charconv>
namespace gms {
static_assert(std::is_nothrow_default_constructible_v<versioned_value>);
static_assert(std::is_nothrow_move_constructible_v<versioned_value>);
versioned_value versioned_value::network_version() {
return versioned_value(format("{}", netw::messaging_service::current_version));
}
sstring versioned_value::make_full_token_string(const std::unordered_set<dht::token>& tokens) {
return fmt::to_string(fmt::join(tokens | std::views::transform([] (const dht::token& t) {
return t.to_sstring(); }), ";"));
}
sstring versioned_value::make_token_string(const std::unordered_set<dht::token>& tokens) {
if (tokens.empty()) {
return "";
}
return tokens.begin()->to_sstring();
}
sstring versioned_value::make_cdc_generation_id_string(std::optional<cdc::generation_id> gen_id) {
// We assume that the db_clock epoch is the same on all receiving nodes.
if (!gen_id) {
return "";
}
return std::visit(make_visitor(
[] (const cdc::generation_id_v1& id) -> sstring {
return std::to_string(id.ts.time_since_epoch().count());
},
[] (const cdc::generation_id_v2& id) {
// v2;<timestamp>;<uuid>
return format("v2;{};{}", id.ts.time_since_epoch().count(), id.id);
}
), *gen_id);
}
std::unordered_set<dht::token> versioned_value::tokens_from_string(const sstring& s) {
if (s.size() == 0) {
return {}; // boost::split produces one element for empty string
}
std::vector<sstring> tokens;
boost::split(tokens, s, boost::is_any_of(";"));
std::unordered_set<dht::token> ret;
for (auto str : tokens) {
ret.emplace(dht::token::from_sstring(str));
}
return ret;
}
std::optional<cdc::generation_id> versioned_value::cdc_generation_id_from_string(const sstring& s) {
if (s.empty()) {
return {};
}
if (std::string_view(s).starts_with("v2;")) {
// v2;<timestamp>;<uuid>
constexpr auto invalid_format_template = "Invalid value of CDC generation ID string: {}. The format is \"v2;<timestamp>;<uuid>\".";
const char* const end = s.c_str() + s.size();
int64_t ts;
auto r = std::from_chars(s.c_str() + 3, end, ts);
if (r.ec != std::errc() || r.ptr == end || *r.ptr != ';') {
throw std::runtime_error(format(invalid_format_template, s));
}
++r.ptr; // r.ptr now points to <uuid>
if (r.ptr == end) {
throw std::runtime_error(format(invalid_format_template, s));
}
try {
auto tp = db_clock::time_point{db_clock::duration{ts}};
auto id = utils::UUID{std::string_view{r.ptr, end}};
return cdc::generation_id_v2{tp, id};
} catch (...) {
throw std::runtime_error(format(invalid_format_template, s));
}
}
try {
return cdc::generation_id_v1{db_clock::time_point{db_clock::duration(std::stoll(s))}};
} catch (...) {
throw std::runtime_error(format("Invalid value of CDC generation ID string: {}. Should be <timestamp> (an unsigned integer).", s));
}
}
}