Benny Halevy 63c2cdafe8 sstables: index_reader: close(index_bound&) reset current_list ...

When closing _lower_bound and *_upper_bound
in the final close() call, they are currently left with
an engaged current_list member.

If the index_reader uses a _local_index_cache,
it is evicted with evict_gently which will, rightfully,
see the respective pages as referenced, and they won't be
evicted gently (only later when the index_reader is destroyed).

Reset index_bound.current_list on close(index_bound&)
to free up the reference.

Ref #12271

Signed-off-by: Benny Halevy <bhalevy@scylladb.com>

Closes #12370

2023-01-02 16:42:33 +01:00

..

kl

treewide: use ::for_partition_end() instead of ::end_of_partition_tag_t{}

2022-11-11 09:58:18 +02:00

mx

sstables: Bump row_reads metrics for mx version

2022-12-30 18:38:30 +01:00

binary_search.hh

treewide: use Software Package Data Exchange (SPDX) license identifiers

2022-01-18 12:15:18 +01:00

checksum_utils.hh

build: switch to packaged libdeflate rather than a submodule

2022-11-17 08:01:00 +02:00

column_translation.hh

schema, everywhere: define and use table_schema_version as a strong type

2022-08-08 08:09:45 +03:00

component_type.hh

treewide: use Software Package Data Exchange (SPDX) license identifiers

2022-01-18 12:15:18 +01:00

compress.cc

treewide: use Software Package Data Exchange (SPDX) license identifiers

2022-01-18 12:15:18 +01:00

compress.hh

treewide: use Software Package Data Exchange (SPDX) license identifiers

2022-01-18 12:15:18 +01:00

consumer.hh

sstables: consumer: reuse the fragmented_temporary_buffer in read_bytes()

2022-05-07 13:04:16 +02:00

disk_types.hh

code: Convert is_integral assertions to concepts

2022-02-24 19:44:29 +03:00

downsampling.hh

cross-tree: fix header file self-sufficiency

2022-07-08 12:59:14 +03:00

exceptions.hh

treewide: use Software Package Data Exchange (SPDX) license identifiers

2022-01-18 12:15:18 +01:00

filter.hh

treewide: use Software Package Data Exchange (SPDX) license identifiers

2022-01-18 12:15:18 +01:00

generation_type.hh

sstables: generation_type: forgo constexpr on hash of generation_type

2022-11-28 21:58:30 +02:00

hyperloglog.hh

treewide: use Software Package Data Exchange (SPDX) license identifiers

2022-01-18 12:15:18 +01:00

index_entry.hh

treewide: use Software Package Data Exchange (SPDX) license identifiers

2022-01-18 12:15:18 +01:00

index_reader.hh

sstables: index_reader: close(index_bound&) reset current_list

2023-01-02 16:42:33 +01:00

integrity_checked_file_impl.cc

treewide: use Software Package Data Exchange (SPDX) license identifiers

2022-01-18 12:15:18 +01:00

integrity_checked_file_impl.hh

treewide: use Software Package Data Exchange (SPDX) license identifiers

2022-01-18 12:15:18 +01:00

key.hh

treewide: use Software Package Data Exchange (SPDX) license identifiers

2022-01-18 12:15:18 +01:00

liveness_info.hh

treewide: use Software Package Data Exchange (SPDX) license identifiers

2022-01-18 12:15:18 +01:00

m_format_read_helpers.cc

treewide: use Software Package Data Exchange (SPDX) license identifiers

2022-01-18 12:15:18 +01:00

m_format_read_helpers.hh

treewide: use Software Package Data Exchange (SPDX) license identifiers

2022-01-18 12:15:18 +01:00

metadata_collector.cc

position_in_partition: Make after_key() work with non-full keys

2022-12-14 14:47:33 +01:00

metadata_collector.hh

everywhere: define locator::host_id as a strong tagged_uuid type

2022-08-12 06:01:44 +03:00

mutation_fragment_filter.hh

compile: Fix headers so that *-headers targets compile cleanly.

2022-03-25 16:19:26 +02:00

open_info.hh

sstables: define generation_type for sstables

2022-05-11 14:46:30 +02:00

partition_index_cache.hh

utils: lru: remove unlink_from_lru()

2022-10-17 12:07:27 +02:00

prepended_input_stream.cc

treewide: use Software Package Data Exchange (SPDX) license identifiers

2022-01-18 12:15:18 +01:00

prepended_input_stream.hh

treewide: use Software Package Data Exchange (SPDX) license identifiers

2022-01-18 12:15:18 +01:00

processing_result_generator.hh

sstables: processing_result_generator: prefer standard coroutines over the technical specification with clang 14

2022-06-12 20:05:28 +03:00

progress_monitor.hh

treewide: use Software Package Data Exchange (SPDX) license identifiers

2022-01-18 12:15:18 +01:00

promoted_index_blocks_reader.hh

compile: Fix headers so that *-headers targets compile cleanly.

2022-03-25 16:19:26 +02:00

random_access_reader.cc

treewide: use Software Package Data Exchange (SPDX) license identifiers

2022-01-18 12:15:18 +01:00

random_access_reader.hh

treewide: use Software Package Data Exchange (SPDX) license identifiers

2022-01-18 12:15:18 +01:00

scanning_clustered_index_cursor.hh

treewide: use Software Package Data Exchange (SPDX) license identifiers

2022-01-18 12:15:18 +01:00

segmented_compress_params.hh

treewide: use Software Package Data Exchange (SPDX) license identifiers

2022-01-18 12:15:18 +01:00

shareable_components.hh

treewide: use Software Package Data Exchange (SPDX) license identifiers

2022-01-18 12:15:18 +01:00

shared_sstable.hh

treewide: use Software Package Data Exchange (SPDX) license identifiers

2022-01-18 12:15:18 +01:00

sstable_directory.cc

sstable: Remove get_dir() (well, almost)

2022-12-15 10:14:49 +03:00

sstable_directory.hh

sstable_directory: Extract directory lister

2022-12-05 12:03:19 +03:00

sstable_mutation_reader.cc

sstables: move mp_row_consumer_reader_k_l to kl/reader.cc

2022-04-28 14:12:24 +03:00

sstable_mutation_reader.hh

code: Reduce fanout of sstables(_manager)?.hh over headers

2022-12-07 14:34:19 +02:00

sstable_set_impl.hh

sstables: define run_identifier as a strong tagged_uuid type

2022-08-18 19:03:10 +03:00

sstable_set.cc

code: Reduce fanout of sstables(_manager)?.hh over headers

2022-12-07 14:34:19 +02:00

sstable_set.hh

sstables: Enforce disjoint invariant in sstable_run

2022-07-27 14:48:28 +03:00

sstable_version_k_l.hh

treewide: use Software Package Data Exchange (SPDX) license identifiers

2022-01-18 12:15:18 +01:00

sstable_version_m.hh

treewide: use Software Package Data Exchange (SPDX) license identifiers

2022-01-18 12:15:18 +01:00

sstable_version.cc

add support for the ME sstable format

2022-02-16 18:21:24 +02:00

sstable_version.hh

treewide: use Software Package Data Exchange (SPDX) license identifiers

2022-01-18 12:15:18 +01:00

sstable_writer.hh

sstables: convert mx writer to v2

2022-03-10 07:03:49 +02:00

sstables_manager.cc

sstable_directory: Get components lister from manager

2022-12-05 12:03:19 +03:00

sstables_manager.hh

code: Reduce fanout of sstables(_manager)?.hh over headers

2022-12-07 14:34:19 +02:00

sstables.cc

sstables: allow bypassing first/last position metadata loading

2022-12-20 01:45:38 -05:00

sstables.hh

sstables: allow bypassing first/last position metadata loading

2022-12-20 01:45:38 -05:00

stats.hh

sstables: mx: add pi_auto_scale_events metric

2022-05-24 13:32:39 +03:00

types_fwd.hh

sstables: define run_identifier as a strong tagged_uuid type

2022-08-18 19:03:10 +03:00

types.hh

sstables: mx/writer: add large_data_type::elements_in_collection

2022-10-04 08:41:56 +03:00

version.hh

add support for the ME sstable format

2022-02-16 18:21:24 +02:00

writer_impl.hh

code: Reduce fanout of sstables(_manager)?.hh over headers

2022-12-07 14:34:19 +02:00

writer.cc

treewide: use ::for_partition_start() instead of ::partition_start_tag_t{}

2022-11-11 09:58:18 +02:00

writer.hh

everywhere: define locator::host_id as a strong tagged_uuid type

2022-08-12 06:01:44 +03:00