b7afda5030
When `mx::make_reader` is used to construct an sstable reader, it constructs its own index reader internally. `mx::make_reader_with_index_reader` was originally added as a variant of `mx::make_reader` which can be used to inject a custom `index_reader` for testing that the mx Data reader tolerates inexact indexes. But now we want the ability to choose between BIG index readers and BTI index readers if both are present. And at this point, it seems to me that it makes sense to just construct the index reader in the caller and pass it via argument to `mx::make_reader` instead of putting the index selection inside it. So that's what we do in this patch. And we remove `mx::make_reader_with_index_reader` because it's no longer different from `mx::make_reader`.
Scylla in-source tests.
For details on how to run the tests, see docs/dev/testing.md
Shared C++ utils, libraries are in lib/, for Python - pylib/
alternator - Python tests which connect to a single server and use the DynamoDB API unit, boost, raft - unit tests in C++ cqlpy - Python tests which connect to a single server and use CQL topology* - tests that set up clusters and add/remove nodes cql - approval tests that use CQL and pre-recorded output rest_api - tests for Scylla REST API Port 9000 scylla-gdb - tests for scylla-gdb.py helper script nodetool - tests for C++ implementation of nodetool
If you can use an existing folder, consider adding your test to it. New folders should be used for new large categories/subsystems, or when the test environment is significantly different from some existing suite, e.g. you plan to start scylladb with different configuration, and you intend to add many tests and would like them to reuse an existing Scylla cluster (clusters can be reused for tests within the same folder).
To add a new folder, create a new directory, and then
copy & edit its suite.ini.