mirror of
https://github.com/scylladb/scylladb.git
synced 2026-05-23 00:02:37 +00:00
d2d7604188
Pin all external GitHub Actions to full commit SHAs and upgrade to their latest major versions to reduce supply chain attack surface: - actions/checkout: v3/v4/v5 -> v6.0.2 - actions/github-script: v7 -> v8.0.0 - actions/setup-python: v5 -> v6.2.0 - actions/upload-artifact: v4 -> v7.0.0 - astral-sh/setup-uv: v6 -> v8.0.0 - mheap/github-action-required-labels: v5.5.2 (pinned) - redhat-plumbers-in-action/differential-shellcheck: v5.5.6 (pinned) - codespell-project/actions-codespell: v2.2 (pinned, was @master) Set FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true in all 21 workflows that use JavaScript-based actions to opt into the Node.js 24 runtime now. This resolves the deprecation warning: "Node.js 20 actions are deprecated. Please check if updated versions of these actions are available that support Node.js 24. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026." See: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/ scylladb/github-automation references are intentionally left at @main as they are org-internal reusable workflows. Fixes: SCYLLADB-1410 Backport: Backport is required for live branches that run GH actions: 2026.1, 2025.4, 2025.1 and 2024.1 Closes scylladb/scylladb#29421
71 lines
2.2 KiB
YAML
71 lines
2.2 KiB
YAML
name: clang-tidy
|
|
|
|
on:
|
|
pull_request:
|
|
branches:
|
|
- master
|
|
paths-ignore:
|
|
- '**/*.rst'
|
|
- '**/*.md'
|
|
- 'docs/**'
|
|
- '.github/**'
|
|
workflow_dispatch:
|
|
issue_comment:
|
|
types:
|
|
- created
|
|
|
|
env:
|
|
BUILD_TYPE: RelWithDebInfo
|
|
BUILD_DIR: build
|
|
CLANG_TIDY_CHECKS: '-*,bugprone-use-after-move'
|
|
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
|
|
|
|
permissions: {}
|
|
|
|
# cancel the in-progress run upon a repush
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
read-toolchain:
|
|
if: github.event_name == 'pull_request' || (github.event.issue.pull_request && startsWith(github.event.comment.body, '/clang-tidy'))
|
|
uses: ./.github/workflows/read-toolchain.yaml
|
|
clang-tidy:
|
|
name: Run clang-tidy
|
|
needs:
|
|
- read-toolchain
|
|
if: "${{ needs.read-toolchain.result == 'success' }}"
|
|
runs-on: ubuntu-latest
|
|
container: ${{ needs.read-toolchain.outputs.image }}
|
|
steps:
|
|
- env:
|
|
IMAGE: ${{ needs.read-toolchain.image }}
|
|
run: |
|
|
echo ${{ needs.read-toolchain.image }}
|
|
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
|
|
with:
|
|
submodules: true
|
|
- run: |
|
|
sudo dnf -y install clang-tools-extra
|
|
- name: Generate the building system
|
|
run: |
|
|
cmake \
|
|
-DCMAKE_BUILD_TYPE=$BUILD_TYPE \
|
|
-DCMAKE_C_COMPILER=clang \
|
|
-DScylla_USE_LINKER=ld.lld \
|
|
-DCMAKE_CXX_COMPILER=clang++ \
|
|
-DCMAKE_EXPORT_COMPILE_COMMANDS=ON \
|
|
-DCMAKE_CXX_CLANG_TIDY="clang-tidy;--checks=$CLANG_TIDY_CHECKS" \
|
|
-G Ninja \
|
|
-B $BUILD_DIR \
|
|
-S .
|
|
# see https://github.com/actions/toolkit/blob/main/docs/problem-matchers.md
|
|
- run: |
|
|
echo "::add-matcher::.github/clang-matcher.json"
|
|
- name: Build with clang-tidy enabled
|
|
run: |
|
|
cmake --build $BUILD_DIR --target scylla
|
|
- run: |
|
|
echo "::remove-matcher owner=clang::"
|