mirror of
https://github.com/scylladb/scylladb.git
synced 2026-05-23 08:12:08 +00:00
dc05bd35bb
Strong consistent requests take different patch then EC requests and consistency levels don’t map well. We should limit available consistency levels in SC request to avoid ignoring them silently, which may cause confusion to user. For writes, there is only one option: - QUORUM/LOCAL_QUORUM (multi DC is not supported yet, so both of those CLs have the same effect) - we need quorum of replicas to successfully commit new mutations to Raft log. For reads, there are 2 options: - QUORUM/LOCAL_QUORUM - if user wants to be sure he sees latest data and the query needs to execute `read_barrier()`, which requires quorum of replicas - ONE/LOCAL_ONE - if user just wants to read data from one replica without synchronization All tests were updated to use LOCAL_QUORUM for both read and writes. Fixes SCYLLADB-1766 SC is in experimental phase and this patch is an improvement, no backport needed. Closes scylladb/scylladb#29691 * github.com:scylladb/scylladb: strong_consistency: allow QUORUM/LOCAL_QUORUM and ONE/LOCAL_ONE for reads strong_consistency: allow only QUORUM/LOCAL_QUORUM CL for writes
68 lines
2.8 KiB
C++
68 lines
2.8 KiB
C++
/*
|
|
* Copyright (C) 2025-present ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: LicenseRef-ScyllaDB-Source-Available-1.1
|
|
*/
|
|
|
|
#include "select_statement.hh"
|
|
|
|
#include "db/consistency_level_type.hh"
|
|
#include "query/query-request.hh"
|
|
#include "cql3/query_processor.hh"
|
|
#include "service/strong_consistency/coordinator.hh"
|
|
#include "cql3/statements/strong_consistency/statement_helpers.hh"
|
|
|
|
namespace cql3::statements::strong_consistency {
|
|
|
|
using result_message = cql_transport::messages::result_message;
|
|
|
|
static void validate_consistency_level(const db::consistency_level& cl) {
|
|
if (cl != db::consistency_level::QUORUM && cl != db::consistency_level::LOCAL_QUORUM &&
|
|
cl != db::consistency_level::ONE && cl != db::consistency_level::LOCAL_ONE) {
|
|
throw exceptions::invalid_request_exception("Strongly consistent reads must use QUORUM/LOCAL_QUORUM or ONE/LOCAL_ONE consistency level");
|
|
}
|
|
}
|
|
|
|
future<::shared_ptr<result_message>> select_statement::do_execute(query_processor& qp,
|
|
service::query_state& state,
|
|
const query_options& options) const
|
|
{
|
|
validate_consistency_level(options.get_consistency());
|
|
|
|
const auto key_ranges = _restrictions->get_partition_key_ranges(options);
|
|
if (key_ranges.size() != 1 || !query::is_single_partition(key_ranges[0])) {
|
|
throw exceptions::invalid_request_exception("Strongly consistent queries can only target a single partition");
|
|
}
|
|
const auto now = gc_clock::now();
|
|
auto read_command = make_lw_shared<query::read_command>(
|
|
_query_schema->id(),
|
|
_query_schema->version(),
|
|
make_partition_slice(options),
|
|
query::max_result_size(query::result_memory_limiter::maximum_result_size),
|
|
query::tombstone_limit(query::tombstone_limit::max),
|
|
query::row_limit(get_inner_loop_limit(get_limit(options, _limit), _selection->is_aggregate())),
|
|
query::partition_limit(query::max_partitions),
|
|
now,
|
|
tracing::make_trace_info(state.get_trace_state()),
|
|
query_id::create_null_id(),
|
|
query::is_first_page::no,
|
|
options.get_timestamp(state));
|
|
const auto timeout = db::timeout_clock::now() + get_timeout(state.get_client_state(), options);
|
|
auto [coordinator, holder] = qp.acquire_strongly_consistent_coordinator();
|
|
auto query_result = co_await coordinator.get().query(_query_schema, *read_command,
|
|
key_ranges, state.get_trace_state(), timeout, state.get_client_state().get_abort_source());
|
|
|
|
using namespace service::strong_consistency;
|
|
if (const auto* redirect = get_if<need_redirect>(&query_result)) {
|
|
bool is_write = false;
|
|
co_return co_await redirect_statement(qp, options, redirect->target, timeout, is_write, coordinator.get().get_stats());
|
|
}
|
|
|
|
co_return co_await process_results(get<lw_shared_ptr<query::result>>(std::move(query_result)),
|
|
read_command, options, now);
|
|
}
|
|
|
|
}
|